Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
245e47b9
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
245e47b9
编写于
12月 05, 2017
作者:
S
Sam Harwell
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Simplify and document the check for using alias directives
上级
4d9f7097
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
39 addition
and
27 deletion
+39
-27
src/Workspaces/CSharp/Portable/Extensions/ExpressionSyntaxExtensions.cs
.../CSharp/Portable/Extensions/ExpressionSyntaxExtensions.cs
+39
-27
未找到文件。
src/Workspaces/CSharp/Portable/Extensions/ExpressionSyntaxExtensions.cs
浏览文件 @
245e47b9
...
...
@@ -1000,6 +1000,9 @@ public static bool IsAliasReplaceableExpression(this ExpressionSyntax expression
return
false
;
}
[
PerformanceSensitive
(
"https://github.com/dotnet/roslyn/issues/23582"
,
Constraint
=
"Most trees do not have using alias directives, so avoid the expensive "
+
nameof
(
CSharpExtensions
.
GetSymbolInfo
)
+
" call for this case."
)]
private
static
bool
TryReplaceWithAlias
(
this
ExpressionSyntax
node
,
SemanticModel
semanticModel
,
bool
preferAliasToQualifiedName
,
CancellationToken
cancellationToken
,
out
IAliasSymbol
aliasReplacement
)
{
aliasReplacement
=
null
;
...
...
@@ -1010,49 +1013,58 @@ private static bool TryReplaceWithAlias(this ExpressionSyntax node, SemanticMode
}
// Avoid the TryReplaceWithAlias algorithm if the tree has no using alias directives. Since the input node
// might be a speculative node (not fully rooted in a tree), we use the
position of the evaluation to find
//
the
equivalent node in the original tree, and from there determine if the tree has any using alias
// might be a speculative node (not fully rooted in a tree), we use the
original semantic model to find the
// equivalent node in the original tree, and from there determine if the tree has any using alias
// directives.
var
originalModel
=
semanticModel
;
var
originalPosition
=
node
.
SpanStart
;
while
(
originalModel
.
IsSpeculativeSemanticModel
)
{
originalPosition
=
originalModel
.
OriginalPositionForSpeculation
;
originalModel
=
originalModel
.
ParentModel
;
}
// Perf: We are only using the syntax tree root in a fast-path syntax check. If the root is not readily
// available, it is fine to continue through the normal algorithm.
if
(
originalModel
.
SyntaxTree
.
TryGetRoot
(
out
var
root
))
{
var
token
=
root
.
FindTokenOnLeftOfPosition
(
originalPosition
);
var
tokenParent
=
token
.
Parent
;
var
aliasContainer
=
tokenParent
?.
FirstAncestorOrSelf
<
SyntaxNode
>(
syntax
=>
bool
HasUsingAliasDirective
(
SyntaxNode
syntax
)
{
SyntaxList
<
UsingDirectiveSyntax
>
usings
;
SyntaxList
<
MemberDeclarationSyntax
>
members
;
if
(
syntax
.
IsKind
(
SyntaxKind
.
NamespaceDeclaration
,
out
NamespaceDeclarationSyntax
namespaceDeclaration
))
{
SyntaxList
<
UsingDirectiveSyntax
>
usings
;
if
(
syntax
.
IsKind
(
SyntaxKind
.
NamespaceDeclaration
,
out
NamespaceDeclarationSyntax
namespaceDeclaration
))
{
usings
=
namespaceDeclaration
.
Usings
;
}
else
if
(
syntax
.
IsKind
(
SyntaxKind
.
CompilationUnit
,
out
CompilationUnitSyntax
compilationUnit
))
{
usings
=
compilationUnit
.
Usings
;
}
else
usings
=
namespaceDeclaration
.
Usings
;
members
=
namespaceDeclaration
.
Members
;
}
else
if
(
syntax
.
IsKind
(
SyntaxKind
.
CompilationUnit
,
out
CompilationUnitSyntax
compilationUnit
))
{
usings
=
compilationUnit
.
Usings
;
members
=
compilationUnit
.
Members
;
}
else
{
return
false
;
}
foreach
(
var
usingDirective
in
usings
)
{
if
(
usingDirective
.
Alias
!=
null
)
{
return
fals
e
;
return
tru
e
;
}
}
foreach
(
var
usingDirective
in
usings
)
foreach
(
var
member
in
members
)
{
if
(
HasUsingAliasDirective
(
member
))
{
if
(
usingDirective
.
Alias
!=
null
)
{
return
true
;
}
return
true
;
}
}
return
false
;
});
if
(
tokenParent
!=
null
&&
aliasContainer
==
null
)
return
false
;
}
if
(!
HasUsingAliasDirective
(
root
))
{
return
false
;
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录