Avoid a few more allocations in another DocumentState path.

22cdd2c5 · Cyrus Najmabadi · efa39338 · 22cdd2c5
隐藏空白更改
内联并排

Showing with 13 addition and 8 deletion

src/Workspaces/Core/Portable/Workspace/Solution/DocumentState.cs ...kspaces/Core/Portable/Workspace/Solution/DocumentState.cs +13 -8

未找到文件。
--- a/src/Workspaces/Core/Portable/Workspace/Solution/DocumentState.cs
+++ b/src/Workspaces/Core/Portable/Workspace/Solution/DocumentState.cs
@@ -363,14 +363,19 @@ public new DocumentState UpdateText(TextLoader loader, PreservationMode mode)
                ? CreateStrongText(loader, this.Id, this.solutionServices, reportInvalidDataException: true)
                : CreateRecoverableText(loader, this.Id, this.solutionServices, reportInvalidDataException: true);
-            var newTreeSource = CreateLazyFullyParsedTree(
+            // Only create the ValueSource for creating the SyntaxTree if this is a Document that
-                newTextSource,
+            // supports SyntaxTrees.  There's no point in creating the async lazy and holding onto
-                this.Id.ProjectId,
+            // this data otherwise.
-                GetSyntaxTreeFilePath(this.info),
+            var newTreeSource = !this.SupportsSyntaxTree
-                _options,
+                ? ValueSource<TreeAndVersion>.Empty
-                _languageServices,
+                : CreateLazyFullyParsedTree(
-                this.solutionServices,
+                    newTextSource,
-                mode);
+                    this.Id.ProjectId,
+                    GetSyntaxTreeFilePath(this.info),
+                    _options,
+                    _languageServices,
+                    this.solutionServices,
+                    mode);
            return new DocumentState(
                this.LanguageServices,