Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
21ab374c
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
21ab374c
编写于
4月 13, 2017
作者:
C
CyrusNajmabadi
提交者:
GitHub
4月 13, 2017
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #18663 from CyrusNajmabadi/wrongArityClassification
Classify type names, even when arity does not match.
上级
61f5b420
3038f3c5
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
69 addition
and
4 deletion
+69
-4
src/EditorFeatures/CSharpTest/Classification/SemanticClassifierTests.cs
...ures/CSharpTest/Classification/SemanticClassifierTests.cs
+1
-1
src/EditorFeatures/CSharpTest/Classification/TotalClassifierTests.cs
...eatures/CSharpTest/Classification/TotalClassifierTests.cs
+56
-3
src/Workspaces/CSharp/Portable/Classification/Classifiers/NameSyntaxClassifier.cs
...rtable/Classification/Classifiers/NameSyntaxClassifier.cs
+12
-0
未找到文件。
src/EditorFeatures/CSharpTest/Classification/SemanticClassifierTests.cs
浏览文件 @
21ab374c
...
...
@@ -279,7 +279,7 @@ public async Task GenericClassNameButOtherArity()
class C
{
A d;
}"
);
}"
,
Class
(
"A"
)
);
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
Classification
)]
...
...
src/EditorFeatures/CSharpTest/Classification/TotalClassifierTests.cs
浏览文件 @
21ab374c
...
...
@@ -788,9 +788,62 @@ public MyClass(int x)
Punctuation
.
CloseParen
,
Punctuation
.
OpenCurly
,
Punctuation
.
CloseCurly
,
Punctuation
.
CloseCurly
Punctuation
.
CloseCurly
);
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
Classification
)]
public
async
Task
TestGenericTypeWithNoArity
()
{
await
TestAsync
(
@"
using System.Collections.Generic;
class Program : IReadOnlyCollection
{
}"
,
Keyword
(
"using"
),
Identifier
(
"System"
),
Operators
.
Dot
,
Identifier
(
"Collections"
),
Operators
.
Dot
,
Identifier
(
"Generic"
),
Punctuation
.
Semicolon
,
Keyword
(
"class"
),
Class
(
"Program"
),
Punctuation
.
Colon
,
Interface
(
"IReadOnlyCollection"
),
Punctuation
.
OpenCurly
,
Punctuation
.
CloseCurly
);
}
);
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
Classification
)]
public
async
Task
TestGenericTypeWithWrongArity
()
{
await
TestAsync
(
@"
using System.Collections.Generic;
class Program : IReadOnlyCollection<int,string>
{
}"
,
Keyword
(
"using"
),
Identifier
(
"System"
),
Operators
.
Dot
,
Identifier
(
"Collections"
),
Operators
.
Dot
,
Identifier
(
"Generic"
),
Punctuation
.
Semicolon
,
Keyword
(
"class"
),
Class
(
"Program"
),
Punctuation
.
Colon
,
Identifier
(
"IReadOnlyCollection"
),
Punctuation
.
OpenAngle
,
Keyword
(
"int"
),
Punctuation
.
Comma
,
Keyword
(
"string"
),
Punctuation
.
CloseAngle
,
Punctuation
.
OpenCurly
,
Punctuation
.
CloseCurly
);
}
}
}
}
\ No newline at end of file
src/Workspaces/CSharp/Portable/Classification/Classifiers/NameSyntaxClassifier.cs
浏览文件 @
21ab374c
...
...
@@ -221,6 +221,18 @@ private static ISymbol TryGetSymbol(NameSyntax name, SymbolInfo symbolInfo, Sema
return
firstSymbol
;
}
break
;
case
CandidateReason
.
WrongArity
:
if
(
name
.
GetRightmostName
().
Arity
==
0
)
{
// When the user writes something like "IList" we don't want to *not* classify
// just because the type bound to "IList<T>". This is also important for use
// cases like "Add-using" where it can be confusing when the using is added for
// "using System.Collection.Generic" but then the type name still does not classify.
return
firstSymbol
;
}
break
;
}
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录