提交 1f3cdd5e 编写于 作者: Š Šimon Koníček

Addressing feedback from Cyrus

上级 4e101c7b
......@@ -44,7 +44,7 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
var semanticModel = await context.Document.GetSemanticModelAsync(context.CancellationToken).ConfigureAwait(false);
var (newExpression, displayText) = GetReplacementExpressionAndText(
context.Document, defaultLiteral, semanticModel, context.CancellationToken);
context.Document, semanticModel, defaultLiteral, context.CancellationToken);
if (newExpression != null)
{
......@@ -71,8 +71,8 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
private static (SyntaxNode newExpression, string displayText) GetReplacementExpressionAndText(
Document document,
LiteralExpressionSyntax defaultLiteral,
SemanticModel semanticModel,
LiteralExpressionSyntax defaultLiteral,
CancellationToken cancellationToken)
{
var generator = SyntaxGenerator.GetGenerator(document);
......@@ -85,7 +85,7 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
{
return GenerateMemberAccess("None");
}
else if (type.Equals(semanticModel.Compilation.GetTypeByMetadataName("System.Threading.CancellationToken")))
else if (type.Equals(semanticModel.Compilation.GetTypeByMetadataName(typeof(CancellationToken).FullName)))
{
return GenerateMemberAccess(nameof(CancellationToken.None));
}
......@@ -116,7 +116,7 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
private static bool IsFlagsEnum(ITypeSymbol type, Compilation compilation)
{
var flagsAttribute = compilation.GetTypeByMetadataName("System.FlagsAttribute");
var flagsAttribute = compilation.GetTypeByMetadataName(typeof(FlagsAttribute).FullName);
return type.TypeKind == TypeKind.Enum &&
type.GetAttributes().Any(attribute => attribute.AttributeClass.Equals(flagsAttribute));
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册