Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
1d0b818c
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
1d0b818c
编写于
9月 01, 2015
作者:
C
CyrusNajmabadi
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #4847 from CyrusNajmabadi/cleanupComment
Simplify expression.
上级
6b21ca64
ede31340
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
3 addition
and
21 deletion
+3
-21
src/Workspaces/CSharp/Portable/LanguageServices/CSharpTypeInferenceService.TypeInferrer.cs
...nguageServices/CSharpTypeInferenceService.TypeInferrer.cs
+3
-21
未找到文件。
src/Workspaces/CSharp/Portable/LanguageServices/CSharpTypeInferenceService.TypeInferrer.cs
浏览文件 @
1d0b818c
...
...
@@ -30,31 +30,13 @@ protected override bool IsUnusableType(ITypeSymbol otherSideType)
protected
override
IEnumerable
<
ITypeSymbol
>
GetTypes_DoNotCallDirectly
(
ExpressionSyntax
expression
,
bool
objectAsDefault
)
{
IEnumerable
<
ITypeSymbol
>
types
;
// BUG: (vladres) Are following expressions parenthesized correctly?
// BUG:
// BUG: (davip) It is parenthesized incorrectly. This problem was introduced in Changeset 822325 when
// BUG: this method was changed from returning a single ITypeSymbol to returning an IEnumerable<ITypeSymbol>
// BUG: to better deal with overloads. The old version was:
// BUG:
// BUG: if (!IsUnusableType(type = GetTypeSimple(expression)) ||
// BUG: !IsUnusableType(type = GetTypeComplex(expression)))
// BUG: { return type; }
// BUG:
// BUG: The intent is to only use *usable* types, whether simple or complex. I have confirmed this intent with Ravi, who made the change.
// BUG:
// BUG: Note that the current implementation of GetTypesComplex and GetTypesSimple already ensure the returned value
// BUG: is a usable type, so there should not (currently) be any observable effect of this logic error.
// BUG:
// BUG: (vladres) Please remove this comment once the bug is fixed.
if
((
types
=
GetTypesSimple
(
expression
).
Where
(
IsUsableTypeFunc
)).
Any
()
||
(
types
=
GetTypesComplex
(
expression
)).
Where
(
IsUsableTypeFunc
).
Any
())
var
types
=
GetTypesSimple
(
expression
).
Where
(
IsUsableTypeFunc
);
if
(
types
.
Any
())
{
return
types
;
}
return
SpecializedCollections
.
EmptyEnumerable
<
ITypeSymbol
>(
);
return
GetTypesComplex
(
expression
).
Where
(
IsUsableTypeFunc
);
}
private
static
bool
DecomposeBinaryOrAssignmentExpression
(
ExpressionSyntax
expression
,
out
SyntaxToken
operatorToken
,
out
ExpressionSyntax
left
,
out
ExpressionSyntax
right
)
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录