Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
1b836615
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
1b836615
编写于
8月 20, 2019
作者:
J
Jason Malinowski
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Update Generate Equals and GetHashCode to handle nullable members
Fixes
https://github.com/dotnet/roslyn/issues/37913
上级
58f20239
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
42 addition
and
3 deletion
+42
-3
src/EditorFeatures/CSharpTest/GenerateFromMembers/GenerateEqualsAndGetHashCodeFromMembers/GenerateEqualsAndGetHashCodeFromMembersTests.cs
...omMembers/GenerateEqualsAndGetHashCodeFromMembersTests.cs
+39
-0
src/Workspaces/Core/Portable/Shared/Extensions/SyntaxGeneratorExtensions_CreateEqualsMethod.cs
...xtensions/SyntaxGeneratorExtensions_CreateEqualsMethod.cs
+3
-3
未找到文件。
src/EditorFeatures/CSharpTest/GenerateFromMembers/GenerateEqualsAndGetHashCodeFromMembers/GenerateEqualsAndGetHashCodeFromMembersTests.cs
浏览文件 @
1b836615
...
...
@@ -88,6 +88,45 @@ public override bool Equals(object obj)
parameters
:
CSharp6
);
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsGenerateEqualsAndGetHashCode
)]
public
async
Task
TestNullableReferenceIEquatable
()
{
await
TestInRegularAndScript1Async
(
@"#nullable enable
using System;
using System.Collections.Generic;
class S : IEquatable<S> { }
class Program
{
[|S? a;|]
}"
,
@"#nullable enable
using System;
using System.Collections.Generic;
class S : IEquatable<S> { }
class Program
{
S? a;
public override bool Equals(object? obj)
{
return obj is Program program &&
EqualityComparer<S?>.Default.Equals(a, program.a);
}
public override int GetHashCode()
{
return -1757793268 + EqualityComparer<S?>.Default.GetHashCode(a);
}
}"
,
index
:
1
);
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsGenerateEqualsAndGetHashCode
)]
public
async
Task
TestValueIEquatable
()
{
...
...
src/Workspaces/Core/Portable/Shared/Extensions/SyntaxGeneratorExtensions_CreateEqualsMethod.cs
浏览文件 @
1b836615
...
...
@@ -365,7 +365,7 @@ private static bool IsPrimitiveValueType(ITypeSymbol typeSymbol)
ITypeSymbol
type
)
{
var
equalityComparerType
=
compilation
.
EqualityComparerOfTType
();
var
constructedType
=
equalityComparerType
.
Construct
(
type
);
var
constructedType
=
equalityComparerType
.
Construct
WithNullability
(
type
);
return
factory
.
MemberAccessExpression
(
factory
.
TypeExpression
(
constructedType
),
factory
.
IdentifierName
(
DefaultName
));
...
...
@@ -375,8 +375,8 @@ private static ITypeSymbol GetType(Compilation compilation, ISymbol symbol)
{
switch
(
symbol
)
{
case
IFieldSymbol
field
:
return
field
.
Type
;
case
IPropertySymbol
property
:
return
property
.
Type
;
case
IFieldSymbol
field
:
return
field
.
GetTypeWithAnnotatedNullability
()
;
case
IPropertySymbol
property
:
return
property
.
GetTypeWithAnnotatedNullability
()
;
default
:
return
compilation
.
GetSpecialType
(
SpecialType
.
System_Object
);
}
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录