Address CR feedback. (changeset 1332543)

Src/Compilers/Core/Desktop/AnalyzerFileReference.cs

@@ -8,9 +8,8 @@
 using System.Reflection;
 using System.Reflection.Metadata;
 using System.Security;
-using Roslyn.Utilities;
-using System.Collections.Concurrent;
 using System.Threading;
+using Roslyn.Utilities;
 
 namespace Microsoft.CodeAnalysis.Diagnostics
 {
@@ -32,7 +31,7 @@ public sealed partial class AnalyzerFileReference : AnalyzerReference
         private string lazyDisplayName;
         private ImmutableArray<IDiagnosticAnalyzer> lazyAllAnalyzers;
         private ImmutableArray<IDiagnosticAnalyzer> lazyLanguageAgnosticAnalyzers;
-        private ConcurrentDictionary<string, ImmutableArray<IDiagnosticAnalyzer>> lazyAnalyzersPerLanguage;
+        private ImmutableDictionary<string, ImmutableArray<IDiagnosticAnalyzer>> lazyAnalyzersPerLanguage;
         private Assembly lazyAssembly;
 
         private ImmutableDictionary<string, HashSet<string>> lazyAnalyzerTypeNameMap;
@@ -79,7 +78,7 @@ public AnalyzerFileReference(string fullPath, Func<string, Assembly> getAssembly
 
             this.lazyAllAnalyzers = default(ImmutableArray<IDiagnosticAnalyzer>);
             this.lazyLanguageAgnosticAnalyzers = default(ImmutableArray<IDiagnosticAnalyzer>);
-            this.lazyAnalyzersPerLanguage = null;
+            this.lazyAnalyzersPerLanguage = ImmutableDictionary<string, ImmutableArray<IDiagnosticAnalyzer>>.Empty;
             this.getAssembly = getAssembly;
         }
 
@@ -88,7 +87,7 @@ public override ImmutableArray<IDiagnosticAnalyzer> GetAnalyzersForAllLanguages(
             if (lazyAllAnalyzers.IsDefault)
             {
                 var allAnalyzers = MetadataCache.GetOrCreateAnalyzersFromFile(this);
-                ImmutableInterlocked.InterlockedCompareExchange(ref this.lazyAllAnalyzers, allAnalyzers, default(ImmutableArray<IDiagnosticAnalyzer>));
+                ImmutableInterlocked.InterlockedInitialize(ref this.lazyAllAnalyzers, allAnalyzers);
             }
 
             return lazyAllAnalyzers;
@@ -101,23 +100,12 @@ public override ImmutableArray<IDiagnosticAnalyzer> GetAnalyzers(string language
                 throw new ArgumentException("language");
             }
 
-            ImmutableArray<IDiagnosticAnalyzer> analyzers;
-            if (this.lazyAnalyzersPerLanguage == null)
-            {
-                Interlocked.CompareExchange(ref this.lazyAnalyzersPerLanguage, new ConcurrentDictionary<string, ImmutableArray<IDiagnosticAnalyzer>>(), null);
-            }
-            else if (this.lazyAnalyzersPerLanguage.TryGetValue(language, out analyzers))
-            {
-                return analyzers;
-            }
-
-            analyzers = MetadataCache.GetOrCreateAnalyzersFromFile(this, language);
-            if (!this.lazyAnalyzersPerLanguage.TryAdd(language, analyzers))
-            {
-                return this.lazyAnalyzersPerLanguage[language];
-            }
+            return ImmutableInterlocked.GetOrAdd(ref this.lazyAnalyzersPerLanguage, language, CreateLanguageSpecificAnalyzers, this);
+        }
 
-            return analyzers;
+        private static ImmutableArray<IDiagnosticAnalyzer> CreateLanguageSpecificAnalyzers(string language, AnalyzerFileReference @this)
+        {
+            return MetadataCache.GetOrCreateAnalyzersFromFile(@this, language);
         }
 
         public override string FullPath
@@ -173,7 +161,7 @@ private ImmutableArray<IDiagnosticAnalyzer> GetLanguageAgnosticAnalyzers(Immutab
                     analyzers = GetAnalyzersForTypeNames(analyzerAssembly, analyzerTypeNames).ToImmutableArrayOrEmpty();
                 }
 
-                ImmutableInterlocked.InterlockedCompareExchange(ref this.lazyLanguageAgnosticAnalyzers, analyzers, default(ImmutableArray<IDiagnosticAnalyzer>));
+                ImmutableInterlocked.InterlockedInitialize(ref this.lazyLanguageAgnosticAnalyzers, analyzers);
             }
 
             return this.lazyLanguageAgnosticAnalyzers;
@@ -299,7 +287,7 @@ private IEnumerable<IDiagnosticAnalyzer> GetAnalyzersForTypeNames(Assembly analy
         /// </summary>
         private static ImmutableDictionary<string, HashSet<string>> GetAnalyzerTypeNameMap(string fullPath)
         {
-            var typeNameMap = new Dictionary<string, HashSet<string>>();
+            var typeNameMap = ImmutableDictionary.CreateBuilder<string, HashSet<string>>();
             var diagnosticNamespaceName = string.Format("{0}.{1}.{2}", nameof(Microsoft), nameof(CodeAnalysis), nameof(Diagnostics));
             var supportedLanguageNames = new HashSet<string>();
 
@@ -367,7 +355,7 @@ private IEnumerable<IDiagnosticAnalyzer> GetAnalyzersForTypeNames(Assembly analy
                 }
             }
 
-            return typeNameMap.ToImmutableDictionary();
+            return typeNameMap.ToImmutable();
         }
 
         private static string GetFullyQualifiedTypeName(TypeDefinition typeDef, PEModule peModule)

Src/Compilers/Core/Desktop/MetadataCache.cs

@@ -122,7 +122,7 @@ internal struct CachedAnalyzers
             public readonly WeakReference Analyzers;
             public readonly string Language;
 
-            public CachedAnalyzers(ImmutableArray<IDiagnosticAnalyzer> analyzers, string language)
+            public CachedAnalyzers(object analyzers, string language)
             {
                 Debug.Assert(analyzers != null);
 

Src/Compilers/Core/Portable/DiagnosticAnalyzer/AnalyzerReference.cs

@@ -44,12 +44,12 @@ public virtual bool IsUnresolved
         /// In most instances, either the analyzer reference is associated with a project or is being queried for analyzers in a particular language context.
         /// If so, use <see cref="GetAnalyzers(string)"/> method.
         /// </summary>
-        /// <returns></returns>
         public abstract ImmutableArray<IDiagnosticAnalyzer> GetAnalyzersForAllLanguages();
 
         /// <summary>
         /// Gets all the diagnostic analyzers defined in this assembly reference for the given <paramref name="language"/>.
         /// </summary>
+        /// <param name="language">Language name.</param>
         public abstract ImmutableArray<IDiagnosticAnalyzer> GetAnalyzers(string language);
     }
 }
\ No newline at end of file

Src/Workspaces/CoreTest/SolutionTests/SolutionTests.cs

@@ -369,7 +369,7 @@ public void TestProjectDiagnosticAnalyzers()
             var actualAnalyzerReferences = newSolution.Projects.Single().AnalyzerReferences;
             Assert.Equal(1, actualAnalyzerReferences.Count);
             Assert.Equal(analyzerReference, actualAnalyzerReferences[0]);
-            var actualAnalyzers = actualAnalyzerReferences[0].GetAnalyzersForAllLanguages().ToImmutableArray();
+            var actualAnalyzers = actualAnalyzerReferences[0].GetAnalyzersForAllLanguages();
             Assert.Equal(1, actualAnalyzers.Length);
             Assert.Equal(analyzer, actualAnalyzers[0]);