Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
10899a37
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
10899a37
编写于
5月 31, 2017
作者:
S
Sam Harwell
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Avoid re-verifying semantics of nodes that cannot influence each other
上级
05480ee4
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
21 addition
and
1 deletion
+21
-1
src/Features/CSharp/Portable/UseDefaultLiteral/CSharpUseDefaultLiteralCodeFixProvider.cs
...eDefaultLiteral/CSharpUseDefaultLiteralCodeFixProvider.cs
+21
-1
未找到文件。
src/Features/CSharp/Portable/UseDefaultLiteral/CSharpUseDefaultLiteralCodeFixProvider.cs
浏览文件 @
10899a37
...
...
@@ -51,6 +51,12 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
var
originalNodes
=
diagnostics
.
SelectAsArray
(
d
=>
(
DefaultExpressionSyntax
)
originalRoot
.
FindNode
(
d
.
Location
.
SourceSpan
,
getInnermostNodeForTie
:
true
));
// This code fix will not make changes that affect the semantics of a statement or declaration. Therefore,
// we can skip the expensive verification step in cases where only one default expression appears within the
// group.
var
nodesBySemanticBoundary
=
originalNodes
.
GroupBy
(
node
=>
GetSemanticBoundary
(
node
));
var
nodesToVerify
=
nodesBySemanticBoundary
.
Where
(
group
=>
group
.
Skip
(
1
).
Any
()).
Flatten
().
ToSet
();
// We're going to be continually editing this tree. Track all the nodes we
// care about so we can find them across each edit.
document
=
document
.
WithSyntaxRoot
(
originalRoot
.
TrackNodes
(
originalNodes
));
...
...
@@ -60,8 +66,9 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
foreach
(
var
originalDefaultExpression
in
originalNodes
)
{
var
defaultExpression
=
currentRoot
.
GetCurrentNode
(
originalDefaultExpression
);
var
skipVerification
=
!
nodesToVerify
.
Contains
(
originalDefaultExpression
);
if
(
defaultExpression
.
CanReplaceWithDefaultLiteral
(
parseOptions
,
options
,
semanticModel
,
cancellationToken
))
if
(
skipVerification
||
defaultExpression
.
CanReplaceWithDefaultLiteral
(
parseOptions
,
options
,
semanticModel
,
cancellationToken
))
{
var
replacement
=
SyntaxFactory
.
LiteralExpression
(
SyntaxKind
.
DefaultLiteralExpression
)
.
WithTriviaFrom
(
defaultExpression
);
...
...
@@ -76,6 +83,19 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
editor
.
ReplaceNode
(
originalRoot
,
currentRoot
);
}
private
static
SyntaxNode
GetSemanticBoundary
(
DefaultExpressionSyntax
node
)
{
// Notes:
// 1. Syntax which doesn't fall into one of the "safe buckets" will get placed into a single group keyed off
// the root of the tree. If more than one such node exists in the document, all will be verified.
// 2. Cannot include ArgumentSyntax because it could affect generic argument inference.
return
node
.
FirstAncestorOrSelf
<
SyntaxNode
>(
n
=>
n
is
StatementSyntax
||
n
is
ParameterSyntax
||
n
is
VariableDeclaratorSyntax
||
n
.
Parent
==
null
);
}
private
class
MyCodeAction
:
CodeAction
.
DocumentChangeAction
{
public
MyCodeAction
(
Func
<
CancellationToken
,
Task
<
Document
>>
createChangedDocument
)
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录