Simplify code.

src/EditorFeatures/Core/Implementation/Diagnostics/AbstractDiagnosticsTaggerProvider.AggregatingTagger.cs

@@ -159,16 +159,23 @@ public void Dispose()
 
                     // Disconnect us from our underlying taggers and make sure they're
                     // released as well.
-                    foreach (var kvp in _idToProviderAndTagger)
-                    {
-                        var tagger = kvp.Value.Item2;
+                    DisconnectFromAllTaggers();
+                    _owner.RemoveTagger(this, _subjectBuffer);
+                }
+            }
 
-                        DisconnectFromTagger(tagger);
-                    }
+            private void DisconnectFromAllTaggers()
+            {
+                this.AssertIsForeground();
 
-                    _idToProviderAndTagger.Clear();
-                    _owner.RemoveTagger(this, _subjectBuffer);
+                foreach (var kvp in _idToProviderAndTagger)
+                {
+                    var tagger = kvp.Value.Item2;
+
+                    DisconnectFromTagger(tagger);
                 }
+
+                _idToProviderAndTagger.Clear();
             }
 
             private void DisconnectFromTagger(IAccurateTagger<TTag> tagger)
@@ -225,6 +232,11 @@ private void OnDiagnosticsUpdatedOnForeground(DiagnosticsUpdatedArgs e)
             {
                 this.AssertIsForeground();
 
+                if (_disposed)
+                {
+                    return;
+                }
+
                 // Do some quick checks to avoid doing any further work for diagnostics  we don't
                 // care about.
                 var ourDocument = _subjectBuffer.AsTextContainer().GetOpenDocumentInCurrentContext();
@@ -325,12 +337,16 @@ private void ProcessRemovedDiagnostics(DiagnosticsUpdatedArgs e)
                 // was removed.  If so, clear out any diagnostics we have associated with this
                 // diagnostic source ID and notify any listeners that 
 
-                if (_disposed)
+                ValueTuple<TaggerProvider, IAccurateTagger<TTag>> providerAndTagger;
+                if (!_idToProviderAndTagger.TryGetValue(e.Id, out providerAndTagger))
                 {
+                    // Wasn't a diagnostic source we care about.
                     return;
                 }
 
-                RemoveCachedDiagnostics(e.Id);
+                _idToProviderAndTagger.Remove(e.Id);
+                DisconnectFromTagger(providerAndTagger.Item2);
+
                 OnUnderlyingTaggerTagsChanged(this, new SnapshotSpanEventArgs(_subjectBuffer.CurrentSnapshot.GetFullSpan()));
             }
 
@@ -338,40 +354,14 @@ private void RemoveAllCachedDiagnostics()
             {
                 this.AssertIsForeground();
 
-                // Make a copy of all the IDs so that we don't change a collection as we're
-                // iterating over it.
-                var ids = _idToProviderAndTagger.Keys.ToArray();
-                foreach (var id in ids)
-                {
-                    RemoveCachedDiagnostics(id);
-                }
-
+                DisconnectFromAllTaggers();
                 OnUnderlyingTaggerTagsChanged(this, new SnapshotSpanEventArgs(_subjectBuffer.CurrentSnapshot.GetFullSpan()));
             }
 
-            private void RemoveCachedDiagnostics(object id)
-            {
-                this.AssertIsForeground();
-
-                ValueTuple<TaggerProvider, IAccurateTagger<TTag>> providerAndTagger;
-                if (!_idToProviderAndTagger.TryGetValue(id, out providerAndTagger))
-                {
-                    // Wasn't a diagnostic source we care about.
-                    return;
-                }
-
-                _idToProviderAndTagger.Remove(id);
-                DisconnectFromTagger(providerAndTagger.Item2);
-            }
-
             private void OnDiagnosticsUpdatedOnForeground(
                 DiagnosticsUpdatedArgs e, SourceText sourceText, ITextSnapshot editorSnapshot)
             {
                 this.AssertIsForeground();
-                if (_disposed)
-                {
-                    return;
-                }
 
                 // Find the appropriate async tagger for this diagnostics id, and let it know that
                 // there were new diagnostics produced for it.
@@ -413,6 +403,7 @@ private void OnUnderlyingTaggerTagsChanged(object sender, SnapshotSpanEventArgs
                 {
                     return;
                 }
+
                 this.TagsChanged?.Invoke(sender, args);
             }