Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
07033d72
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
07033d72
编写于
9月 22, 2020
作者:
C
CyrusNajmabadi
提交者:
GitHub
9月 22, 2020
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #47945 from CyrusNajmabadi/removeAssert
Remove bogus assert
上级
f6756f90
8e1ec594
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
11 addition
and
10 deletion
+11
-10
src/VisualStudio/Core/Def/Implementation/SemanticClassificationCache/SemanticClassificationCacheIncrementalAnalyzerProvider.cs
...SemanticClassificationCacheIncrementalAnalyzerProvider.cs
+6
-2
src/Workspaces/Core/Portable/Classification/IRemoteSemanticClassificationCacheService.cs
...assification/IRemoteSemanticClassificationCacheService.cs
+1
-1
src/Workspaces/Remote/ServiceHub/Services/SemanticClassificationCache/RemoteSemanticClassificationCacheService.cs
...ficationCache/RemoteSemanticClassificationCacheService.cs
+4
-7
未找到文件。
src/VisualStudio/Core/Def/Implementation/SemanticClassificationCache/SemanticClassificationCacheIncrementalAnalyzerProvider.cs
浏览文件 @
07033d72
...
...
@@ -61,12 +61,16 @@ public override async Task AnalyzeDocumentAsync(Document document, SyntaxNode bo
}
var
statusService
=
document
.
Project
.
Solution
.
Workspace
.
Services
.
GetRequiredService
<
IWorkspaceStatusService
>();
// If we're not fully loaded, then we don't want to cache classifications. The classifications we have
// will likely not be accurate. And, if we shutdown after that, we'll have cached incomplete classifications.
var
isFullyLoaded
=
await
statusService
.
IsFullyLoadedAsync
(
cancellationToken
).
ConfigureAwait
(
false
);
Debug
.
Assert
(
isFullyLoaded
,
"We should only be called by the incremental analyzer once the solution is fully loaded."
);
if
(!
isFullyLoaded
)
return
;
await
client
.
TryInvokeAsync
<
IRemoteSemanticClassificationCacheService
>(
document
.
Project
.
Solution
,
(
service
,
solutionInfo
,
cancellationToken
)
=>
service
.
CacheSemanticClassificationsAsync
(
solutionInfo
,
document
.
Id
,
isFullyLoaded
,
cancellationToken
),
(
service
,
solutionInfo
,
cancellationToken
)
=>
service
.
CacheSemanticClassificationsAsync
(
solutionInfo
,
document
.
Id
,
cancellationToken
),
callbackTarget
:
null
,
cancellationToken
).
ConfigureAwait
(
false
);
}
...
...
src/Workspaces/Core/Portable/Classification/IRemoteSemanticClassificationCacheService.cs
浏览文件 @
07033d72
...
...
@@ -19,7 +19,7 @@ namespace Microsoft.CodeAnalysis.Classification
internal
interface
IRemoteSemanticClassificationCacheService
{
ValueTask
CacheSemanticClassificationsAsync
(
PinnedSolutionInfo
solutionInfo
,
DocumentId
documentId
,
bool
isFullyLoaded
,
CancellationToken
cancellationToken
);
PinnedSolutionInfo
solutionInfo
,
DocumentId
documentId
,
CancellationToken
cancellationToken
);
/// <summary>
/// Tries to get cached semantic classifications for the specified document and the specified <paramref
...
...
src/Workspaces/Remote/ServiceHub/Services/SemanticClassificationCache/RemoteSemanticClassificationCacheService.cs
浏览文件 @
07033d72
...
...
@@ -73,17 +73,14 @@ private static async Task<Checksum> GetChecksumAsync(Document document, Cancella
public
ValueTask
CacheSemanticClassificationsAsync
(
PinnedSolutionInfo
solutionInfo
,
DocumentId
documentId
,
bool
isFullyLoaded
,
CancellationToken
cancellationToken
)
{
return
RunServiceAsync
(
async
cancellationToken
=>
{
// Once fully loaded, we can clear any of the cached information we stored during load.
if
(
isFullyLoaded
)
{
lock
(
_cachedData
)
_cachedData
.
Clear
();
}
// We only get called to cache classifications once we're fully loaded. At that point there's no need
// for us to keep around any of the data we cached in-memory during the time the solution was loading.
lock
(
_cachedData
)
_cachedData
.
Clear
();
var
solution
=
await
GetSolutionAsync
(
solutionInfo
,
cancellationToken
).
ConfigureAwait
(
false
);
var
document
=
solution
.
GetRequiredDocument
(
documentId
);
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录