Misc. data consistency measures

src/VisualStudio/Core/Def/Implementation/ChangeSignature/AddParameterDialogViewModel.cs

@@ -141,6 +141,18 @@ internal bool TrySubmit()
                 return false;
             }
 
+            if (IsCallsiteRegularValue && CallSiteValue.IsNullOrWhiteSpace())
+            {
+                SendFailureNotification(ServicesVSResources.Enter_a_call_site_value_or_choose_a_different_value_injection_kind);
+                return false;
+            }
+
+            if (IsOptional && DefaultValue.IsNullOrWhiteSpace())
+            {
+                SendFailureNotification(ServicesVSResources.Optional_parameters_must_provide_a_default_value);
+                return false;
+            }
+
             return true;
         }
 

src/VisualStudio/Core/Def/Implementation/ChangeSignature/ChangeSignatureDialog.xaml.cs

@@ -139,9 +139,9 @@ private void Add_Click(object sender, RoutedEventArgs e)
                     addParameterViewModel.TypeSymbol,
                     addParameterViewModel.TypeName,
                     addParameterViewModel.ParameterName,
-                    addParameterViewModel.CallSiteValue,
+                    (addParameterViewModel.IsCallsiteOmitted || addParameterViewModel.IsCallsiteTodo) ? "" : addParameterViewModel.CallSiteValue,
                     addParameterViewModel.IsRequired,
-                    addParameterViewModel.DefaultValue,
+                    addParameterViewModel.IsRequired ? "" : addParameterViewModel.DefaultValue,
                     addParameterViewModel.UseNamedArguments,
                     addParameterViewModel.IsCallsiteOmitted,
                     addParameterViewModel.IsCallsiteTodo,

src/VisualStudio/Core/Def/ServicesVSResources.resx

@@ -1469,4 +1469,10 @@ I agree to all of the foregoing:</value>
     <value>Please enter a type name</value>
     <comment>"Type" is the programming language concept</comment>
   </data>
+  <data name="Enter_a_call_site_value_or_choose_a_different_value_injection_kind" xml:space="preserve">
+    <value>Enter a call site value or choose a different value injection kind</value>
+  </data>
+  <data name="Optional_parameters_must_provide_a_default_value" xml:space="preserve">
+    <value>Optional parameters must provide a default value</value>
+  </data>
 </root>
\ No newline at end of file

src/VisualStudio/Core/Def/xlf/ServicesVSResources.cs.xlf

@@ -167,6 +167,11 @@
         <target state="translated">Element není platný.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Enter_a_call_site_value_or_choose_a_different_value_injection_kind">
+        <source>Enter a call site value or choose a different value injection kind</source>
+        <target state="new">Enter a call site value or choose a different value injection kind</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Entire_solution">
         <source>Entire solution</source>
         <target state="translated">Celé řešení</target>
@@ -442,6 +447,11 @@
         <target state="translated">Otevřené dokumenty</target>
         <note />
       </trans-unit>
+      <trans-unit id="Optional_parameters_must_provide_a_default_value">
+        <source>Optional parameters must provide a default value</source>
+        <target state="new">Optional parameters must provide a default value</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Optional_with_default_value_colon">
         <source>Optional with default value:</source>
         <target state="new">Optional with default value:</target>

src/VisualStudio/Core/Def/xlf/ServicesVSResources.de.xlf

@@ -167,6 +167,11 @@
         <target state="translated">Das Element ist ungültig.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Enter_a_call_site_value_or_choose_a_different_value_injection_kind">
+        <source>Enter a call site value or choose a different value injection kind</source>
+        <target state="new">Enter a call site value or choose a different value injection kind</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Entire_solution">
         <source>Entire solution</source>
         <target state="translated">Gesamte Projektmappe</target>
@@ -442,6 +447,11 @@
         <target state="translated">Geöffnete Dokumente</target>
         <note />
       </trans-unit>
+      <trans-unit id="Optional_parameters_must_provide_a_default_value">
+        <source>Optional parameters must provide a default value</source>
+        <target state="new">Optional parameters must provide a default value</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Optional_with_default_value_colon">
         <source>Optional with default value:</source>
         <target state="new">Optional with default value:</target>

src/VisualStudio/Core/Def/xlf/ServicesVSResources.es.xlf

@@ -167,6 +167,11 @@
         <target state="translated">El elemento no es válido.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Enter_a_call_site_value_or_choose_a_different_value_injection_kind">
+        <source>Enter a call site value or choose a different value injection kind</source>
+        <target state="new">Enter a call site value or choose a different value injection kind</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Entire_solution">
         <source>Entire solution</source>
         <target state="translated">Toda la solución</target>
@@ -442,6 +447,11 @@
         <target state="translated">Abrir documentos</target>
         <note />
       </trans-unit>
+      <trans-unit id="Optional_parameters_must_provide_a_default_value">
+        <source>Optional parameters must provide a default value</source>
+        <target state="new">Optional parameters must provide a default value</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Optional_with_default_value_colon">
         <source>Optional with default value:</source>
         <target state="new">Optional with default value:</target>

src/VisualStudio/Core/Def/xlf/ServicesVSResources.fr.xlf

@@ -167,6 +167,11 @@
         <target state="translated">L'élément n'est pas valide.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Enter_a_call_site_value_or_choose_a_different_value_injection_kind">
+        <source>Enter a call site value or choose a different value injection kind</source>
+        <target state="new">Enter a call site value or choose a different value injection kind</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Entire_solution">
         <source>Entire solution</source>
         <target state="translated">Solution complète</target>
@@ -442,6 +447,11 @@
         <target state="translated">Documents ouverts</target>
         <note />
       </trans-unit>
+      <trans-unit id="Optional_parameters_must_provide_a_default_value">
+        <source>Optional parameters must provide a default value</source>
+        <target state="new">Optional parameters must provide a default value</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Optional_with_default_value_colon">
         <source>Optional with default value:</source>
         <target state="new">Optional with default value:</target>

src/VisualStudio/Core/Def/xlf/ServicesVSResources.it.xlf

@@ -167,6 +167,11 @@
         <target state="translated">L'elemento non è valido.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Enter_a_call_site_value_or_choose_a_different_value_injection_kind">
+        <source>Enter a call site value or choose a different value injection kind</source>
+        <target state="new">Enter a call site value or choose a different value injection kind</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Entire_solution">
         <source>Entire solution</source>
         <target state="translated">Intera soluzione</target>
@@ -442,6 +447,11 @@
         <target state="translated">Apri documenti</target>
         <note />
       </trans-unit>
+      <trans-unit id="Optional_parameters_must_provide_a_default_value">
+        <source>Optional parameters must provide a default value</source>
+        <target state="new">Optional parameters must provide a default value</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Optional_with_default_value_colon">
         <source>Optional with default value:</source>
         <target state="new">Optional with default value:</target>

src/VisualStudio/Core/Def/xlf/ServicesVSResources.ja.xlf

@@ -167,6 +167,11 @@
         <target state="translated">要素が有効ではありません。</target>
         <note />
       </trans-unit>
+      <trans-unit id="Enter_a_call_site_value_or_choose_a_different_value_injection_kind">
+        <source>Enter a call site value or choose a different value injection kind</source>
+        <target state="new">Enter a call site value or choose a different value injection kind</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Entire_solution">
         <source>Entire solution</source>
         <target state="translated">ソリューション全体</target>
@@ -442,6 +447,11 @@
         <target state="translated">開かれているドキュメント</target>
         <note />
       </trans-unit>
+      <trans-unit id="Optional_parameters_must_provide_a_default_value">
+        <source>Optional parameters must provide a default value</source>
+        <target state="new">Optional parameters must provide a default value</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Optional_with_default_value_colon">
         <source>Optional with default value:</source>
         <target state="new">Optional with default value:</target>

src/VisualStudio/Core/Def/xlf/ServicesVSResources.ko.xlf

@@ -167,6 +167,11 @@
         <target state="translated">요소가 잘못되었습니다.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Enter_a_call_site_value_or_choose_a_different_value_injection_kind">
+        <source>Enter a call site value or choose a different value injection kind</source>
+        <target state="new">Enter a call site value or choose a different value injection kind</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Entire_solution">
         <source>Entire solution</source>
         <target state="translated">전체 솔루션</target>
@@ -442,6 +447,11 @@
         <target state="translated">문서 열기</target>
         <note />
       </trans-unit>
+      <trans-unit id="Optional_parameters_must_provide_a_default_value">
+        <source>Optional parameters must provide a default value</source>
+        <target state="new">Optional parameters must provide a default value</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Optional_with_default_value_colon">
         <source>Optional with default value:</source>
         <target state="new">Optional with default value:</target>

src/VisualStudio/Core/Def/xlf/ServicesVSResources.pl.xlf

@@ -167,6 +167,11 @@
         <target state="translated">Element jest nieprawidłowy.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Enter_a_call_site_value_or_choose_a_different_value_injection_kind">
+        <source>Enter a call site value or choose a different value injection kind</source>
+        <target state="new">Enter a call site value or choose a different value injection kind</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Entire_solution">
         <source>Entire solution</source>
         <target state="translated">Całe rozwiązanie</target>
@@ -442,6 +447,11 @@
         <target state="translated">Otwórz dokumenty</target>
         <note />
       </trans-unit>
+      <trans-unit id="Optional_parameters_must_provide_a_default_value">
+        <source>Optional parameters must provide a default value</source>
+        <target state="new">Optional parameters must provide a default value</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Optional_with_default_value_colon">
         <source>Optional with default value:</source>
         <target state="new">Optional with default value:</target>

src/VisualStudio/Core/Def/xlf/ServicesVSResources.pt-BR.xlf

@@ -167,6 +167,11 @@
         <target state="translated">O elemento é inválido.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Enter_a_call_site_value_or_choose_a_different_value_injection_kind">
+        <source>Enter a call site value or choose a different value injection kind</source>
+        <target state="new">Enter a call site value or choose a different value injection kind</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Entire_solution">
         <source>Entire solution</source>
         <target state="translated">Solução Inteira</target>
@@ -442,6 +447,11 @@
         <target state="translated">Abrir documentos</target>
         <note />
       </trans-unit>
+      <trans-unit id="Optional_parameters_must_provide_a_default_value">
+        <source>Optional parameters must provide a default value</source>
+        <target state="new">Optional parameters must provide a default value</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Optional_with_default_value_colon">
         <source>Optional with default value:</source>
         <target state="new">Optional with default value:</target>

src/VisualStudio/Core/Def/xlf/ServicesVSResources.ru.xlf

@@ -167,6 +167,11 @@
         <target state="translated">Элемент недопустим.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Enter_a_call_site_value_or_choose_a_different_value_injection_kind">
+        <source>Enter a call site value or choose a different value injection kind</source>
+        <target state="new">Enter a call site value or choose a different value injection kind</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Entire_solution">
         <source>Entire solution</source>
         <target state="translated">Все решение</target>
@@ -442,6 +447,11 @@
         <target state="translated">Открыть документы</target>
         <note />
       </trans-unit>
+      <trans-unit id="Optional_parameters_must_provide_a_default_value">
+        <source>Optional parameters must provide a default value</source>
+        <target state="new">Optional parameters must provide a default value</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Optional_with_default_value_colon">
         <source>Optional with default value:</source>
         <target state="new">Optional with default value:</target>

src/VisualStudio/Core/Def/xlf/ServicesVSResources.tr.xlf

@@ -167,6 +167,11 @@
         <target state="translated">Öğe geçerli değil.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Enter_a_call_site_value_or_choose_a_different_value_injection_kind">
+        <source>Enter a call site value or choose a different value injection kind</source>
+        <target state="new">Enter a call site value or choose a different value injection kind</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Entire_solution">
         <source>Entire solution</source>
         <target state="translated">Tüm çözüm</target>
@@ -442,6 +447,11 @@
         <target state="translated">Açık belgeler</target>
         <note />
       </trans-unit>
+      <trans-unit id="Optional_parameters_must_provide_a_default_value">
+        <source>Optional parameters must provide a default value</source>
+        <target state="new">Optional parameters must provide a default value</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Optional_with_default_value_colon">
         <source>Optional with default value:</source>
         <target state="new">Optional with default value:</target>

src/VisualStudio/Core/Def/xlf/ServicesVSResources.zh-Hans.xlf

@@ -167,6 +167,11 @@
         <target state="translated">元素无效。</target>
         <note />
       </trans-unit>
+      <trans-unit id="Enter_a_call_site_value_or_choose_a_different_value_injection_kind">
+        <source>Enter a call site value or choose a different value injection kind</source>
+        <target state="new">Enter a call site value or choose a different value injection kind</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Entire_solution">
         <source>Entire solution</source>
         <target state="translated">整个解决方案</target>
@@ -442,6 +447,11 @@
         <target state="translated">打开文档</target>
         <note />
       </trans-unit>
+      <trans-unit id="Optional_parameters_must_provide_a_default_value">
+        <source>Optional parameters must provide a default value</source>
+        <target state="new">Optional parameters must provide a default value</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Optional_with_default_value_colon">
         <source>Optional with default value:</source>
         <target state="new">Optional with default value:</target>

src/VisualStudio/Core/Def/xlf/ServicesVSResources.zh-Hant.xlf

@@ -167,6 +167,11 @@
         <target state="translated">元素無效。</target>
         <note />
       </trans-unit>
+      <trans-unit id="Enter_a_call_site_value_or_choose_a_different_value_injection_kind">
+        <source>Enter a call site value or choose a different value injection kind</source>
+        <target state="new">Enter a call site value or choose a different value injection kind</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Entire_solution">
         <source>Entire solution</source>
         <target state="translated">整個解決方案</target>
@@ -442,6 +447,11 @@
         <target state="translated">開啟文件</target>
         <note />
       </trans-unit>
+      <trans-unit id="Optional_parameters_must_provide_a_default_value">
+        <source>Optional parameters must provide a default value</source>
+        <target state="new">Optional parameters must provide a default value</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Optional_with_default_value_colon">
         <source>Optional with default value:</source>
         <target state="new">Optional with default value:</target>