Remove all Obsolete public APIs.

***NO_CI***
 (changeset 1393197)

Src/Compilers/CSharp/Portable/CSharpExtensions.cs

@@ -19,12 +19,6 @@ public static bool IsKind(this SyntaxToken token, SyntaxKind kind)
             return token.RawKind == (int)kind;
         }
 
-        [Obsolete("To be removed, use Kind() or IsKind() instead.", true), EditorBrowsable(EditorBrowsableState.Never)]
-        public static bool IsContextualKind(this SyntaxToken token, SyntaxKind kind)
-        {
-            return token.CSharpContextualKind() == kind;
-        }
-
         public static bool IsKind(this SyntaxTrivia trivia, SyntaxKind kind)
         {
             return trivia.RawKind == (int)kind;
@@ -40,41 +34,11 @@ public static bool IsKind(this SyntaxNodeOrToken nodeOrToken, SyntaxKind kind)
             return nodeOrToken.RawKind == (int)kind;
         }
 
-        [Obsolete("To be removed, use Kind() or IsKind() instead.", true), EditorBrowsable(EditorBrowsableState.Never)]
-        public static SyntaxKind CSharpKind(this SyntaxToken token)
-        {
-            return token.Kind();
-        }
-
-        [Obsolete("To be removed, use Kind() or IsKind() instead.", true), EditorBrowsable(EditorBrowsableState.Never)]
-        public static SyntaxKind CSharpContextualKind(this SyntaxToken token)
-        {
-            return (object)token.Language == (object)LanguageNames.CSharp ? (SyntaxKind)token.RawContextualKind : SyntaxKind.None;
-        }
-
         internal static SyntaxKind ContextualKind(this SyntaxToken token)
         {
             return (object)token.Language == (object)LanguageNames.CSharp ? (SyntaxKind)token.RawContextualKind : SyntaxKind.None;
         }
 
-        [Obsolete("To be removed, use Kind() or IsKind() instead.", true), EditorBrowsable(EditorBrowsableState.Never)]
-        public static SyntaxKind CSharpKind(this SyntaxTrivia trivia)
-        {
-            return trivia.Kind();
-        }
-
-        [Obsolete("To be removed, use Kind() or IsKind() instead.", true), EditorBrowsable(EditorBrowsableState.Never)]
-        public static SyntaxKind CSharpKind(this SyntaxNode node)
-        {
-            return node.Kind();
-        }
-
-        [Obsolete("To be removed, use Kind() or IsKind() instead.", true), EditorBrowsable(EditorBrowsableState.Never)]
-        public static SyntaxKind CSharpKind(this SyntaxNodeOrToken nodeOrToken)
-        {
-            return nodeOrToken.Kind();
-        }
-
         /// <summary>
         /// Returns the index of the first node of a specified kind in the node list.
         /// </summary>
@@ -1561,4 +1525,4 @@ public static IRangeVariableSymbol GetDeclaredSymbol(this SemanticModel semantic
         }
         #endregion
     }
-}
\ No newline at end of file
+}

Src/Compilers/CSharp/Portable/Syntax/CSharpSyntaxNode.cs

@@ -121,12 +121,6 @@ public SyntaxKind Kind()
             return (SyntaxKind)this.Green.RawKind;
         }
 
-        [Obsolete("To be removed, use Kind() instead."), EditorBrowsable(EditorBrowsableState.Never)]
-        public SyntaxKind CSharpKind()
-        {
-            return (SyntaxKind)this.Green.RawKind;
-        }
-
         protected override string KindText
         {
             get
@@ -935,4 +929,4 @@ protected override bool IsEquivalentToCore(SyntaxNode node, bool topLevel = fals
 
         #endregion
     }
-}
\ No newline at end of file
+}

Src/Compilers/Core/Portable/Symbols/TypeKind.cs

@@ -19,9 +19,6 @@ public enum TypeKind : byte
         /// Type is an array type.
         /// </summary>
         Array = 1,
-        [Obsolete("Use TypeKind.Array instead of TypeKind.ArrayType. The latter is going away.")]
-        [EditorBrowsable(EditorBrowsableState.Never)]
-        ArrayType = 1,
 
         /// <summary>
         /// Type is a class.
@@ -37,9 +34,6 @@ public enum TypeKind : byte
         /// Type is dynamic.
         /// </summary>
         Dynamic = 4,
-        [Obsolete("Use TypeKind.Dynamic instead of TypeKind.DynamicType. The latter is going away.")]
-        [EditorBrowsable(EditorBrowsableState.Never)]
-        DynamicType = 4,
 
         /// <summary>
         /// Type is an enumeration.
@@ -65,9 +59,6 @@ public enum TypeKind : byte
         /// Type is a pointer.
         /// </summary>
         Pointer = 9,
-        [Obsolete("Use TypeKind.Pointer instead of TypeKind.PointerType. The latter is going away.")]
-        [EditorBrowsable(EditorBrowsableState.Never)]
-        PointerType = 9,
 
         /// <summary>
         /// Type is a C# struct or VB Structure
@@ -89,4 +80,4 @@ public enum TypeKind : byte
         /// </summary>
         Submission = 12,
     }
-}
\ No newline at end of file
+}

Src/Compilers/VisualBasic/Portable/Syntax/VisualBasicSyntaxNode.vb

@@ -114,11 +114,6 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
             Return CType(Me.Green.RawKind, SyntaxKind)
         End Function
 
-        <Obsolete("To be removed, use Kind() instead.", True), EditorBrowsable(EditorBrowsableState.Never)>
-        Public Function VBKind() As SyntaxKind
-            Return CType(Me.Green.RawKind, SyntaxKind)
-        End Function
-
         Protected Overrides ReadOnly Property KindText As String
             Get
                 Return Me.Kind.ToString()
@@ -688,4 +683,4 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
         End Function
 
     End Class
-End Namespace
\ No newline at end of file
+End Namespace

Src/Compilers/VisualBasic/Portable/VisualBasicExtensions.vb

@@ -17,44 +17,6 @@ Namespace Microsoft.CodeAnalysis
     ''' </summary>
     Public Module VisualBasicExtensions
 
-        ''' <summary>
-        ''' Returns SyntaxKind for SyntaxTrivia nodes.
-        ''' </summary> 
-        <Extension, Obsolete("To be removed, use Kind() or IsKind() instead.", True), EditorBrowsable(EditorBrowsableState.Never)>
-        Public Function VBKind(trivia As SyntaxTrivia) As SyntaxKind
-            Return Kind(trivia)
-        End Function
-
-        ''' <summary>
-        ''' Returns SyntaxKind for SyntaxToken from RawKind property.
-        ''' </summary>       
-        <Extension, Obsolete("To be removed, use Kind() or IsKind() instead.", True), EditorBrowsable(EditorBrowsableState.Never)>
-        Public Function VBKind(token As SyntaxToken) As SyntaxKind
-            Return Kind(token)
-        End Function
-
-        ''' <summary>
-        ''' Returns SyntaxKind for SyntaxToken from RawContextualKind.
-        ''' </summary>
-        <Extension, Obsolete("To be removed, use Kind() or IsKind() instead.", True), EditorBrowsable(EditorBrowsableState.Never)>
-        Public Function VisualBasicContextualKind(token As SyntaxToken) As SyntaxKind
-            Return If(token.Language Is LanguageNames.VisualBasic, CType(token.RawContextualKind, SyntaxKind), SyntaxKind.None)
-        End Function
-
-        ''' <summary>
-        ''' Returns SyntaxKind for SyntaxNode from RawKind property.
-        ''' </summary>
-        <Extension, Obsolete("To be removed, use Kind() or IsKind() instead.", True), EditorBrowsable(EditorBrowsableState.Never)>
-        Public Function VBKind(node As SyntaxNode) As SyntaxKind
-            Return Kind(node)
-        End Function
-
-
-        <Extension, Obsolete("To be removed, use Kind() or IsKind() instead.", True), EditorBrowsable(EditorBrowsableState.Never)>
-        Public Function VBKind(nodeOrToken As SyntaxNodeOrToken) As SyntaxKind
-            Return Kind(nodeOrToken)
-        End Function
-
         ''' <summary>
         ''' Determines if SyntaxTrivia is a specified kind.
         ''' </summary>        
@@ -75,17 +37,6 @@ Namespace Microsoft.CodeAnalysis
             Return token.RawKind = kind
         End Function
 
-        ''' <summary>
-        ''' Determines if SyntaxToken is a specified kind.
-        ''' </summary>
-        '''<param name="token">The Source SyntaxToken.</param>
-        ''' <param name="kind">The SyntaxKind to test for.</param>
-        ''' <returns>A boolean value if token is of specified kind; otherwise false.</returns>
-        <Extension, Obsolete("To be removed, use Kind() or IsKind() instead.", True), EditorBrowsable(EditorBrowsableState.Never)>
-        Public Function IsContextualKind(token As SyntaxToken, kind As SyntaxKind) As Boolean
-            Return token.VisualBasicContextualKind = kind
-        End Function
-
         ''' <summary>
         ''' Determines if SyntaxNode is a specified kind.
         ''' </summary>