All assignments in an expression tree should be an error.  Self
assignment was being flagged as only a warning which lead to later
errors in code generation.  Changed the behavior to warn and error for
self assignment (matches native compiler behavior).

close #3826