• A
    Catch exceptions when creating a stream for signing · d6a8f32b
    Andy Gocke 提交于
    This change is meant to address crashes like the ones in bug 1140649. The
    crashes seem to happen due to exceptions thrown while getting a temporary
    output stream to write the PE file to. I have been unable to reproduce
    the conditions for the crash themselves -- they only seem to happen on
    a Japanese language Windows with a Japanese language copy of Visual Studio.
    This fix addresses their symptom by wrapping the CreateInputStream call
    during signing with a try/catch and then surfacing the exception as a
    diagnostic for signing failure.
    
    We cannot currently add any more localized resources to stabilization, so
    this fix is meant to be as targeted as possible and can only deliver
    information through existing resource strings.
    
    (cherry picked from commit 801a10a5)
    d6a8f32b
EmitTestStrongNameProvider.cs 2.4 KB