• J
    Fixup nullable annotation · 5a0b78c9
    Jared Parsons 提交于
    Had to clean up a few nullable annotations now that we are compiling
    agaist `netcoreapp3.1` and hence get the full value of the framework
    annotations.
    
    This is also problematic though because there are now two places where
    the compiler can see nullable attributes that are directly used by the
    developer. For example `NotNullWhenAttribute`. This is both defined in
    our assemblies for non-netcoreapp target frameworks and provided by the
    SDK when targeting `netcoreapp3.1`.
    
    This causes a problem for assemblies which have the following
    characteristics:
    
    1. Target `netcoreapp3.1`
    1. Reference an assembly targeting `netstandard2.0` which uses our
    nullable attributes definition
    1. Has IVT into (2) above
    
    These properties essentially define all of our unit test assemblies. In
    that environment it's not possible to use nullable attributes in code
    because the compiler can't disambiguate which definition of
    `NotNullWhenAttribute` to use. This meant I had to temporarily remove a
    few attributes until we can complete #40766.
    5a0b78c9
ValidateBootstrap.cs 4.9 KB