EncapsulateFieldTests.cs 27.0 KB
Newer Older
1
// Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.
2

3
using System;
4
using System.Collections.Generic;
5
using System.Threading.Tasks;
C
CyrusNajmabadi 已提交
6
using Microsoft.CodeAnalysis.CodeRefactorings;
7
using Microsoft.CodeAnalysis.CodeStyle;
8
using Microsoft.CodeAnalysis.CSharp.CodeStyle;
9
using Microsoft.CodeAnalysis.CSharp.Test.Utilities;
10
using Microsoft.CodeAnalysis.EncapsulateField;
11
using Microsoft.CodeAnalysis.Options;
12 13 14 15 16 17 18
using Roslyn.Test.Utilities;
using Xunit;

namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.CodeRefactorings.EncapsulateField
{
    public class EncapsulateFieldTests : AbstractCSharpCodeActionTest
    {
C
CyrusNajmabadi 已提交
19
        protected override CodeRefactoringProvider CreateCodeRefactoringProvider(Workspace workspace)
20
            => new EncapsulateFieldRefactoringProvider();
21

22 23 24
        private static readonly Dictionary<OptionKey, object> AllOptionsOff =
            new Dictionary<OptionKey, object>
            {
C
CyrusNajmabadi 已提交
25 26
                { CSharpCodeStyleOptions.PreferExpressionBodiedAccessors, CodeStyleOptions.FalseWithNoneEnforcement },
                { CSharpCodeStyleOptions.PreferExpressionBodiedProperties, CodeStyleOptions.FalseWithNoneEnforcement },
27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47
            };

        internal Task TestAllOptionsOffAsync(
            string initialMarkup, string expectedMarkup,
            ParseOptions parseOptions = null,
            CompilationOptions compilationOptions = null,
            int index = 0, bool compareTokens = true,
            IDictionary<OptionKey, object> options = null,
            bool withScriptOption = false)
        {
            options = options ?? new Dictionary<OptionKey, object>();
            foreach (var kvp in AllOptionsOff)
            {
                options.Add(kvp);
            }

            return TestAsync(initialMarkup, expectedMarkup,
                parseOptions, compilationOptions, index, compareTokens, options, 
                withScriptOption: withScriptOption);
        }

48
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
49
        public async Task PrivateFieldToPropertyIgnoringReferences()
50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86
        {
            var text = @"
class foo
{
    private int b[|a|]r;

    void baz()
    {
        var q = bar;
    }
}
";

            var expected = @"
class foo
{
    private int bar;

    public int Bar
    {
        get
        {
            return bar;
        }

        set
        {
            bar = value;
        }
    }

    void baz()
    {
        var q = bar;
    }
}
";
87
            await TestAllOptionsOffAsync(text, expected, compareTokens: false, index: 1);
88 89
        }

90
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
91
        public async Task PrivateFieldToPropertyUpdatingReferences()
92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128
        {
            var text = @"
class foo
{
    private int b[|a|]r;

    void baz()
    {
        var q = Bar;
    }
}
";

            var expected = @"
class foo
{
    private int bar;

    public int Bar
    {
        get
        {
            return bar;
        }

        set
        {
            bar = value;
        }
    }

    void baz()
    {
        var q = Bar;
    }
}
";
129
            await TestAllOptionsOffAsync(text, expected, compareTokens: false, index: 0);
130 131
        }

132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
        public async Task TestCodeStyle1()
        {
            var text = @"
class foo
{
    private int b[|a|]r;

    void baz()
    {
        var q = Bar;
    }
}
";

            var expected = @"
class foo
{
    private int bar;

    public int Bar
    {
        get
        {
            return bar;
        }

        set
        {
            bar = value;
        }
    }

    void baz()
    {
        var q = Bar;
    }
}
";
            await TestAsync(text, expected, 
                options: OptionsSet(
173 174
                    SingleOption(CSharpCodeStyleOptions.PreferExpressionBodiedProperties, true, NotificationOption.None),
                    SingleOption(CSharpCodeStyleOptions.PreferExpressionBodiedAccessors, false, NotificationOption.None)));
175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213
        }

        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
        public async Task TestCodeStyle2()
        {
            var text = @"
class foo
{
    private int b[|a|]r;

    void baz()
    {
        var q = Bar;
    }
}
";

            var expected = @"
class foo
{
    private int bar;

    public int Bar
    {
        get => bar;

        set => bar = value;
    }

    void baz()
    {
        var q = Bar;
    }
}
";
            await TestAsync(text, expected,
                options: Option(CSharpCodeStyleOptions.PreferExpressionBodiedAccessors, CodeStyleOptions.TrueWithNoneEnforcement));
        }

214
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
215
        public async Task PublicFieldIntoPublicPropertyIgnoringReferences()
216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252
        {
            var text = @"
class foo
{
    public int b[|a|]r;

    void baz()
    {
        var q = bar;
    }
}
";

            var expected = @"
class foo
{
    private int bar;

    public int Bar
    {
        get
        {
            return bar;
        }

        set
        {
            bar = value;
        }
    }

    void baz()
    {
        var q = bar;
    }
}
";
253
            await TestAllOptionsOffAsync(text, expected, compareTokens: false, index: 1);
254 255
        }

256
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
257
        public async Task PublicFieldIntoPublicPropertyUpdatingReferences()
258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294
        {
            var text = @"
class foo
{
    public int b[|a|]r;

    void baz()
    {
        var q = bar;
    }
}
";

            var expected = @"
class foo
{
    private int bar;

    public int Bar
    {
        get
        {
            return bar;
        }

        set
        {
            bar = value;
        }
    }

    void baz()
    {
        var q = Bar;
    }
}
";
295
            await TestAllOptionsOffAsync(text, expected, compareTokens: false, index: 0);
296 297
        }

298
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
299
        public async Task StaticPreserved()
300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322
        {
            var text = @"class Program
{
    static int [|foo|];
}";

            var expected = @"class Program
{
    static int foo;

    public static int Foo
    {
        get
        {
            return foo;
        }

        set
        {
            foo = value;
        }
    }
}";
323
            await TestAllOptionsOffAsync(text, expected, compareTokens: false);
324 325
        }

326
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
327
        public async Task UniqueNameGenerated()
328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354
        {
            var text = @"
class Program
{
    [|int foo|];
    string Foo;
}";

            var expected = @"
class Program
{
    int foo;
    string Foo;

    public int Foo1
    {
        get
        {
            return foo;
        }

        set
        {
            foo = value;
        }
    }
}";
355
            await TestAllOptionsOffAsync(text, expected, compareTokens: false);
356 357
        }

358
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
359
        public async Task GenericField()
360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384
        {
            var text = @"
class C<T>
{
    private [|T foo|];
}";

            var expected = @"
class C<T>
{
    private T foo;

    public T Foo
    {
        get
        {
            return foo;
        }

        set
        {
            foo = value;
        }
    }
}";
385
            await TestAllOptionsOffAsync(text, expected, compareTokens: false);
386 387
        }

388
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
389
        public async Task NewFieldNameIsUnique()
390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416
        {
            var text = @"
class foo
{
    public [|int X|];
    private string x;
}";

            var expected = @"
class foo
{
    private int x1;
    private string x;

    public int X
    {
        get
        {
            return x1;
        }

        set
        {
            x1 = value;
        }
    }
}";
417
            await TestAllOptionsOffAsync(text, expected, compareTokens: false, index: 0);
418 419
        }

420
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
421
        public async Task RespectReadonly()
422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441
        {
            var text = @"
class foo
{
    private readonly [|int x|];
}";

            var expected = @"
class foo
{
    private readonly int x;

    public int X
    {
        get
        {
            return x;
        }
    }
}";
442
            await TestAllOptionsOffAsync(text, expected, compareTokens: false, index: 0);
443 444
        }

445
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
446
        public async Task PreserveNewAndConsiderBaseMemberNames()
447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485
        {
            var text = @"
class c
{
    protected int foo;

    protected int Foo { get; set; }
}

class d : c
{
    protected new int [|foo|];
}";

            var expected = @"
class c
{
    protected int foo;

    protected int Foo { get; set; }
}

class d : c
{
    private new int foo;

    protected int Foo1
    {
        get
        {
            return foo;
        }

        set
        {
            foo = value;
        }
    }
}";
486
            await TestAllOptionsOffAsync(text, expected, compareTokens: false, index: 0);
487 488
        }

489
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
490
        public async Task EncapsulateMultiplePrivateFields()
491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540
        {
            var text = @"
class foo
{
    private int [|x, y|];

    void bar()
    {
        x = 1;
        y = 2;
    }
}";

            var expected = @"
class foo
{
    private int x, y;

    public int X
    {
        get
        {
            return x;
        }

        set
        {
            x = value;
        }
    }

    public int Y
    {
        get
        {
            return y;
        }

        set
        {
            y = value;
        }
    }

    void bar()
    {
        X = 1;
        Y = 2;
    }
}";
541
            await TestAllOptionsOffAsync(text, expected, compareTokens: false, index: 0);
542 543
        }

544
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
545
        public async Task EncapsulateMultiplePrivateFields2()
546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597
        {
            var text = @"
class foo
{
    [|private int x;
    private int y|];

    void bar()
    {
        x = 1;
        y = 2;
    }
}";

            var expected = @"
class foo
{
    private int x;
    private int y;

    public int X
    {
        get
        {
            return x;
        }

        set
        {
            x = value;
        }
    }

    public int Y
    {
        get
        {
            return y;
        }

        set
        {
            y = value;
        }
    }

    void bar()
    {
        X = 1;
        Y = 2;
    }
}";
598
            await TestAllOptionsOffAsync(text, expected, compareTokens: false, index: 0);
599 600
        }

601
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
602
        public async Task EncapsulateSinglePublicFieldInMultipleVariableDeclarationAndUpdateReferences()
603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640
        {
            var text = @"
class foo
{
    public int [|x|], y;

    void bar()
    {
        x = 1;
        y = 2;
    }
}";

            var expected = @"
class foo
{
    public int y;
    private int x;

    public int X
    {
        get
        {
            return x;
        }

        set
        {
            x = value;
        }
    }

    void bar()
    {
        X = 1;
        y = 2;
    }
}";
641
            await TestAllOptionsOffAsync(text, expected, compareTokens: false, index: 0);
642 643
        }

J
Jared Parsons 已提交
644
        [WorkItem(694057, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/694057")]
645
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
646
        public async Task ConstFieldNoGetter()
647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668
        {
            var text = @"
class Program
{
    private const int [|bar|] = 3;
}
";

            var expected = @"
class Program
{
    private const int bar = 3;

    public static int Bar
    {
        get
        {
            return bar;
        }
    }
}
";
669
            await TestAllOptionsOffAsync(text, expected, compareTokens: false, index: 0);
670 671
        }

J
Jared Parsons 已提交
672
        [WorkItem(694276, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/694276")]
673
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
674
        public async Task EncapsulateFieldNamedValue()
675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696
        {
            var text = @"
class Program
{
    private const int [|bar|] = 3;
}
";

            var expected = @"
class Program
{
    private const int bar = 3;

    public static int Bar
    {
        get
        {
            return bar;
        }
    }
}
";
697
            await TestAllOptionsOffAsync(text, expected, compareTokens: false, index: 0);
698 699
        }

J
Jared Parsons 已提交
700
        [WorkItem(694276, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/694276")]
701
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
702
        public async Task PublicFieldNamed__()
703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729
        {
            var text = @"
class Program
{
    public int [|__|];
}
";

            var expected = @"
class Program
{
    private int __1;

    public int __
    {
        get
        {
            return __1;
        }

        set
        {
            __1 = value;
        }
    }
}
";
730
            await TestAllOptionsOffAsync(text, expected, compareTokens: false, index: 0);
731 732
        }

J
Jared Parsons 已提交
733
        [WorkItem(695046, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/695046")]
734
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
735
        public async Task AvailableNotJustOnVariableName()
736 737 738 739 740 741 742 743
        {
            var text = @"
class Program
{
    pri[||]vate int x;
}
";

744
            await TestActionCountAsync(text, 2);
745 746
        }

J
Jared Parsons 已提交
747
        [WorkItem(705898, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/705898")]
748
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
749
        public async Task CopyFieldAccessibility()
750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771
        {
            var text = @"
class Program
{
    protected const int [|bar|] = 3;
}
";

            var expected = @"
class Program
{
    private const int bar = 3;

    protected static int Bar
    {
        get
        {
            return bar;
        }
    }
}
";
772
            await TestAllOptionsOffAsync(text, expected, compareTokens: false, index: 0);
773 774
        }

775
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
776
        public async Task UpdateReferencesCrossProject()
777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839
        {
            var text = @"
<Workspace>
    <Project Language=""C#"" AssemblyName=""Assembly1"" CommonReferences=""true"">
        <Document>
public class C
{
    public int [|foo|];
}
        </Document>
    </Project>
    <Project Language=""C#"" AssemblyName=""Assembly2"" CommonReferences=""true"">
        <ProjectReference>Assembly1</ProjectReference>
        <Document>
public class D
{
    void bar()
    {
        var c = new C;
        c.foo = 3;
    }
}
        </Document>
    </Project>
</Workspace>";

            var expected = @"
<Workspace>
    <Project Language=""C#"" AssemblyName=""Assembly1"" CommonReferences=""true"">
        <Document>
public class C
{
    private int foo;

    public int Foo
    {
        get
        {
            return foo;
        }

        set
        {
            foo = value;
        }
    }
}
        </Document>
    </Project>
    <Project Language=""C#"" AssemblyName=""Assembly2"" CommonReferences=""true"">
        <ProjectReference>Assembly1</ProjectReference>
        <Document>
public class D
{
    void bar()
    {
        var c = new C;
        c.Foo = 3;
    }
}
        </Document>
    </Project>
</Workspace>";
840
            await TestAllOptionsOffAsync(text, expected, new CodeAnalysis.CSharp.CSharpParseOptions(), TestOptions.ReleaseExe, compareTokens: false);
841 842
        }

J
Jared Parsons 已提交
843
        [WorkItem(713269, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/713269")]
844
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
845
        public async Task PreserveUnsafe()
846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872
        {
            var text = @"
class C
{
    unsafe int* [|foo|];
}
";

            var expected = @"
class C
{
    unsafe int* foo;

    public unsafe int* Foo
    {
        get
        {
            return foo;
        }

        set
        {
            foo = value;
        }
    }
}
";
873
            await TestAllOptionsOffAsync(text, expected, compareTokens: false, index: 0);
874 875
        }

J
Jared Parsons 已提交
876
        [WorkItem(713240, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/713240")]
877
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
878
        public async Task ConsiderReturnTypeAccessibility()
879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915
        {
            var text = @"
public class Program
{
    private State [|state|];
}
 
internal enum State
{
    WA
}
";

            var expected = @"
public class Program
{
    private State state;

    internal State State
    {
        get
        {
            return state;
        }

        set
        {
            state = value;
        }
    }
}
 
internal enum State
{
    WA
}
";
916
            await TestAllOptionsOffAsync(text, expected, compareTokens: false, index: 0);
917 918
        }

J
Jared Parsons 已提交
919
        [WorkItem(713191, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/713191")]
920
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
921
        public async Task DoNotReferToReadOnlyPropertyInConstructor()
922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951
        {
            var text = @"
class Program
{
    public readonly int [|Field|];
 
    public Program(int f)
    {
        this.Field = f;
    }
}";

            var expected = @"
class Program
{
    private readonly int field;

    public Program(int f)
    {
        this.field = f;
    }

    public int Field
    {
        get
        {
            return field;
        }
    }
}";
952
            await TestAllOptionsOffAsync(text, expected, compareTokens: false, index: 0);
953 954
        }

J
Jared Parsons 已提交
955
        [WorkItem(713191, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/713191")]
956
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
957
        public async Task DoNotReferToStaticReadOnlyPropertyInConstructor()
958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987
        {
            var text = @"
class Program
{
    public static readonly int [|Field|];
 
    static Program()
    {
        Field = 3;
    }
}";

            var expected = @"
class Program
{
    private static readonly int field;

    static Program()
    {
        field = 3;
    }

    public static int Field
    {
        get
        {
            return field;
        }
    }
}";
988
            await TestAllOptionsOffAsync(text, expected, compareTokens: false, index: 0);
989 990
        }

J
Jared Parsons 已提交
991
        [WorkItem(765959, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/765959")]
992
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
993
        public async Task GenerateInTheCorrectPart()
994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020
        {
            var text = @"
partial class Program {}

partial class Program {
   private int [|x|];
}
";
            var expected = @"
partial class Program {}

partial class Program {
    private int x;

    public int X
    {
        get
        {
            return x;
        }
        set
        {
            x = value;
        }
    }
}
";
1021
            await TestAllOptionsOffAsync(text, expected);
1022 1023
        }

J
Jared Parsons 已提交
1024
        [WorkItem(829178, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/829178")]
1025
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
C
Cyrus Najmabadi 已提交
1026
        public async Task ErrorTolerance()
1027
        {
1028 1029 1030 1031
            var text = @"class Program 
{
    a b c [|b|]
}";
1032

C
Cyrus Najmabadi 已提交
1033
            using (var workspace = await CreateWorkspaceFromFileAsync(text, null, null))
1034
            {
1035
                var result = await GetCodeRefactoringAsync(workspace);
1036 1037 1038 1039
                Assert.NotNull(result);
            }
        }

J
Jared Parsons 已提交
1040
        [WorkItem(834072, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/834072")]
1041
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
C
Cyrus Najmabadi 已提交
1042
        public async Task DuplicateFieldErrorTolerance()
1043 1044 1045 1046 1047 1048 1049 1050 1051
        {
            var text = @"
class Program
{
    public const string [|s|] = ""S"";
    public const string s = ""S"";
    }
";

C
Cyrus Najmabadi 已提交
1052
            using (var workspace = await CreateWorkspaceFromFileAsync(text, null, null))
1053
            {
1054
                var result = await GetCodeRefactoringAsync(workspace);
1055 1056 1057 1058
                Assert.NotNull(result);
            }
        }

J
Jared Parsons 已提交
1059
        [WorkItem(862517, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/862517")]
1060
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
1061
        public async Task Trivia()
1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096
        {
            var text = @"
namespace ConsoleApplication1
{
    class Program
    {
        // Some random comment
        public int myI[||]nt;
    }
}
";

            var expected = @"
namespace ConsoleApplication1
{
    class Program
    {
        // Some random comment
        private int myInt;

        public int MyInt
        {
            get
            {
                return myInt;
            }

            set
            {
                myInt = value;
            }
        }
    }
}";

1097
            await TestAllOptionsOffAsync(text, expected);
1098
        }
M
Matt Warren 已提交
1099 1100

        [WorkItem(1096007, "https://github.com/dotnet/roslyn/issues/282")]
1101
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
1102
        public async Task DoNotEncapsulateOutsideTypeDeclaration()
M
Matt Warren 已提交
1103
        {
C
CyrusNajmabadi 已提交
1104 1105
            await TestMissingAsync(
@"var [|x|] = 1;");
M
Matt Warren 已提交
1106

C
CyrusNajmabadi 已提交
1107 1108
            await TestMissingAsync(
@"namespace N
M
Matt Warren 已提交
1109 1110 1111 1112
{
    var [|x|] = 1;
}");

C
CyrusNajmabadi 已提交
1113 1114
            await TestMissingAsync(
@"enum E
M
Matt Warren 已提交
1115 1116 1117 1118
{
    [|x|] = 1;
}");
        }
1119 1120

        [WorkItem(5524, "https://github.com/dotnet/roslyn/issues/5524")]
1121
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
1122
        public async Task AlwaysUseEnglishUSCultureWhenFixingVariableNames_TurkishDottedI()
1123 1124 1125
        {
            using (new CultureContext("tr-TR"))
            {
1126 1127
                await TestAllOptionsOffAsync(
@"class C
1128 1129
{
    int [|iyi|];
1130 1131
}", 
@"class C
1132 1133 1134 1135 1136 1137 1138 1139 1140
{
    int iyi;

    public int Iyi
    {
        get
        {
            return iyi;
        }
1141

1142 1143 1144 1145 1146
        set
        {
            iyi = value;
        }
    }
1147
}");
1148 1149 1150 1151
            }
        }

        [WorkItem(5524, "https://github.com/dotnet/roslyn/issues/5524")]
1152
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
1153
        public async Task AlwaysUseEnglishUSCultureWhenFixingVariableNames_TurkishUndottedI()
1154 1155 1156
        {
            using (new CultureContext("tr-TR"))
            {
1157 1158
                await TestAllOptionsOffAsync(
@"class C
1159 1160
{
    int [|ırak|];
1161 1162
}", 
@"class C
1163 1164 1165 1166 1167 1168 1169 1170 1171
{
    int ırak;

    public int Irak
    {
        get
        {
            return ırak;
        }
1172

1173 1174 1175 1176 1177
        set
        {
            ırak = value;
        }
    }
1178
}");
1179 1180 1181 1182
            }
        }

        [WorkItem(5524, "https://github.com/dotnet/roslyn/issues/5524")]
1183
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
1184
        public async Task AlwaysUseEnglishUSCultureWhenFixingVariableNames_Arabic()
1185 1186 1187
        {
            using (new CultureContext("ar-EG"))
            {
1188 1189
                await TestAllOptionsOffAsync(
@"class C
1190 1191
{
    int [|بيت|];
1192 1193
}", 
@"class C
1194 1195 1196 1197 1198 1199 1200 1201 1202
{
    int بيت;

    public int بيت1
    {
        get
        {
            return بيت;
        }
1203

1204 1205 1206 1207 1208
        set
        {
            بيت = value;
        }
    }
1209
}");
1210 1211 1212 1213
            }
        }

        [WorkItem(5524, "https://github.com/dotnet/roslyn/issues/5524")]
1214
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
1215
        public async Task AlwaysUseEnglishUSCultureWhenFixingVariableNames_Spanish()
1216 1217 1218
        {
            using (new CultureContext("es-ES"))
            {
1219 1220
                await TestAllOptionsOffAsync(
@"class C
1221 1222
{
    int [|árbol|];
1223 1224
}", 
@"class C
1225 1226 1227 1228 1229 1230 1231 1232 1233
{
    int árbol;

    public int Árbol
    {
        get
        {
            return árbol;
        }
1234

1235 1236 1237 1238 1239
        set
        {
            árbol = value;
        }
    }
1240
}");
1241 1242 1243 1244
            }
        }

        [WorkItem(5524, "https://github.com/dotnet/roslyn/issues/5524")]
1245
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
1246
        public async Task AlwaysUseEnglishUSCultureWhenFixingVariableNames_Greek()
1247 1248 1249
        {
            using (new CultureContext("el-GR"))
            {
1250 1251
                await TestAllOptionsOffAsync(
@"class C
1252 1253
{
    int [|σκύλος|];
1254 1255
}", 
@"class C
1256 1257 1258 1259 1260 1261 1262 1263 1264
{
    int σκύλος;

    public int Σκύλος
    {
        get
        {
            return σκύλος;
        }
1265

1266 1267 1268 1269 1270
        set
        {
            σκύλος = value;
        }
    }
1271
}");
1272 1273
            }
        }
1274 1275 1276 1277

        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
        public async Task TestEncapsulateEscapedIdentifier()
        {
1278
            await TestAllOptionsOffAsync(@"
1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306
class C
{
    int [|@class|];
}
", @"
class C
{
    int @class;

    public int Class
    {
        get
        {
            return @class;
        }

        set
        {
            @class = value;
        }
    }
}
", compareTokens: false);
        }

        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
        public async Task TestEncapsulateEscapedIdentifierAndQualifiedAccess()
        {
1307
            await TestAllOptionsOffAsync(@"
1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329
class C
{
    int [|@class|];
}
", @"
class C
{
    int @class;

    public int Class
    {
        get
        {
            return this.@class;
        }

        set
        {
            this.@class = value;
        }
    }
}
1330
", compareTokens: false, options: Option(CodeStyleOptions.QualifyFieldAccess, true, NotificationOption.Error));
1331 1332 1333 1334 1335 1336
        }

        [WorkItem(7090, "https://github.com/dotnet/roslyn/issues/7090")]
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField)]
        public async Task ApplyCurrentThisPrefixStyle()
        {
1337 1338
            await TestAllOptionsOffAsync(
@"class C
1339 1340
{
    int [|i|];
1341 1342
}", 
@"class C
1343 1344 1345 1346 1347 1348 1349 1350 1351
{
    int i;

    public int I
    {
        get
        {
            return this.i;
        }
1352

1353 1354 1355 1356 1357
        set
        {
            this.i = value;
        }
    }
1358
}", options: Option(CodeStyleOptions.QualifyFieldAccess, true, NotificationOption.Error));
1359
        }
1360

1361
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField), Test.Utilities.CompilerTrait(Test.Utilities.CompilerFeature.Tuples)]
1362
        public async Task TestTuple()
1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399
        {
            var text = @"
class C
{
    private (int, string) b[|o|]b;

    void M()
    {
        var q = bob;
    }
}
";

            var expected = @"
class C
{
    private (int, string) bob;

    public (int, string) Bob
    {
        get
        {
            return bob;
        }

        set
        {
            bob = value;
        }
    }

    void M()
    {
        var q = bob;
    }
}
";
1400
            await TestAllOptionsOffAsync(text, expected, compareTokens: false, index: 1, parseOptions: TestOptions.Regular, withScriptOption: true);
1401 1402
        }

1403
        [Fact, Trait(Traits.Feature, Traits.Features.EncapsulateField), Test.Utilities.CompilerTrait(Test.Utilities.CompilerFeature.Tuples)]
1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441
        public async Task TupleWithNames()
        {
            var text = @"
class C
{
    private (int a, string b) b[|o|]b;

    void M()
    {
        var q = bob.b;
    }
}
";

            var expected = @"
class C
{
    private (int a, string b) bob;

    public (int a, string b) Bob
    {
        get
        {
            return bob;
        }

        set
        {
            bob = value;
        }
    }

    void M()
    {
        var q = bob.b;
    }
}
";
1442
            await TestAllOptionsOffAsync(text, expected, compareTokens: false, index: 1, parseOptions: TestOptions.Regular, withScriptOption: true);
1443
        }
1444 1445
    }
}