CodeFixService.cs 35.1 KB
Newer Older
T
Tomas Matousek 已提交
1
// Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.
2 3 4 5

using System;
using System.Collections.Generic;
using System.Collections.Immutable;
6
using System.Composition;
H
Heejae Chang 已提交
7
using System.Diagnostics;
8
using System.Linq;
9 10 11 12 13
using System.Runtime.CompilerServices;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.CodeAnalysis.CodeFixes.Suppression;
using Microsoft.CodeAnalysis.Diagnostics;
14
using Microsoft.CodeAnalysis.ErrorLogger;
15 16
using Microsoft.CodeAnalysis.Extensions;
using Microsoft.CodeAnalysis.Host.Mef;
T
Tomas Matousek 已提交
17
using Microsoft.CodeAnalysis.PooledObjects;
18 19 20
using Microsoft.CodeAnalysis.Shared.Extensions;
using Microsoft.CodeAnalysis.Shared.Utilities;
using Microsoft.CodeAnalysis.Text;
21
using Microsoft.VisualStudio.Threading;
22 23 24 25
using Roslyn.Utilities;

namespace Microsoft.CodeAnalysis.CodeFixes
{
26
    using Editor.Shared.Utilities;
27 28 29
    using DiagnosticId = String;
    using LanguageKind = String;

30
    [Export(typeof(ICodeFixService)), Shared]
31
    internal partial class CodeFixService : ForegroundThreadAffinitizedObject, ICodeFixService
32
    {
33
        private readonly IDiagnosticAnalyzerService _diagnosticService;
34

35 36
        private readonly ImmutableDictionary<LanguageKind, Lazy<ImmutableDictionary<DiagnosticId, ImmutableArray<CodeFixProvider>>>> _workspaceFixersMap;
        private readonly ConditionalWeakTable<IReadOnlyList<AnalyzerReference>, ImmutableDictionary<DiagnosticId, List<CodeFixProvider>>> _projectFixersMap;
37 38

        // Shared by project fixers and workspace fixers.
39
        private ImmutableDictionary<CodeFixProvider, ImmutableArray<DiagnosticId>> _fixerToFixableIdsMap = ImmutableDictionary<CodeFixProvider, ImmutableArray<DiagnosticId>>.Empty;
40

41
        private readonly ImmutableDictionary<LanguageKind, Lazy<ImmutableDictionary<CodeFixProvider, int>>> _fixerPriorityMap;
42

43 44
        private readonly ConditionalWeakTable<AnalyzerReference, ProjectCodeFixProvider> _analyzerReferenceToFixersMap;
        private readonly ConditionalWeakTable<AnalyzerReference, ProjectCodeFixProvider>.CreateValueCallback _createProjectCodeFixProvider;
45

46
        private readonly ImmutableDictionary<LanguageKind, Lazy<ISuppressionFixProvider>> _suppressionProvidersMap;
J
Jonathon Marolf 已提交
47
        private readonly IEnumerable<Lazy<IErrorLoggerService>> _errorLoggers;
48

49
        private ImmutableDictionary<object, FixAllProviderInfo> _fixAllProviderMap;
50

51 52
        [ImportingConstructor]
        public CodeFixService(
53
            IThreadingContext threadingContext,
54
            IDiagnosticAnalyzerService service,
J
Jonathon Marolf 已提交
55
            [ImportMany]IEnumerable<Lazy<IErrorLoggerService>> loggers,
56 57
            [ImportMany]IEnumerable<Lazy<CodeFixProvider, CodeChangeProviderMetadata>> fixers,
            [ImportMany]IEnumerable<Lazy<ISuppressionFixProvider, CodeChangeProviderMetadata>> suppressionProviders)
58
            : base(threadingContext, assertIsForeground: false)
59
        {
J
Jonathon Marolf 已提交
60
            _errorLoggers = loggers;
61
            _diagnosticService = service;
62 63 64
            var fixersPerLanguageMap = fixers.ToPerLanguageMapWithMultipleLanguages();
            var suppressionProvidersPerLanguageMap = suppressionProviders.ToPerLanguageMapWithMultipleLanguages();

J
Jonathon Marolf 已提交
65
            _workspaceFixersMap = GetFixerPerLanguageMap(fixersPerLanguageMap, null);
A
Andrew Casey 已提交
66
            _suppressionProvidersMap = GetSuppressionProvidersPerLanguageMap(suppressionProvidersPerLanguageMap);
67 68

            // REVIEW: currently, fixer's priority is statically defined by the fixer itself. might considering making it more dynamic or configurable.
69
            _fixerPriorityMap = GetFixerPriorityPerLanguageMap(fixersPerLanguageMap);
70 71

            // Per-project fixers
72 73 74
            _projectFixersMap = new ConditionalWeakTable<IReadOnlyList<AnalyzerReference>, ImmutableDictionary<string, List<CodeFixProvider>>>();
            _analyzerReferenceToFixersMap = new ConditionalWeakTable<AnalyzerReference, ProjectCodeFixProvider>();
            _createProjectCodeFixProvider = new ConditionalWeakTable<AnalyzerReference, ProjectCodeFixProvider>.CreateValueCallback(r => new ProjectCodeFixProvider(r));
75
            _fixAllProviderMap = ImmutableDictionary<object, FixAllProviderInfo>.Empty;
76 77
        }

S
Sam Harwell 已提交
78
        public async Task<FirstDiagnosticResult> GetMostSevereFixableDiagnosticAsync(
79
            Document document, TextSpan range, CancellationToken cancellationToken)
80 81 82
        {
            if (document == null || !document.IsOpen())
            {
C
CyrusNajmabadi 已提交
83
                return default;
84 85 86 87
            }

            using (var diagnostics = SharedPools.Default<List<DiagnosticData>>().GetPooledObject())
            {
R
Ravi Chande 已提交
88
                using (var linkedTokenSource = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken))
89
                {
R
Ravi Chande 已提交
90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121
                    var linkedToken = linkedTokenSource.Token;

                    // This flag is used by SuggestedActionsSource to track what solution is was
                    // last able to get "full results" for.
                    var isFullResult = await _diagnosticService.TryAppendDiagnosticsForSpanAsync(
                        document, range, diagnostics.Object, cancellationToken: linkedToken).ConfigureAwait(false);

                    var errorDiagnostics = diagnostics.Object.Where(d => d.Severity == DiagnosticSeverity.Error);
                    var otherDiagnostics = diagnostics.Object.Where(d => d.Severity != DiagnosticSeverity.Error);

                    // Kick off a task that will determine there's an Error Diagnostic with a fixer
                    var errorDiagnosticsTask = Task.Run(
                        () => GetFirstDiagnosticWithFixAsync(document, errorDiagnostics, range, linkedToken),
                        linkedToken);

                    // Kick off a task that will determine if any non-Error Diagnostic has a fixer
                    var otherDiagnosticsTask = Task.Run(
                        () => GetFirstDiagnosticWithFixAsync(document, otherDiagnostics, range, linkedToken),
                        linkedToken);

                    // If the error diagnostics task happens to complete with a non-null result before
                    // the other diagnostics task, we can cancel the other task.
                    var diagnostic = await errorDiagnosticsTask.ConfigureAwait(false)
                        ?? await otherDiagnosticsTask.ConfigureAwait(false);
                    linkedTokenSource.Cancel();

                    return new FirstDiagnosticResult(partialResult: !isFullResult,
                                           hasFix: diagnostic != null,
                                           diagnostic: diagnostic);
                }
            }
        }
122

R
Ravi Chande 已提交
123 124 125 126 127 128 129 130 131 132 133
        private async Task<DiagnosticData> GetFirstDiagnosticWithFixAsync(
            Document document,
            IEnumerable<DiagnosticData> severityGroup,
            TextSpan range,
            CancellationToken cancellationToken)
        {
            foreach (var diagnostic in severityGroup)
            {
                if (!range.IntersectsWith(diagnostic.TextSpan))
                {
                    continue;
134 135
                }

R
Ravi Chande 已提交
136 137 138 139
                if (await ContainsAnyFixAsync(document, diagnostic, cancellationToken).ConfigureAwait(false))
                {
                    return diagnostic;
                }
140
            }
R
Ravi Chande 已提交
141 142

            return null;
143 144
        }

J
JieCarolHu 已提交
145
        public async Task<ImmutableArray<CodeFixCollection>> GetFixesAsync(Document document, TextSpan range, bool includeSuppressionFixes, CancellationToken cancellationToken)
146 147
        {
            // REVIEW: this is the first and simplest design. basically, when ctrl+. is pressed, it asks diagnostic service to give back
C
Carol Hu 已提交
148
            // current diagnostics for the given span, and it will use that to get fixes. internally diagnostic service will either return cached information
149 150 151 152 153
            // (if it is up-to-date) or synchronously do the work at the spot.
            //
            // this design's weakness is that each side don't have enough information to narrow down works to do. it will most likely always do more works than needed.
            // sometimes way more than it is needed. (compilation)
            Dictionary<TextSpan, List<DiagnosticData>> aggregatedDiagnostics = null;
J
JieCarolHu 已提交
154
            foreach (var diagnostic in await _diagnosticService.GetDiagnosticsForSpanAsync(document, range, diagnosticIdOpt: null, includeSuppressionFixes, cancellationToken).ConfigureAwait(false))
155
            {
156
                if (diagnostic.IsSuppressed)
157 158 159 160
                {
                    continue;
                }

161 162 163 164 165 166
                cancellationToken.ThrowIfCancellationRequested();

                aggregatedDiagnostics = aggregatedDiagnostics ?? new Dictionary<TextSpan, List<DiagnosticData>>();
                aggregatedDiagnostics.GetOrAdd(diagnostic.TextSpan, _ => new List<DiagnosticData>()).Add(diagnostic);
            }

167
            if (aggregatedDiagnostics == null)
168
            {
C
CyrusNajmabadi 已提交
169
                return ImmutableArray<CodeFixCollection>.Empty;
170 171
            }

C
CyrusNajmabadi 已提交
172
            var result = ArrayBuilder<CodeFixCollection>.GetInstance();
173 174
            foreach (var spanAndDiagnostic in aggregatedDiagnostics)
            {
C
CyrusNajmabadi 已提交
175
                await AppendFixesAsync(
D
dotnet-bot 已提交
176
                    document, spanAndDiagnostic.Key, spanAndDiagnostic.Value, fixAllForInSpan: false,
C
CyrusNajmabadi 已提交
177
                    result, cancellationToken).ConfigureAwait(false);
178 179
            }

C
CyrusNajmabadi 已提交
180
            if (result.Count > 0)
181 182
            {
                // sort the result to the order defined by the fixers
183
                var priorityMap = _fixerPriorityMap[document.Project.Language].Value;
184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201
                result.Sort((d1, d2) =>
                {
                    if (priorityMap.TryGetValue((CodeFixProvider)d1.Provider, out int priority1))
                    {
                        if (priorityMap.TryGetValue((CodeFixProvider)d2.Provider, out int priority2))
                        {
                            return priority1 - priority2;
                        }
                        else
                        {
                            return -1;
                        }
                    }
                    else
                    {
                        return 1;
                    }
                });
202 203
            }

204 205
            // TODO (https://github.com/dotnet/roslyn/issues/4932): Don't restrict CodeFixes in Interactive
            if (document.Project.Solution.Workspace.Kind != WorkspaceKind.Interactive && includeSuppressionFixes)
206 207 208
            {
                foreach (var spanAndDiagnostic in aggregatedDiagnostics)
                {
C
CyrusNajmabadi 已提交
209
                    await AppendSuppressionsAsync(
R
Ravi Chande 已提交
210
                        document, spanAndDiagnostic.Key, spanAndDiagnostic.Value,
C
CyrusNajmabadi 已提交
211
                        result, cancellationToken).ConfigureAwait(false);
212 213 214
                }
            }

C
CyrusNajmabadi 已提交
215
            return result.ToImmutableAndFree();
216 217
        }

S
Sam Harwell 已提交
218
        public async Task<CodeFixCollection> GetDocumentFixAllForIdInSpanAsync(Document document, TextSpan range, string diagnosticId, CancellationToken cancellationToken)
C
Carol Hu 已提交
219
        {
J
JieCarolHu 已提交
220
            var diagnostics = (await _diagnosticService.GetDiagnosticsForSpanAsync(document, range, diagnosticId, includeSuppressedDiagnostics: false, cancellationToken: cancellationToken).ConfigureAwait(false)).ToList();
J
JieCarolHu 已提交
221 222 223 224 225 226
            if (diagnostics.Count == 0)
            {
                return null;
            }

            var result = ArrayBuilder<CodeFixCollection>.GetInstance();
D
dotnet-bot 已提交
227
            await AppendFixesAsync(document, range, diagnostics, fixAllForInSpan: true, result, cancellationToken).ConfigureAwait(false);
C
Carol Hu 已提交
228 229 230

            // TODO: Just get the first fix for now until we have a way to config user's preferred fix
            // https://github.com/dotnet/roslyn/issues/27066
J
JieCarolHu 已提交
231
            return result.ToImmutableAndFree().FirstOrDefault();
C
Carol Hu 已提交
232 233
        }

S
Sam Harwell 已提交
234
        public async Task<Document> ApplyCodeFixesForSpecificDiagnosticIdAsync(Document document, string diagnosticId, IProgressTracker progressTracker, CancellationToken cancellationToken)
J
JieCarolHu 已提交
235 236 237 238
        {
            var tree = await document.GetSyntaxTreeAsync(cancellationToken).ConfigureAwait(false);
            var textSpan = new TextSpan(0, tree.Length);

S
Sam Harwell 已提交
239
            var fixCollection = await GetDocumentFixAllForIdInSpanAsync(
J
JieCarolHu 已提交
240 241 242
                document, textSpan, diagnosticId, cancellationToken).ConfigureAwait(false);
            if (fixCollection == null)
            {
J
JieCarolHu 已提交
243
                return document;
J
JieCarolHu 已提交
244 245 246 247 248
            }

            var fixAllService = document.Project.Solution.Workspace.Services.GetService<IFixAllGetFixesService>();

            var solution = await fixAllService.GetFixAllChangedSolutionAsync(
J
JieCarolHu 已提交
249
                fixCollection.FixAllState.CreateFixAllContext(progressTracker, cancellationToken)).ConfigureAwait(false);
J
JieCarolHu 已提交
250 251 252 253

            return solution.GetDocument(document.Id);
        }

C
CyrusNajmabadi 已提交
254
        private async Task AppendFixesAsync(
255 256
            Document document,
            TextSpan span,
257
            IEnumerable<DiagnosticData> diagnostics,
J
JieCarolHu 已提交
258
            bool fixAllForInSpan,
C
CyrusNajmabadi 已提交
259
            ArrayBuilder<CodeFixCollection> result,
260 261
            CancellationToken cancellationToken)
        {
C
CyrusNajmabadi 已提交
262
            bool hasAnySharedFixer = _workspaceFixersMap.TryGetValue(document.Project.Language, out var fixerMap);
263 264 265 266 267 268

            var projectFixersMap = GetProjectFixers(document.Project);
            var hasAnyProjectFixer = projectFixersMap.Any();

            if (!hasAnySharedFixer && !hasAnyProjectFixer)
            {
C
CyrusNajmabadi 已提交
269
                return;
270 271 272 273
            }

            var allFixers = new List<CodeFixProvider>();

274 275 276
            // TODO (https://github.com/dotnet/roslyn/issues/4932): Don't restrict CodeFixes in Interactive
            bool isInteractive = document.Project.Solution.Workspace.Kind == WorkspaceKind.Interactive;

277
            foreach (var diagnosticId in diagnostics.Select(d => d.Id).Distinct())
278 279 280
            {
                cancellationToken.ThrowIfCancellationRequested();

C
CyrusNajmabadi 已提交
281
                if (hasAnySharedFixer && fixerMap.Value.TryGetValue(diagnosticId, out var workspaceFixers))
282
                {
283 284 285 286 287 288 289 290
                    if (isInteractive)
                    {
                        allFixers.AddRange(workspaceFixers.Where(IsInteractiveCodeFixProvider));
                    }
                    else
                    {
                        allFixers.AddRange(workspaceFixers);
                    }
291 292
                }

C
CyrusNajmabadi 已提交
293
                if (hasAnyProjectFixer && projectFixersMap.TryGetValue(diagnosticId, out var projectFixers))
294
                {
295
                    Debug.Assert(!isInteractive);
296 297 298 299
                    allFixers.AddRange(projectFixers);
                }
            }

J
Jonathon Marolf 已提交
300
            var extensionManager = document.Project.Solution.Workspace.Services.GetService<IExtensionManager>();
301 302 303 304 305

            foreach (var fixer in allFixers.Distinct())
            {
                cancellationToken.ThrowIfCancellationRequested();

C
CyrusNajmabadi 已提交
306
                await AppendFixesOrSuppressionsAsync(
J
JieCarolHu 已提交
307
                    document, span, diagnostics, fixAllForInSpan, result, fixer,
C
CyrusNajmabadi 已提交
308
                    hasFix: d => this.GetFixableDiagnosticIds(fixer, extensionManager).Contains(d.Id),
J
JieCarolHu 已提交
309 310 311 312 313 314 315 316 317 318 319 320 321
                    getFixes: dxs =>
                    {
                        if (fixAllForInSpan)
                        {
                            var primaryDiagnostic = dxs.First();
                            return GetCodeFixesAsync(document, primaryDiagnostic.Location.SourceSpan, fixer, ImmutableArray.Create(primaryDiagnostic), cancellationToken);

                        }
                        else
                        {
                            return GetCodeFixesAsync(document, span, fixer, dxs, cancellationToken);
                        }
                    },
C
CyrusNajmabadi 已提交
322
                    cancellationToken: cancellationToken).ConfigureAwait(false);
J
JieCarolHu 已提交
323 324 325

                // Just need the first result if we are doing fix all in span
                if (fixAllForInSpan && result.Any()) return;
326 327 328
            }
        }

C
CyrusNajmabadi 已提交
329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346
        private async Task<ImmutableArray<CodeFix>> GetCodeFixesAsync(
            Document document, TextSpan span, CodeFixProvider fixer,
            ImmutableArray<Diagnostic> diagnostics, CancellationToken cancellationToken)
        {
            var fixes = ArrayBuilder<CodeFix>.GetInstance();
            var context = new CodeFixContext(document, span, diagnostics,
                // TODO: Can we share code between similar lambdas that we pass to this API in BatchFixAllProvider.cs, CodeFixService.cs and CodeRefactoringService.cs?
                (action, applicableDiagnostics) =>
                {
                    // Serialize access for thread safety - we don't know what thread the fix provider will call this delegate from.
                    lock (fixes)
                    {
                        fixes.Add(new CodeFix(document.Project, action, applicableDiagnostics));
                    }
                },
                verifyArguments: false,
                cancellationToken: cancellationToken);

347
            var task = fixer.RegisterCodeFixesAsync(context) ?? Task.CompletedTask;
C
CyrusNajmabadi 已提交
348 349 350 351
            await task.ConfigureAwait(false);
            return fixes.ToImmutableAndFree();
        }

C
CyrusNajmabadi 已提交
352
        private async Task AppendSuppressionsAsync(
R
Ravi Chande 已提交
353
            Document document, TextSpan span, IEnumerable<DiagnosticData> diagnostics,
C
CyrusNajmabadi 已提交
354
            ArrayBuilder<CodeFixCollection> result, CancellationToken cancellationToken)
355
        {
C
CyrusNajmabadi 已提交
356
            if (!_suppressionProvidersMap.TryGetValue(document.Project.Language, out var lazySuppressionProvider) || lazySuppressionProvider.Value == null)
357
            {
C
CyrusNajmabadi 已提交
358
                return;
359 360
            }

C
CyrusNajmabadi 已提交
361
            await AppendFixesOrSuppressionsAsync(
D
dotnet-bot 已提交
362
                document, span, diagnostics, fixAllForInSpan: false, result, lazySuppressionProvider.Value,
C
CyrusNajmabadi 已提交
363 364
                hasFix: d => lazySuppressionProvider.Value.CanBeSuppressedOrUnsuppressed(d),
                getFixes: dxs => lazySuppressionProvider.Value.GetSuppressionsAsync(
R
Ravi Chande 已提交
365
                    document, span, dxs, cancellationToken),
C
CyrusNajmabadi 已提交
366
                cancellationToken: cancellationToken).ConfigureAwait(false);
367 368
        }

C
CyrusNajmabadi 已提交
369
        private async Task AppendFixesOrSuppressionsAsync(
370 371
            Document document,
            TextSpan span,
372
            IEnumerable<DiagnosticData> diagnosticsWithSameSpan,
J
JieCarolHu 已提交
373
            bool fixAllForInSpan,
C
CyrusNajmabadi 已提交
374
            ArrayBuilder<CodeFixCollection> result,
375 376
            object fixer,
            Func<Diagnostic, bool> hasFix,
377
            Func<ImmutableArray<Diagnostic>, Task<ImmutableArray<CodeFix>>> getFixes,
378 379
            CancellationToken cancellationToken)
        {
R
Ravi Chande 已提交
380
            var allDiagnostics =
C
CyrusNajmabadi 已提交
381 382 383
                await diagnosticsWithSameSpan.OrderByDescending(d => d.Severity)
                                             .ToDiagnosticsAsync(document.Project, cancellationToken).ConfigureAwait(false);
            var diagnostics = allDiagnostics.WhereAsArray(hasFix);
384 385 386
            if (diagnostics.Length <= 0)
            {
                // this can happen for suppression case where all diagnostics can't be suppressed
C
CyrusNajmabadi 已提交
387
                return;
388
            }
S
Shyam N 已提交
389

J
Jonathon Marolf 已提交
390
            var extensionManager = document.Project.Solution.Workspace.Services.GetService<IExtensionManager>();
391
            var fixes = await extensionManager.PerformFunctionAsync(fixer,
J
JieCarolHu 已提交
392
                 () => getFixes(diagnostics),
393
                defaultValue: ImmutableArray<CodeFix>.Empty).ConfigureAwait(false);
S
Shyam N 已提交
394

C
CyrusNajmabadi 已提交
395
            if (fixes.IsDefaultOrEmpty)
396
            {
C
CyrusNajmabadi 已提交
397 398
                return;
            }
399

C
CyrusNajmabadi 已提交
400 401
            // If the fix provider supports fix all occurrences, then get the corresponding FixAllProviderInfo and fix all context.
            var fixAllProviderInfo = extensionManager.PerformFunction(fixer, () => ImmutableInterlocked.GetOrAdd(ref _fixAllProviderMap, fixer, FixAllProviderInfo.Create), defaultValue: null);
402

C
CyrusNajmabadi 已提交
403
            FixAllState fixAllState = null;
C
CyrusNajmabadi 已提交
404
            var supportedScopes = ImmutableArray<FixAllScope>.Empty;
C
CyrusNajmabadi 已提交
405 406 407
            if (fixAllProviderInfo != null)
            {
                var codeFixProvider = (fixer as CodeFixProvider) ?? new WrapperCodeFixProvider((ISuppressionFixProvider)fixer, diagnostics.Select(d => d.Id));
J
JieCarolHu 已提交
408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425

                var diagnosticIds = diagnostics.Where(fixAllProviderInfo.CanBeFixed)
                                          .Select(d => d.Id)
                                          .ToImmutableHashSet();

                var diagnosticProvider = fixAllForInSpan
                    ? new FixAllPredefinedDiagnosticProvider(allDiagnostics)
                    : (FixAllContext.DiagnosticProvider)new FixAllDiagnosticProvider(this, diagnosticIds);

                fixAllState = new FixAllState(
                    fixAllProvider: fixAllProviderInfo.FixAllProvider,
                    document: document,
                    codeFixProvider: codeFixProvider,
                    scope: FixAllScope.Document,
                    codeActionEquivalenceKey: null,
                    diagnosticIds: diagnosticIds,
                    fixAllDiagnosticProvider: diagnosticProvider);

C
CyrusNajmabadi 已提交
426
                supportedScopes = fixAllProviderInfo.SupportedScopes;
427
            }
C
CyrusNajmabadi 已提交
428 429 430 431 432

            var codeFix = new CodeFixCollection(
                fixer, span, fixes, fixAllState,
                supportedScopes, diagnostics.First());
            result.Add(codeFix);
433
        }
D
dotnet-bot 已提交
434

435
        public CodeFixProvider GetSuppressionFixer(string language, IEnumerable<string> diagnosticIds)
436
        {
C
CyrusNajmabadi 已提交
437
            if (!_suppressionProvidersMap.TryGetValue(language, out var lazySuppressionProvider) || lazySuppressionProvider.Value == null)
438 439 440 441
            {
                return null;
            }

442
            return new WrapperCodeFixProvider(lazySuppressionProvider.Value, diagnosticIds);
443 444
        }

445 446 447 448
        private async Task<IEnumerable<Diagnostic>> GetDocumentDiagnosticsAsync(Document document, ImmutableHashSet<string> diagnosticIds, CancellationToken cancellationToken)
        {
            Contract.ThrowIfNull(document);
            var solution = document.Project.Solution;
449
            var diagnostics = await _diagnosticService.GetDiagnosticsForIdsAsync(solution, null, document.Id, diagnosticIds, cancellationToken: cancellationToken).ConfigureAwait(false);
450
            Contract.ThrowIfFalse(diagnostics.All(d => d.DocumentId != null));
451
            return await diagnostics.ToDiagnosticsAsync(document.Project, cancellationToken).ConfigureAwait(false);
452 453 454 455 456 457 458 459
        }

        private async Task<IEnumerable<Diagnostic>> GetProjectDiagnosticsAsync(Project project, bool includeAllDocumentDiagnostics, ImmutableHashSet<string> diagnosticIds, CancellationToken cancellationToken)
        {
            Contract.ThrowIfNull(project);

            if (includeAllDocumentDiagnostics)
            {
460 461
                // Get all diagnostics for the entire project, including document diagnostics.
                var diagnostics = await _diagnosticService.GetDiagnosticsForIdsAsync(project.Solution, project.Id, diagnosticIds: diagnosticIds, cancellationToken: cancellationToken).ConfigureAwait(false);
462
                return await diagnostics.ToDiagnosticsAsync(project, cancellationToken).ConfigureAwait(false);
463 464 465
            }
            else
            {
466 467 468
                // Get all no-location diagnostics for the project, doesn't include document diagnostics.
                var diagnostics = await _diagnosticService.GetProjectDiagnosticsForIdsAsync(project.Solution, project.Id, diagnosticIds, cancellationToken: cancellationToken).ConfigureAwait(false);
                Contract.ThrowIfFalse(diagnostics.All(d => d.DocumentId == null));
469
                return await diagnostics.ToDiagnosticsAsync(project, cancellationToken).ConfigureAwait(false);
470 471 472
            }
        }

R
Ravi Chande 已提交
473
        private async Task<bool> ContainsAnyFixAsync(
474
            Document document, DiagnosticData diagnostic, CancellationToken cancellationToken)
475
        {
476 477
            var workspaceFixers = ImmutableArray<CodeFixProvider>.Empty;
            var hasAnySharedFixer = _workspaceFixersMap.TryGetValue(document.Project.Language, out var fixerMap) && fixerMap.Value.TryGetValue(diagnostic.Id, out workspaceFixers);
C
CyrusNajmabadi 已提交
478
            var hasAnyProjectFixer = GetProjectFixers(document.Project).TryGetValue(diagnostic.Id, out var projectFixers);
479

480 481 482 483 484 485 486
            // TODO (https://github.com/dotnet/roslyn/issues/4932): Don't restrict CodeFixes in Interactive
            if (hasAnySharedFixer && document.Project.Solution.Workspace.Kind == WorkspaceKind.Interactive)
            {
                workspaceFixers = workspaceFixers.WhereAsArray(IsInteractiveCodeFixProvider);
                hasAnySharedFixer = workspaceFixers.Any();
            }

R
Ravi Chande 已提交
487
            var hasSuppressionFixer =
C
CyrusNajmabadi 已提交
488
                _suppressionProvidersMap.TryGetValue(document.Project.Language, out var lazySuppressionProvider) &&
489 490 491
                lazySuppressionProvider.Value != null;

            if (!hasAnySharedFixer && !hasAnyProjectFixer && !hasSuppressionFixer)
492 493 494 495 496 497 498 499 500 501 502 503 504 505 506
            {
                return false;
            }

            var allFixers = ImmutableArray<CodeFixProvider>.Empty;
            if (hasAnySharedFixer)
            {
                allFixers = workspaceFixers;
            }

            if (hasAnyProjectFixer)
            {
                allFixers = allFixers.AddRange(projectFixers);
            }

507
            var dx = await diagnostic.ToDiagnosticAsync(document.Project, cancellationToken).ConfigureAwait(false);
508

509
            if (hasSuppressionFixer && lazySuppressionProvider.Value.CanBeSuppressedOrUnsuppressed(dx))
510 511 512 513
            {
                return true;
            }

514 515 516 517
            var fixes = new List<CodeFix>();
            var context = new CodeFixContext(document, dx,

                // TODO: Can we share code between similar lambdas that we pass to this API in BatchFixAllProvider.cs, CodeFixService.cs and CodeRefactoringService.cs?
518
                (action, applicableDiagnostics) =>
519 520 521 522
                {
                    // Serialize access for thread safety - we don't know what thread the fix provider will call this delegate from.
                    lock (fixes)
                    {
523
                        fixes.Add(new CodeFix(document.Project, action, applicableDiagnostics));
524 525 526 527 528
                    }
                },
                verifyArguments: false,
                cancellationToken: cancellationToken);

J
Jonathon Marolf 已提交
529 530
            var extensionManager = document.Project.Solution.Workspace.Services.GetService<IExtensionManager>();

531 532 533
            // we do have fixer. now let's see whether it actually can fix it
            foreach (var fixer in allFixers)
            {
534
                await extensionManager.PerformActionAsync(fixer, () => fixer.RegisterCodeFixesAsync(context) ?? Task.CompletedTask).ConfigureAwait(false);
535
                foreach (var fix in fixes)
536
                {
537 538 539 540
                    if (!fix.Action.PerformFinalApplicabilityCheck)
                    {
                        return true;
                    }
541

542 543
                    // Have to see if this fix is still applicable.  Jump to the foreground thread
                    // to make that check.
544
                    await ThreadingContext.JoinableTaskFactory.SwitchToMainThreadAsync(alwaysYield: true, cancellationToken);
545
                    cancellationToken.ThrowIfCancellationRequested();
546 547 548 549

                    var applicable = fix.Action.IsApplicable(document.Project.Solution.Workspace);

                    await TaskScheduler.Default;
550 551 552 553 554 555

                    if (applicable)
                    {
                        return true;
                    }
                }
556 557 558 559 560
            }

            return false;
        }

561 562 563
        private bool IsInteractiveCodeFixProvider(CodeFixProvider provider)
        {
            // TODO (https://github.com/dotnet/roslyn/issues/4932): Don't restrict CodeFixes in Interactive
564 565
            return provider is FullyQualify.AbstractFullyQualifyCodeFixProvider ||
                   provider is AddImport.AbstractAddImportCodeFixProvider;
566 567
        }

568
        private static readonly Func<DiagnosticId, List<CodeFixProvider>> s_createList = _ => new List<CodeFixProvider>();
569

J
Jonathon Marolf 已提交
570
        private ImmutableArray<DiagnosticId> GetFixableDiagnosticIds(CodeFixProvider fixer, IExtensionManager extensionManager)
571
        {
C
Carol Hu 已提交
572
            // If we are passed a null extension manager it means we do not have access to a document so there is nothing to
J
Jonathon Marolf 已提交
573 574 575 576
            // show the user.  In this case we will log any exceptions that occur, but the user will not see them.
            if (extensionManager != null)
            {
                return extensionManager.PerformFunction(
577
                    fixer,
578
                    () => ImmutableInterlocked.GetOrAdd(ref _fixerToFixableIdsMap, fixer, f => GetAndTestFixableDiagnosticIds(f)),
S
Shyam N 已提交
579
                    defaultValue: ImmutableArray<DiagnosticId>.Empty);
J
Jonathon Marolf 已提交
580 581 582 583
            }

            try
            {
584
                return ImmutableInterlocked.GetOrAdd(ref _fixerToFixableIdsMap, fixer, f => GetAndTestFixableDiagnosticIds(f));
J
Jonathon Marolf 已提交
585 586 587 588 589 590 591
            }
            catch (OperationCanceledException)
            {
                throw;
            }
            catch (Exception e)
            {
J
Jonathon Marolf 已提交
592 593
                foreach (var logger in _errorLoggers)
                {
594
                    logger.Value.LogException(fixer, e);
J
Jonathon Marolf 已提交
595
                }
J
Jonathon Marolf 已提交
596 597
                return ImmutableArray<DiagnosticId>.Empty;
            }
598 599
        }

600 601 602 603 604 605 606
        private static ImmutableArray<string> GetAndTestFixableDiagnosticIds(CodeFixProvider codeFixProvider)
        {
            var ids = codeFixProvider.FixableDiagnosticIds;
            if (ids.IsDefault)
            {
                throw new InvalidOperationException(
                    string.Format(
607
                        WorkspacesResources._0_returned_an_uninitialized_ImmutableArray,
608
                        codeFixProvider.GetType().Name + "." + nameof(CodeFixProvider.FixableDiagnosticIds)));
609 610 611 612 613
            }

            return ids;
        }

614
        private ImmutableDictionary<LanguageKind, Lazy<ImmutableDictionary<DiagnosticId, ImmutableArray<CodeFixProvider>>>> GetFixerPerLanguageMap(
J
Jonathon Marolf 已提交
615 616
            Dictionary<LanguageKind, List<Lazy<CodeFixProvider, CodeChangeProviderMetadata>>> fixersPerLanguage,
            IExtensionManager extensionManager)
617 618 619 620 621 622 623 624 625 626
        {
            var fixerMap = ImmutableDictionary.Create<LanguageKind, Lazy<ImmutableDictionary<DiagnosticId, ImmutableArray<CodeFixProvider>>>>();
            foreach (var languageKindAndFixers in fixersPerLanguage)
            {
                var lazyMap = new Lazy<ImmutableDictionary<DiagnosticId, ImmutableArray<CodeFixProvider>>>(() =>
                {
                    var mutableMap = new Dictionary<DiagnosticId, List<CodeFixProvider>>();

                    foreach (var fixer in languageKindAndFixers.Value)
                    {
J
Jonathon Marolf 已提交
627
                        foreach (var id in this.GetFixableDiagnosticIds(fixer.Value, extensionManager))
628 629 630 631 632 633
                        {
                            if (string.IsNullOrWhiteSpace(id))
                            {
                                continue;
                            }

634
                            var list = mutableMap.GetOrAdd(id, s_createList);
635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653
                            list.Add(fixer.Value);
                        }
                    }

                    var immutableMap = ImmutableDictionary.CreateBuilder<DiagnosticId, ImmutableArray<CodeFixProvider>>();
                    foreach (var diagnosticIdAndFixers in mutableMap)
                    {
                        immutableMap.Add(diagnosticIdAndFixers.Key, diagnosticIdAndFixers.Value.AsImmutableOrEmpty());
                    }

                    return immutableMap.ToImmutable();
                }, isThreadSafe: true);

                fixerMap = fixerMap.Add(languageKindAndFixers.Key, lazyMap);
            }

            return fixerMap;
        }

A
Andrew Casey 已提交
654
        private static ImmutableDictionary<LanguageKind, Lazy<ISuppressionFixProvider>> GetSuppressionProvidersPerLanguageMap(
655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693
            Dictionary<LanguageKind, List<Lazy<ISuppressionFixProvider, CodeChangeProviderMetadata>>> suppressionProvidersPerLanguage)
        {
            var suppressionFixerMap = ImmutableDictionary.Create<LanguageKind, Lazy<ISuppressionFixProvider>>();
            foreach (var languageKindAndFixers in suppressionProvidersPerLanguage)
            {
                var suppressionFixerLazyMap = new Lazy<ISuppressionFixProvider>(() => languageKindAndFixers.Value.SingleOrDefault().Value);
                suppressionFixerMap = suppressionFixerMap.Add(languageKindAndFixers.Key, suppressionFixerLazyMap);
            }

            return suppressionFixerMap;
        }

        private static ImmutableDictionary<LanguageKind, Lazy<ImmutableDictionary<CodeFixProvider, int>>> GetFixerPriorityPerLanguageMap(
            Dictionary<LanguageKind, List<Lazy<CodeFixProvider, CodeChangeProviderMetadata>>> fixersPerLanguage)
        {
            var languageMap = ImmutableDictionary.CreateBuilder<LanguageKind, Lazy<ImmutableDictionary<CodeFixProvider, int>>>();
            foreach (var languageAndFixers in fixersPerLanguage)
            {
                var lazyMap = new Lazy<ImmutableDictionary<CodeFixProvider, int>>(() =>
                {
                    var priorityMap = ImmutableDictionary.CreateBuilder<CodeFixProvider, int>();

                    var fixers = ExtensionOrderer.Order(languageAndFixers.Value);
                    for (var i = 0; i < fixers.Count; i++)
                    {
                        priorityMap.Add(fixers[i].Value, i);
                    }

                    return priorityMap.ToImmutable();
                }, isThreadSafe: true);

                languageMap.Add(languageAndFixers.Key, lazyMap);
            }

            return languageMap.ToImmutable();
        }

        private ImmutableDictionary<DiagnosticId, List<CodeFixProvider>> GetProjectFixers(Project project)
        {
694 695
            // TODO (https://github.com/dotnet/roslyn/issues/4932): Don't restrict CodeFixes in Interactive
            return project.Solution.Workspace.Kind == WorkspaceKind.Interactive
H
Heejae Chang 已提交
696
                ? ImmutableDictionary<DiagnosticId, List<CodeFixProvider>>.Empty
697
                : _projectFixersMap.GetValue(project.AnalyzerReferences, pId => ComputeProjectFixers(project));
698 699 700 701
        }

        private ImmutableDictionary<DiagnosticId, List<CodeFixProvider>> ComputeProjectFixers(Project project)
        {
J
Jonathon Marolf 已提交
702
            var extensionManager = project.Solution.Workspace.Services.GetService<IExtensionManager>();
703 704 705
            ImmutableDictionary<DiagnosticId, List<CodeFixProvider>>.Builder builder = null;
            foreach (var reference in project.AnalyzerReferences)
            {
706
                var projectCodeFixerProvider = _analyzerReferenceToFixersMap.GetValue(reference, _createProjectCodeFixProvider);
707 708
                foreach (var fixer in projectCodeFixerProvider.GetFixers(project.Language))
                {
J
Jonathon Marolf 已提交
709
                    var fixableIds = this.GetFixableDiagnosticIds(fixer, extensionManager);
710 711 712 713 714 715 716 717
                    foreach (var id in fixableIds)
                    {
                        if (string.IsNullOrWhiteSpace(id))
                        {
                            continue;
                        }

                        builder = builder ?? ImmutableDictionary.CreateBuilder<DiagnosticId, List<CodeFixProvider>>();
718
                        var list = builder.GetOrAdd(id, s_createList);
719 720 721 722 723 724 725 726 727 728 729 730 731 732
                        list.Add(fixer);
                    }
                }
            }

            if (builder == null)
            {
                return ImmutableDictionary<DiagnosticId, List<CodeFixProvider>>.Empty;
            }

            return builder.ToImmutable();
        }
    }
}