1. 12 6月, 2014 12 次提交
  2. 11 6月, 2014 25 次提交
  3. 10 6月, 2014 3 次提交
    • D
      Merge branch 'fix-email-threading' into 'master' · 97fd990e
      Dmitriy Zaporozhets 提交于
      Fix broken email threading
      
      The email threading support introduced in GitLab CE 6.9 is broken on several popular email clients (including Mail.app and Airmail on Mac OS X).
      
      This MR makes the following changes to improve email threading compatibility:
      
      * Subject of answers to an existing thread begins with `Re: ` (required by Mail.app)
      * The recipient of every email in a thread is stable (required by Mail.app ; otherwise it groups emails by sender)
      * Send a ‘In-Reply-To’ header along the ‘References’ header (for compatibility with the spec)
      
      In order to do this, these commits:
      
      * Change the `To:` field to `namespace/project` ; the actual receiver is now in the `Cc:` field.
      * Introduce the `mail_new_thread` and `mail_answer_thread` methods ; they format the message correctly for threading, and can generate the `Message-ID` automatically from a model instance.
      * Refactor the tests to shared behaviors for email threading.
      
      We've been using these patches at @capitainetrain for a few months now ; I just ported them to work nicely with the recent threading commits.
      97fd990e
    • P
      Allow more mail clients to group emails by thread · de90b572
      Pierre de La Morinerie 提交于
      * send a ‘In-Reply-To’ header along the ‘References’ header
      * subject of answers to an existing thread begins with ‘Re: ’
      
      This fixes threading with at least Mail.app and Airmail.
      de90b572
    • P
      Send notification emails to the "project", and put people in Cc · 466b768b
      Pierre de La Morinerie 提交于
      This fixes email threading in Mail.app, that doesn't like when a thread
      doesn't have stable recipients.
      
      For instance, here is a possible sender-recipient combinations before:
      
      From: A
      To: Me
      New issue
      
      From: B
      To: Me
      Reply on new issue
      
      From: A
      To: Me
      Another reply
      
      Mail.app doesn't see B as a participant to the original email thread,
      and decides to break the thread: it will group all messages from A
      together, and separately all messages from B.
      
      This commit makes the thread look like this:
      
      From: A
      To: gitlab/project
      Cc: Me
      New issue
      
      From: B
      To: gitlab/project
      Cc: Me
      Reply on new issue
      
      From: A
      To: gitlab/project
      Cc: Me
      Another reply
      
      Mail.app sees a common recipient, and group the thread correctly.
      466b768b