- 21 11月, 2017 2 次提交
-
-
由 Zeger-Jan van de Weg 提交于
After installing a new gem, batch-loader, a construct can be used to queue data to be fetched in bulk. The gem was also introduced in both gitlab-org/gitlab-ce!14680 and gitlab-org/gitlab-ce!14846, but those mrs are not merged yet. For the generation of diffs, both the old blob and the new blob need to be loaded. This for every file in the diff, too. Now we collect all these so we do 1 fetch. Three `.allow_n_plus_1_calls` have been removed, which I expect to be valid, but this needs to be confirmed by a full CI run. Possibly closes: - https://gitlab.com/gitlab-org/gitlab-ce/issues/37445 - https://gitlab.com/gitlab-org/gitlab-ce/issues/37599 - https://gitlab.com/gitlab-org/gitlab-ce/issues/37431
-
由 Nick Thomas 提交于
-
- 20 11月, 2017 3 次提交
-
-
由 Bob Van Landuyt 提交于
When a project is using hashed storage, the repositories and attachments wouldn't be saved on disk using the `full_path`. So the migration would not do anything. However: best to just skip moving when hashed storage is enabled.
-
由 Yorick Peterse 提交于
This adds various foreign keys and indexes to the "merge_requests" table as outlined in https://gitlab.com/gitlab-org/gitlab-ce/issues/31825. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/31825
-
由 Alejandro Rodríguez 提交于
-
- 18 11月, 2017 2 次提交
-
-
由 Alejandro Rodríguez 提交于
-
由 Sean McGivern 提交于
Conflicts used to take a `Repository` and pass that to `Gitlab::Highlight.highlight`, which would call `#gitattribute` on the repository. Now they use a `Gitlab::Git::Repository`, which didn't have that method defined - but defining it on `Gitlab::Git::Repository` does make it available on `Repository` through `method_missing`, so we can do that and both cases will work.
-
- 17 11月, 2017 10 次提交
-
-
由 Francisco Javier López 提交于
-
由 Francisco Lopez 提交于
-
由 Douwe Maan 提交于
-
由 Stan Hu 提交于
This is to smear updates over a few hours to avoid causing excessive replication lag as seen in https://gitlab.com/gitlab-com/infrastructure/issues/3235.
-
由 Francisco Lopez 提交于
-
由 Francisco Lopez 提交于
-
由 Francisco Lopez 提交于
-
由 Francisco Lopez 提交于
-
由 Francisco Lopez 提交于
-
由 Jacopo 提交于
Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses.
-
- 16 11月, 2017 1 次提交
-
-
由 Grzegorz Bizon 提交于
We should allow to use double underscore in the path, and it seems that our container repository path regexp was outdated. See https://github.com/docker/distribution/blob/master/reference/regexp.go
-
- 15 11月, 2017 2 次提交
-
-
由 Rémy Coutable 提交于
Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 Bob Van Landuyt 提交于
Before the `PopulateForkNetworksRange` spec would also call the `CreateForkNetworkMemberships` which we would count on in the spec. With this, I'm isolating that, and counting only records created in this particular migration instead.
-
- 14 11月, 2017 3 次提交
-
-
由 Bob Van Landuyt 提交于
In case the root project of a Fork-of-fork is deleted, the ForkNetwork and the membership for that fork network is never created. In this case we shouldn't try to create the membership, since the parent membership will never be created. This means that these fork networks will be lost.
-
由 Alejandro Rodríguez 提交于
-
由 Alejandro Rodríguez 提交于
-
- 13 11月, 2017 1 次提交
-
-
由 Lin Jen-Shin (godfat) 提交于
-
- 10 11月, 2017 2 次提交
-
-
由 Jacob Vosmaer (GitLab) 提交于
-
由 Yorick Peterse 提交于
This adds various foreign key constraints, indexes, missing NOT NULL constraints, and changes some column types from timestamp to timestamptz. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/31811
-
- 09 11月, 2017 6 次提交
-
-
由 James Edwards-Jones 提交于
-
由 Douwe Maan 提交于
Replace SSRF resolver with Addrinfo.getaddrinfo to include alternative localhost versions See merge request gitlab/gitlabhq!2219 (cherry picked from commit 4a1e7378) 1bffa0c3 Replace SSRF resolver with Addrinfo.getaddrinfo to include alternative localhost versions
-
由 micael.bergeron 提交于
This reverts commit d5859bb9. This reverts commit 2b7e03cf. This reverts commit 7799a9bc.
-
由 Yorick Peterse 提交于
GitHub Enterprise disables rate limiting for the API, resulting in HTTP 404 errors when requesting rate limiting details. This changes Gitlab::GithubImport::Client so it can deal with rate limiting being disabled.
-
由 Yorick Peterse 提交于
This was removed by accident as the old GitHub importer handled this deep down the codebase, making it easy to miss.
-
由 Stan Hu 提交于
-
- 08 11月, 2017 8 次提交
-
-
由 James Edwards-Jones 提交于
-
由 Yorick Peterse 提交于
-
由 Yorick Peterse 提交于
Prior to this MR there were two GitHub related importers: * Github::Import: the main importer used for GitHub projects * Gitlab::GithubImport: importer that's somewhat confusingly used for importing Gitea projects (apparently they have a compatible API) This MR renames the Gitea importer to Gitlab::LegacyGithubImport and introduces a new GitHub importer in the Gitlab::GithubImport namespace. This new GitHub importer uses Sidekiq for importing multiple resources in parallel, though it also has the ability to import data sequentially should this be necessary. The new code is spread across the following directories: * lib/gitlab/github_import: this directory contains most of the importer code such as the classes used for importing resources. * app/workers/gitlab/github_import: this directory contains the Sidekiq workers, most of which simply use the code from the directory above. * app/workers/concerns/gitlab/github_import: this directory provides a few modules that are included in every GitHub importer worker. == Stages The import work is divided into separate stages, with each stage importing a specific set of data. Stages will schedule the work that needs to be performed, followed by scheduling a job for the "AdvanceStageWorker" worker. This worker will periodically check if all work is completed and schedule the next stage if this is the case. If work is not yet completed this worker will reschedule itself. Using this approach we don't have to block threads by calling `sleep()`, as doing so for large projects could block the thread from doing any work for many hours. == Retrying Work Workers will reschedule themselves whenever necessary. For example, hitting the GitHub API's rate limit will result in jobs rescheduling themselves. These jobs are not processed until the rate limit has been reset. == User Lookups Part of the importing process involves looking up user details in the GitHub API so we can map them to GitLab users. The old importer used an in-memory cache, but this obviously doesn't work when the work is spread across different threads. The new importer uses a Redis cache and makes sure we only perform API/database calls if absolutely necessary. Frequently used keys are refreshed, and lookup misses are also cached; removing the need for performing API/database calls if we know we don't have the data we're looking for. == Performance & Models The new importer in various places uses raw INSERT statements (as generated by `Gitlab::Database.bulk_insert`) instead of using Rails models. This allows us to bypass any validations and callbacks, drastically reducing the number of SQL queries and Gitaly RPC calls necessary to import projects. To ensure the code produces valid data the corresponding tests check if the produced rows are valid according to the model validation rules.
-
由 Yorick Peterse 提交于
The GitHub importer (and probably other parts of our code) ends up calling Feature.persisted? many times (via Gitaly). By storing this data in RequestStore we can save ourselves _a lot_ of database queries. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/39361
-
由 Yorick Peterse 提交于
This adds the keyword argument "return_ids" to Gitlab::Database.bulk_insert. When set to `true` (and PostgreSQL is used) this method will return an Array of the IDs of the inserted rows, otherwise it will return an empty Array.
-
由 James Lopez 提交于
-
由 Bob Van Landuyt 提交于
-
由 Bob Van Landuyt 提交于
-