- 20 6月, 2017 5 次提交
-
-
由 Winnie Hellmann 提交于
-
由 Eric Eastwood 提交于
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/33594 Was supposedly fixed in MR for https://gitlab.com/gitlab-org/gitlab-ce/issues/32086 but seeing this pop up again
-
-
由 Stan Hu 提交于
If migrations are pending, make CurrentSettings use existing values and populate missing columns with defaults master was failing because `ApplicationSetting.create_from_defaults` attempted to write to a column that did not exist in the database. This occurred in a `rake db:migrate` task, which was unable to perform the migration that would have added the missing column in the first place. In 9.3 RC2, we also had a bug where password sign-ins were disabled because there were many pending migrations. The problem occurred because `fake_application_settings` was being returned with an OpenStruct that did not include the predicate method `signup_enabled?`. As a result, the value would erroneously return `nil` instead of `true`. This commit uses the values of the defaults to mimic this behavior. This commit also refactors some of the logic to be clearer.
-
由 Douwe Maan 提交于
-
- 19 6月, 2017 2 次提交
-
-
由 Tiago Botelho 提交于
-
由 Kyle Bishop 提交于
-
- 17 6月, 2017 11 次提交
-
-
由 Michael Kozono 提交于
This test and its context exist only to ensure this behavior is fixed: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11259#note_29262426
-
由 Michael Kozono 提交于
-
由 Michael Kozono 提交于
-
由 vanadium23 提交于
-
由 Mike Greiling 提交于
-
由 Felipe Artur 提交于
-
由 Felipe Artur 提交于
-
由 David Turner 提交于
Submodules have a name in the configuration, but this name is simply the path at which the submodule was initially checked in (by default -- the name is totally arbitrary). If a submodule is moved, it retains its original name, but its path changes. Since we discover submodules inside trees, we have their path but not necessarily their name. Make the submodules() function return the submodule hash indexed by path rather than name, so that renamed submodules can be looked up. Signed-off-by: NDavid Turner <novalis@novalis.org>
-
由 Tiago Botelho 提交于
-
由 Sean McGivern 提交于
This adds an ID-less table containing one row per file, per merge request diff. It has a column for each attribute on Gitlab::Git::Diff that is serialised currently, with the advantage that we can easily query the attributes of this new table. It does not migrate existing data, so we have fallback code when the legacy st_diffs column is present instead. For a merge request diff to be valid, it should have at most one of: * Rows in this new table, with the correct merge_request_diff_id. * A non-NULL st_diffs column. It may have neither, if the diff is empty.
-
由 Phil Hughes 提交于
Closes #33614
-
- 16 6月, 2017 12 次提交
-
-
由 Rémy Coutable 提交于
capybara/rspec already calls Capybara.reset_sessions! in an `after` hook, but `block_and_wait_for_requests_complete` is called before it so by calling it explicitely here, we prevent any new requests from being fired. See https://github.com/teamcapybara/capybara/blob/ffb41cfad620de1961bb49b1562a9fa9b28c0903/lib/capybara/rspec.rb#L20-L25Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 Felipe Artur 提交于
-
由 Felipe Artur 提交于
-
由 Felipe Artur 提交于
-
由 Annabel Dunstone Gray 提交于
-
由 Alfredo Sumaran 提交于
-
由 Stan Hu 提交于
The spec was trying to sort pipelines by user ID, but the same user ID was being used for each pipeline in the spec. This is similar to #33001.
-
由 Stan Hu 提交于
-
由 Stan Hu 提交于
-
由 Stan Hu 提交于
From logs in #33756, we that it's possible for an Ajax call to be made before the middleware receives it. To prevent stray Ajax calls from breaking other specs, we need to wait for all scheduled calls to finish. Closes #33756
-
由 Mike Greiling 提交于
-
由 Rémy Coutable 提交于
Signed-off-by: NRémy Coutable <remy@rymai.me>
-
- 15 6月, 2017 10 次提交
-
-
由 Bob Van Landuyt 提交于
-
由 Sean McGivern 提交于
Create a post-deployment migration to update all existing notification settings with at least one custom level enabled to the new format. Also handle the same conversion when updating settings, to catch any stragglers.
-
由 Sean McGivern 提交于
Add columns for each custom notification level, defaulting to null. Read from those columns if non-null, otherwise fall back to the serialized column. Writing will write to the new column if `events` isn't manually set.
-
由 Eric Eastwood 提交于
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/27070 Deprecate "chat commands" in favor of "slash commands" We looked for things like: - `slash commmand` - `slash_command` - `slash-command` - `SlashCommand`
-
由 Mike Ricketts 提交于
-
由 Riccardo Padovani 提交于
-
由 Grzegorz Bizon 提交于
-
由 Toon Claes 提交于
Ensure the results match exactly and project authorizations do allow access to sibling groups/projects deeper down. Also apply WHERE scopes before running the UNION, to increase performance.
-
由 Toon Claes 提交于
When a user is authorized to a group, they are also authorized to see all the ancestor groups and descendant groups. When a user is authorized to a project, they are authorized to see all the ancestor groups too. Closes #32135 See merge request !11764
-
由 Stan Hu 提交于
-