- 25 1月, 2017 1 次提交
-
-
由 Yorick Peterse 提交于
There were two cases that could be problematic: 1. Because sometimes AuthorizedProjectsWorker would be scheduled in a transaction it was possible for a job to run/complete before a COMMIT; resulting in it either producing an error, or producing no new data. 2. When scheduling jobs the code would not wait until completion. This could lead to a user creating a project and then immediately trying to push to it. Usually this will work fine, but given enough load it might take a few seconds before a user has access. The first one is problematic, the second one is mostly just annoying (but annoying enough to warrant a solution). This commit changes two things to deal with this: 1. Sidekiq scheduling now takes places after a COMMIT, this is ensured by scheduling using Rails' after_commit hook instead of doing so in an arbitrary method. 2. When scheduling jobs the calling thread now waits for all jobs to complete. Solution 2 requires tracking of job completions. Sidekiq provides a way to find a job by its ID, but this involves scanning over the entire queue; something that is very in-efficient for large queues. As such a more efficient solution is necessary. There are two main Gems that can do this in a more efficient manner: * sidekiq-status * sidekiq_status No, this is not a joke. Both Gems do a similar thing (but slightly different), and the only difference in their name is a dash vs an underscore. Both Gems however provide far more than just checking if a job has been completed, and both have their problems. sidekiq-status does not appear to be actively maintained, with the last release being in 2015. It also has some issues during testing as API calls are not stubbed in any way. sidekiq_status on the other hand does not appear to be very popular, and introduces a similar amount of code. Because of this I opted to write a simple home grown solution. After all, all we need is storing a job ID somewhere so we can efficiently look it up; we don't need extra web UIs (as provided by sidekiq-status) or complex APIs to update progress, etc. This is where Gitlab::SidekiqStatus comes in handy. This namespace contains some code used for tracking, removing, and looking up job IDs; all without having to scan over an entire queue. Data is removed explicitly, but also expires automatically just in case. Using this API we can now schedule jobs in a fork-join like manner: we schedule the jobs in Sidekiq, process them in parallel, then wait for completion. By using Sidekiq we can leverage all the benefits such as being able to scale across multiple cores and hosts, retrying failed jobs, etc. The one downside is that we need to make sure we can deal with unexpected increases in job processing timings. To deal with this the class Gitlab::JobWaiter (used for waiting for jobs to complete) will only wait a number of seconds (30 by default). Once this timeout is reached it will simply return. For GitLab.com almost all AuthorizedProjectWorker jobs complete in seconds, only very rarely do we spike to job timings of around a minute. These in turn seem to be the result of external factors (e.g. deploys), in which case a user is most likely not able to use the system anyway. In short, this new solution should ensure that jobs are processed properly and that in almost all cases a user has access to their resources whenever they need to have access.
-
- 24 1月, 2017 1 次提交
-
-
由 Robert Speicher 提交于
Upgrade OmniAuth Ruby gem to 1.3.2 Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/26813 See merge request !2056
-
- 19 1月, 2017 2 次提交
-
-
由 Robert Speicher 提交于
This reverts commit e7fdb1aa, reversing changes made to 78d71038. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/26762
-
由 Brian Neel 提交于
-
- 17 1月, 2017 5 次提交
-
-
由 Richard Macklin 提交于
Closes #18432 This uses sassc to compile the application's SASS so it compiles faster. Without attempting to be very scientific here are some numbers I got: Using sassc-rails: ``` [1] pry(main)> Benchmark.bm { |bm| bm.report { Rails.application.assets["application.css"] } } user system total real 1.430000 0.380000 1.810000 ( 1.830753) ``` Using sass-rails: ``` [1] pry(main)> Benchmark.bm { |bm| bm.report { Rails.application.assets["application.css"] } } user system total real 12.320000 0.530000 12.850000 ( 12.909684) ``` The result is faster page loads when changing CSS in development and faster precompilation.
-
由 Rémy Coutable 提交于
Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 Rémy Coutable 提交于
Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 Eric Eastwood 提交于
-
由 Eric Eastwood 提交于
-
- 12 1月, 2017 1 次提交
-
-
由 Horacio Sanson 提交于
This MR enables rendering of PlantUML diagrams in Asciidoc documents. To add a PlantUML diagram all we need is to include a plantuml block like: ``` [plantuml, id="myDiagram", width="100px", height="100px"] -- bob -> alice : ping alice -> bob : pong -- ``` The plantuml block is substituted by an HTML img element with *src* pointing to an external PlantUML server. This MR also add a PlantUML integration section to the Administrator -> Settings page to configure the PlantUML rendering service and to enable/disable it. Closes: #17603
-
- 11 1月, 2017 1 次提交
-
-
由 Robert Speicher 提交于
Updated Turbolinks to patched version of turbolinks-classic See https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2048
-
- 10 1月, 2017 2 次提交
-
-
由 Grzegorz Bizon 提交于
-
-
- 07 1月, 2017 2 次提交
-
-
由 Brian Neel 提交于
-
由 Rémy Coutable 提交于
Signed-off-by: NRémy Coutable <remy@rymai.me>
-
- 05 1月, 2017 1 次提交
-
-
由 Robert Speicher 提交于
-
- 03 1月, 2017 1 次提交
-
-
由 Yorick Peterse 提交于
MR https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8158 updated the octokit Gem but did not include all the changes for Gemfile.lock.
-
- 30 12月, 2016 1 次提交
-
-
由 Manuel Rüger 提交于
ChangeLog: https://github.com/octokit/octokit.rb/releases
-
- 27 12月, 2016 1 次提交
-
-
由 Chris Wilson 提交于
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/26114 vmstat 2.3.0 fixes an issue with reporting the incorrect # of CPUs. This is used in the GitLab Admin Dashboard.
-
- 22 12月, 2016 1 次提交
-
-
由 http://jneen.net/ 提交于
-
- 21 12月, 2016 1 次提交
-
-
由 Alex 提交于
-
- 17 12月, 2016 1 次提交
-
-
由 Z.J. van de Weg 提交于
-
- 15 12月, 2016 1 次提交
-
-
由 Nick Thomas 提交于
-
- 14 12月, 2016 1 次提交
-
-
由 Robert Schilling 提交于
-
- 12 12月, 2016 1 次提交
-
-
由 Connor Shea 提交于
Includes various bug fixes, mostly for Rails 5. Changelog: https://github.com/mperham/sidekiq/blob/fc168fe393bee3ad1fcbb52cff2d84af86c38cc4/Changes.md
-
- 08 12月, 2016 1 次提交
-
-
由 Robert Speicher 提交于
-
- 05 12月, 2016 2 次提交
-
-
-
由 Connor Shea 提交于
Includes support for Rails 5. Changelog: https://github.com/rubysherpas/paranoia/blob/879fd18caa46af70fceca2e8f46886b3eff072ec/CHANGELOG.md#220-2016-10-21
-
- 30 11月, 2016 1 次提交
-
-
由 Stan Hu 提交于
Somehow `bundle install` with an update to Sidekiq-cron caused rufus-scheduler to be bumped, when it doesn't appear absolutely necessary. Closes #25160
-
- 29 11月, 2016 2 次提交
-
-
由 Nick Thomas 提交于
-
由 Stan Hu 提交于
The "Enqueue Now" button would not work in the admin panel due to changes in the Web extension interface. Closes #24376
-
- 24 11月, 2016 1 次提交
-
-
由 Rémy Coutable 提交于
The amount of gems required is quite high compared to the usefulness of the features. Related to !4928, !6713 Signed-off-by: NRémy Coutable <remy@rymai.me>
-
- 23 11月, 2016 1 次提交
-
-
由 Z.J. van de Weg 提交于
-
- 22 11月, 2016 1 次提交
-
-
- 21 11月, 2016 1 次提交
-
-
由 Z.J. van de Weg 提交于
Fixes gitlab-org/gitlab-ce#14329
-
- 18 11月, 2016 1 次提交
-
-
由 http://jneen.net/ 提交于
CHANGELOG: https://github.com/jneen/rouge/blob/v2.0.7/CHANGELOG.md
-
- 17 11月, 2016 3 次提交
-
-
由 Robert Speicher 提交于
-
由 Robert Speicher 提交于
We use the Redis-backed session store from `redis-store` so this is unnecessary.
-
由 http://jneen.net/ 提交于
-
- 11 11月, 2016 1 次提交
-
-
由 Patricio Cano 提交于
-