- 20 7月, 2016 1 次提交
-
-
由 Grzegorz Bizon 提交于
Avoid multi-line ?: (the ternary operator). Use if/unless instead. See #17478
-
- 19 7月, 2016 1 次提交
-
-
由 Grzegorz Bizon 提交于
This enables following cops: Check for useless access modifiers Lint/UselessAccessModifier Checks for attempts to use `private` or `protected` to set the visibility of a class method, which does not work. Lint/IneffectiveAccessModifier This also disables two false possitives in concerns.
-
- 14 7月, 2016 3 次提交
-
-
由 Connor Shea 提交于
-
由 Connor Shea 提交于
-
- 08 7月, 2016 1 次提交
-
-
由 Grzegorz Bizon 提交于
-
- 02 7月, 2016 1 次提交
-
-
由 Grzegorz Bizon 提交于
-
- 30 6月, 2016 1 次提交
-
-
由 Grzegorz Bizon 提交于
-
- 29 6月, 2016 3 次提交
-
-
由 Grzegorz Bizon 提交于
-
由 Grzegorz Bizon 提交于
-
由 Yorick Peterse 提交于
There are currently two cops for this: * Migration/AddIndex: checks if indexes are added concurrently * Migration/ColumnWithDefault: checks if columns with default values are added in a concurrent manner Both cops are fairly simple and make no attempt at correcting the code as this is quite hard to do (e.g. modifications may need to be applied in various places in the same file). They however should provide enough to catch people ignoring the comments in generated migrations telling them to use add_concurrent_index or add_column_with_default.
-
- 16 6月, 2016 2 次提交
-
-
由 James Lopez 提交于
This reverts commit 13e37a3e.
-
由 James Lopez 提交于
-
- 10 6月, 2016 1 次提交
-
-
由 Grzegorz Bizon 提交于
See #17478
-
- 09 6月, 2016 1 次提交
-
-
由 Sean McGivern 提交于
Migrations shouldn't fail RuboCop checks - especially lint checks, such as the nested method check. To avoid changing code in existing migrations, add the magic comment to the top of each of them to skip that file.
-
- 05 6月, 2016 1 次提交
-
-
由 Grzegorz Bizon 提交于
-
- 03 6月, 2016 4 次提交
-
-
由 James Lopez 提交于
This reverts commit 3e991230.
-
由 Grzegorz Bizon 提交于
See #17478
-
由 James Lopez 提交于
# Conflicts: # app/models/project.rb
-
由 Grzegorz Bizon 提交于
See #17478
-
- 01 6月, 2016 3 次提交
-
-
由 Grzegorz Bizon 提交于
Do not use for, unless you know exactly why. See #17478
-
由 Grzegorz Bizon 提交于
See #17478
-
由 Felipe Artur 提交于
-
- 30 5月, 2016 13 次提交
-
-
由 Grzegorz Bizon 提交于
See #17478
-
由 Grzegorz Bizon 提交于
No spaces before commas. See #17478
-
由 Grzegorz Bizon 提交于
See #17478
-
由 Grzegorz Bizon 提交于
See #17478
-
由 Grzegorz Bizon 提交于
Use Array.new with a block instead of `.times.collect` / `.times.map`. See #17478
-
由 Grzegorz Bizon 提交于
Favor `unless` over `if` for negative conditions (or control flow ||). See #17478
-
由 Grzegorz Bizon 提交于
Checks of literals used in conditions. See #17478
-
由 Grzegorz Bizon 提交于
Do not use then for multi-line if. See #7478.
-
由 Grzegorz Bizon 提交于
Use def with parentheses when there are parameters. See #17478
-
由 Grzegorz Bizon 提交于
See #17478
-
由 Grzegorz Bizon 提交于
See #17478
-
由 Grzegorz Bizon 提交于
Use Unix-style line endings. See #17478.
-
由 Grzegorz Bizon 提交于
See #17478
-
- 26 5月, 2016 1 次提交
-
-
由 Robert Speicher 提交于
[ci skip]
-
- 25 5月, 2016 2 次提交
-
-
由 Grzegorz Bizon 提交于
Closes #17406
-
由 Robert Speicher 提交于
Also removes the note from the development/testing.md guide
-
- 24 5月, 2016 1 次提交
-
-
由 Robert Speicher 提交于
[ci skip]
-