- 18 4月, 2019 1 次提交
-
-
由 Paul Gascou-Vaillancourt 提交于
- Created DiscussionActions component - Updated NoteableDiscussion component accordingly - Wrote Jest tests for DiscussionActions - Updated Jest config to enable emojis aliases mock - Updated qa specs to reflect changes in NoteableDiscussions
-
- 26 3月, 2019 1 次提交
-
-
由 Heinrich Lee Yu 提交于
Makes discussion expansion depend on `discussion.expanded`
-
- 22 3月, 2019 2 次提交
-
-
由 Winnie Hellmann 提交于
-
由 Winnie Hellmann 提交于
-
- 12 3月, 2019 1 次提交
-
-
由 Winnie Hellmann 提交于
-
- 28 2月, 2019 1 次提交
-
-
由 Phil Hughes 提交于
-
- 26 2月, 2019 1 次提交
-
-
由 Winnie Hellmann 提交于
-
- 18 2月, 2019 2 次提交
-
-
由 Winnie Hellmann 提交于
Move convertToDiscussion call from ReplyButton to NoteApp component
-
由 Constance Okoghenun 提交于
When converting a comment to a discussion if the "Cancel" button is used to exit the new discussion note, the comment would revert back to its initial state
-
- 14 2月, 2019 1 次提交
-
-
由 Heinrich Lee Yu 提交于
Sets `updated_at` so that the transformed note is returned together with the new reply
-
- 12 2月, 2019 1 次提交
-
-
由 Mark Florian 提交于
The header of the `NoteableDiscussion` component is really a media object[1], but it didn't have the right DOM or styling to correctly achieve it. This change wraps all the children of the media object (except the floated image) in a dedicated `.timeline-content` element, which is styled to establish its own block formatting context[2]. This ensures *all* of its children sit left-aligned to the right edge of the float. In short, the DOM used to look like this: .discussion-header .timeline-icon note-header note-edited-text and now it looks like this: .discussion-header .timeline-icon .timeline-content (with own formatting context) note-header note-edited-text This is also now more consistent with the DOM of `NoteableNote`, in that `.timeline-icon` and `.timeline-content` seem to want to be siblings. [1]: http://www.stubbornella.org/content/2010/06/25/the-media-object-saves-hundreds-of-lines-of-code/ [2]: https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Block_formatting_context
-
- 06 2月, 2019 1 次提交
-
-
由 Heinrich Lee Yu 提交于
-
- 05 2月, 2019 1 次提交
-
-
由 Winnie Hellmann 提交于
-
- 29 1月, 2019 1 次提交
-
-
由 Martin Hobert 提交于
-
- 28 1月, 2019 1 次提交
-
-
由 Martin Hobert 提交于
fix #56369 chore(changelog): Added changelog entry chore(prettier): Formated with prettier test(JumpToNextDiscussionButton): Added test for new component test(Refactored tests to use vue test-utils): chore(translations): Added newly generated locales Update spec/javascripts/notes/components/discussion_jump_to_next_button_spec.js chore(prettier): Formated with prettier test(JumpToNextDiscussionButton): Updated tests to use a local vue instance test(JumpToNextDiscussionButton): Running tests in async to prevent maximum stack overflow
-
- 23 1月, 2019 1 次提交
-
-
由 Douwe Maan 提交于
Before, diff file `higlighted_diff_lines`/`parallel_diff_lines` and diff discussion `truncated_diff_lines` were inconsistent: `text` and `rich_text` on the latter included the leading +/-/<space> character, like on the backend, while the former had no `text` and its `rich_text` had dropped this char. This resulted in a bug when the suggestions feature expected these diff line objects to be identical in format and thus interchangeable, which was not the case.
-
- 17 1月, 2019 1 次提交
-
-
由 Constance Okoghenun 提交于
Add commit prop to NoteableNote component and pass it from NoteableDiscussion
-
- 15 1月, 2019 1 次提交
-
-
由 Mike Greiling 提交于
Upgrades prettier to 1.15.3 Runs `yarn prettier-save-all` against the codebase Most changes are due to https://github.com/prettier/prettier/pull/5519
-
- 22 12月, 2018 1 次提交
-
-
由 Winnie Hellmann 提交于
This reverts merge request !23622
-
- 21 12月, 2018 1 次提交
-
-
由 Fatih Acet 提交于
Fixes a bug where merge request comments made in the context of a specific commit no longer specify which commit they were created on
-
- 20 12月, 2018 1 次提交
-
-
由 Winnie Hellmann 提交于
Add commit prop to NoteableNote component and pass it from NoteableDiscussion
-
- 17 12月, 2018 1 次提交
-
-
由 sbigelow 提交于
- Add resolution text to notes in MR Discussions - Use slots to do so
-
- 14 12月, 2018 2 次提交
-
-
由 Winnie Hellmann 提交于
-
由 Oswaldo Ferreira 提交于
-
- 11 12月, 2018 1 次提交
-
-
由 Winnie Hellmann 提交于
-
- 10 12月, 2018 1 次提交
-
-
由 Annabel Dunstone Gray 提交于
-
- 08 12月, 2018 1 次提交
-
-
由 André Luís 提交于
-
- 04 12月, 2018 1 次提交
-
-
由 Winnie Hellmann 提交于
-
- 30 11月, 2018 1 次提交
-
-
由 Winnie Hellmann 提交于
-
- 29 11月, 2018 1 次提交
-
-
由 Winnie Hellmann 提交于
-
- 27 11月, 2018 1 次提交
-
-
由 Phil Hughes 提交于
Improve the renderign of new and existing discussions by reducing the number of watchers on each object & array. Previously every discussion change would trigger an update for every discussion component. Also tidied up some components to get them closer to our docs. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51506
-
- 22 11月, 2018 1 次提交
-
-
由 Fatih Acet 提交于
-
- 20 11月, 2018 1 次提交
-
-
由 Mike Greiling 提交于
-
- 15 11月, 2018 1 次提交
-
-
由 Phil Hughes 提交于
This caused many pain points when working with it. Part of the data was camel cased the other snake case. Other parts where snake case & then getting converted in components, this conversion has the potential for leaking memory. This changes that & makes it consistent with what it returned from the API, snake case.
-
- 09 11月, 2018 1 次提交
-
-
由 Annabel Dunstone Gray 提交于
-
- 08 11月, 2018 1 次提交
-
-
由 Fatih Acet 提交于
-
- 05 11月, 2018 1 次提交
-
-
由 Phil Hughes 提交于
This re-implements image commenting in merge request diffs. This feature was previously lost when the merge request page was refactored into Vue. With this, we create an overlay component. The overlay component handles displaying the comment badges and the comment form badge. Badges are displayed based on the position attribute sent with the discussion. Comment forms for diff files are controlled through a different state property. This is so we don't tie comment forms to diff files directly creating deep nested state. Instead we create a flat array which holds the file hash & the X & Y position of the comment form. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/48956
-
- 30 10月, 2018 1 次提交
-
-
由 at.ramya 提交于
-
- 08 10月, 2018 1 次提交
-
-
由 Jacques Erasmus 提交于
-
- 03 10月, 2018 1 次提交
-
-
由 Fatih Acet 提交于
-