1. 04 1月, 2018 1 次提交
    • Y
      Eager load event target authors whenever possible · dac51ace
      Yorick Peterse 提交于
      This ensures that the "author" association of an event's "target"
      association is eager loaded whenever the "target" association defines an
      "author" association. This in turn solves the N+1 query problem we first
      tried to solve in
      https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/15788 but caused
      problems when displaying milestones as those don't define an "author"
      association.
      
      The approach in this commit does mean that the authors are _always_
      eager loaded since this takes place in the "belongs_to" block. This
      however shouldn't pose too much of a problem, and as far as I can tell
      there's no real way around this unfortunately.
      dac51ace