- 05 7月, 2016 1 次提交
-
-
由 Timothy Andrew 提交于
1. The main implementation is in the `ProtectedBranch` model. The wildcard is converted to a Regex and compared. This has been tested thoroughly. - While `Project#protected_branch?` is the main entry point, `project#open_branches` and `project#developers_can_push_to_protected_branch?` have also been modified to work with wildcard protected branches. - The regex is memoized (within the `ProtectedBranch` instance) 2. Improve the performance of `Project#protected_branch?` - This method is called from `Project#open_branches` once _per branch_ in the project, to check if that branch is protected or not. - Before, `#protected_branch?` was making a database call every time it was invoked (in the above case, that amounts to once per branch), which is expensive. - This commit caches the list of protected branches in memory, which reduces the number of database calls down to 1. - A downside to this approach is that `#protected_branch?` _could_ return a stale value (due to the caching), but this is an acceptable tradeoff. 3. Remove the (now) unused `Project#protected_branch_names` method. - This was previously used to check for protected branch status.
-
- 01 7月, 2016 1 次提交
-
-
由 Rémy Coutable 提交于
And create new Project#requesters, Group#requesters scopes. Signed-off-by: NRémy Coutable <remy@rymai.me>
-
- 30 6月, 2016 2 次提交
-
-
由 Alejandro Rodríguez 提交于
-
由 Alejandro Rodríguez 提交于
-
- 29 6月, 2016 1 次提交
-
-
由 Tim 提交于
Requested in #14669 Added note to changelog
-
- 28 6月, 2016 1 次提交
-
-
由 Ruben Davila 提交于
This fix avoids exposing the information from the wiki repository of other project.
-
- 16 6月, 2016 4 次提交
-
-
由 Yorick Peterse 提交于
This ensures that Project.find_with_namespace returns a row matching literally as the first value, instead of returning a random value. The ordering here is _only_ applied to Project.find_with_namespace and _not_ Project.where_paths_in as currently there's no code that requires Project.where_paths_in to return rows in a certain order. Since this method also returns all rows that match there's no real harm in not setting a specific order either. Another reason is that generating all the "WHEN" arms for multiple values in Project.where_paths_in becomes really messy. On MySQL we have to use the "BINARY" operator to turn a "WHERE" into a case-sensitive WHERE as otherwise MySQL may still end up returning rows in an unpredictable order. Fixes gitlab-org/gitlab-ce#18603
-
由 James Lopez 提交于
This reverts commit 13e37a3e.
-
由 James Lopez 提交于
-
由 Yorick Peterse 提交于
This ensures that code such as this don't run needless SQL queries: project.gitlab_issue_tracker_service.project This also means that if the root `project` eager loads any associations the Service object will be able to re-use those.
-
- 15 6月, 2016 4 次提交
-
-
由 James Lopez 提交于
-
由 James Lopez 提交于
-
由 James Lopez 提交于
-
由 James Lopez 提交于
adapted current services stuff to use new project import, plus fixes a few issues, updated routes, etc...
-
- 14 6月, 2016 5 次提交
-
-
由 James Lopez 提交于
-
由 Rémy Coutable 提交于
+ Move 'Edit Project/Group' out of membership-related partial + Show the access request buttons only to logged-in users + Put the request access buttons out of in a more visible button + Improve the copy in the #remove_member_message helper Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 Rémy Coutable 提交于
Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 James Lopez 提交于
-
-
- 11 6月, 2016 1 次提交
-
-
由 Kamil Trzcinski 提交于
-
- 10 6月, 2016 2 次提交
-
-
由 Paco Guzman 提交于
Using update_column to store the boolean flag to avoid any side effects with the current state of the project instance
-
由 Yorick Peterse 提交于
This method can be used to find multiple projects for multiple paths. For example, take this snippet: Project.where_paths_in(%w{gitlab-org/gitlab-ce gitlab-org/gitlab-ee}) This will return an ActiveRecord::Relation containing the GitLab CE and GitLab EE projects. This method takes care of matching rows both case-sensitively and case-insensitively where needed. Project.find_with_namespace in turn has been modified to use Project.where_paths_in without nuking any scoping (instead it uses reorder(nil)). This means that any default scopes (e.g. those used for "pending_delete" stay intact). The method Project.where_paths_in was added so the various Markdown filters can use a single query to grab all the projects referenced in a set of documents, something Project.find_with_namespace didn't allow.
-
- 03 6月, 2016 4 次提交
-
-
由 James Lopez 提交于
This reverts commit 3e991230.
-
由 James Lopez 提交于
# Conflicts: # app/models/project.rb
-
由 James Lopez 提交于
-
由 James Lopez 提交于
-
- 02 6月, 2016 6 次提交
-
-
由 Josh Frye 提交于
-
由 Josh Frye 提交于
-
由 Josh Frye 提交于
-
由 Kamil Trzcinski 提交于
-
由 Kamil Trzcinski 提交于
-
由 Kamil Trzcinski 提交于
-
- 30 5月, 2016 1 次提交
-
-
由 Grzegorz Bizon 提交于
Use def with parentheses when there are parameters. See #17478
-
- 25 5月, 2016 2 次提交
-
-
由 Phil Hughes 提交于
-
由 Phil Hughes 提交于
When the project limit is zero & the user tries to create a project, the error displayed is now 'Personal project creation is not allowed. Please contact your administrator with questions' Closes #17691
-
- 20 5月, 2016 2 次提交
-
-
由 James Lopez 提交于
-
由 James Lopez 提交于
-
- 19 5月, 2016 3 次提交
-
-
由 Rubén Dávila 提交于
-
由 Rémy Coutable 提交于
Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 Kamil Trzcinski 提交于
-