This cop has been renamed to ActiveRecordSerialize to match the way
"ActiveRecord" is usually written.

This is allowed for existing instances so we don't end up 76 offenses
right away, but for new code one should _only_ use this if they _have_
to remove non database data. Even then it's usually better to do this in
a service class as this gives you more control over how to remove the
data (e.g. in bulk).

This cop adds an offense when `before`, `after`, or `around` are used as
single-line blocks.

One should really use a separate table instead of using polymorphic
associations.

See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11168 for
more information.

Add a rubocop rule to check if a method 'redirect_to' is used without explicitly set 'status' in 'destroy' actions of controllers

This Cop blacklists the use of ActiveRecord's "serialize" method, except
for cases where we already use this.

Signed-off-by: NRémy Coutable <remy@rymai.me>

We're going to add another cop that deals with another aspect of
`add_column_with_default`, so we need to separate them.

This adds a Rubocop rule to enforce the use of
add_concurrent_foreign_key instead of the regular add_foreign_key
method. This cop has been disabled for existing migrations so we don't
need to change those.

code fix for aesthetic & conventions

remove unused proc

There are currently two cops for this:

* Migration/AddIndex: checks if indexes are added concurrently
* Migration/ColumnWithDefault: checks if columns with default values are
  added in a concurrent manner

Both cops are fairly simple and make no attempt at correcting the code
as this is quite hard to do (e.g. modifications may need to be applied
in various places in the same file). They however should provide enough
to catch people ignoring the comments in generated migrations telling
them to use add_concurrent_index or add_column_with_default.