1. 24 11月, 2017 4 次提交
  2. 23 11月, 2017 6 次提交
    • D
      Rename fetch_refs to refmap · 7a1e93d3
      Douwe Maan 提交于
      7a1e93d3
    • D
      Clean up repository fetch and mirror methods · 0e6beaf5
      Douwe Maan 提交于
      0e6beaf5
    • M
      Allow password authentication to be disabled entirely · 257fd571
      Markus Koller 提交于
      257fd571
    • S
      Use latest_merge_request_diff association · 991bf24e
      Sean McGivern 提交于
      Compared to the merge_request_diff association:
      
      1. It's simpler to query. The query uses a foreign key to the
         merge_request_diffs table, so no ordering is necessary.
      2. It's faster for preloading. The merge_request_diff association has to load
         every diff for the MRs in the set, then discard all but the most recent for
         each. This association means that Rails can just query for N diffs from N
         MRs.
      3. It's more complicated to update. This is a bidirectional foreign key, so we
         need to update two tables when adding a diff record. This also means we need
         to handle this as a special case when importing a GitLab project.
      
      There is some juggling with this association in the merge request model:
      
      * `MergeRequest#latest_merge_request_diff` is _always_ the latest diff.
      * `MergeRequest#merge_request_diff` reuses
        `MergeRequest#latest_merge_request_diff` unless:
          * Arguments are passed. These are typically to force-reload the association.
          * It doesn't exist. That means we might be trying to implicitly create a
            diff. This only seems to happen in specs.
          * The association is already loaded. This is important for the reasons
            explained in the comment, which I'll reiterate here: if we a) load a
            non-latest diff, then b) get its `merge_request`, then c) get that MR's
            `merge_request_diff`, we should get the diff we loaded in c), even though
            that's not the latest diff.
      
      Basically, `MergeRequest#merge_request_diff` is the latest diff in most cases,
      but not quite all.
      991bf24e
    • J
      Fix link text from group context · e826c5d0
      Jarka Kadlecova 提交于
      e826c5d0
    • L
      7df1cb52
  3. 22 11月, 2017 2 次提交
    • J
      Use Redis cache for branch existence checks · 00cd5d93
      Jacob Vosmaer (GitLab) 提交于
      00cd5d93
    • Y
      Use arrays in Pipeline#latest_builds_with_artifacts · 54f1e406
      Yorick Peterse 提交于
      This changes Ci::Pipeline#latest_builds_with_artifacts so it returns an
      Array instead of a relation. Whenever we use this data we do so in two
      steps:
      
      1. Count the number of rows
      2. If this number is greater than 0, iterate over the rows
      
      By returning an Array instead we only execute 1 query of which the total
      time/work is less than running either just a COUNT(*) or both queries
      (in the worst case).
      
      On GitLab.com this change should save us a few milliseconds per request
      to ProjectsController#show.
      54f1e406
  4. 21 11月, 2017 4 次提交
  5. 20 11月, 2017 1 次提交
  6. 19 11月, 2017 1 次提交
  7. 18 11月, 2017 1 次提交
    • S
      Fix conflict highlighting · 64a9e53b
      Sean McGivern 提交于
      Conflicts used to take a `Repository` and pass that to
      `Gitlab::Highlight.highlight`, which would call `#gitattribute` on the
      repository. Now they use a `Gitlab::Git::Repository`, which didn't have that
      method defined - but defining it on `Gitlab::Git::Repository` does make it
      available on `Repository` through `method_missing`, so we can do that and both
      cases will work.
      64a9e53b
  8. 17 11月, 2017 6 次提交
  9. 16 11月, 2017 3 次提交
  10. 15 11月, 2017 6 次提交
  11. 14 11月, 2017 3 次提交
  12. 13 11月, 2017 3 次提交