1. 07 7月, 2017 1 次提交
    • S
      Add table for merge request commits · aff5c9f3
      Sean McGivern 提交于
      This is an ID-less table with just three columns: an association to the merge
      request diff the commit belongs to, the relative order of the commit within the
      merge request diff, and the commit SHA itself.
      
      Previously we stored much more information about the commits, so that we could
      display them even when they were deleted from the repo. Since 8.0, we ensure
      that those commits are kept around for as long as the target repo itself is, so
      we don't need to duplicate that data in the database.
      aff5c9f3
  2. 06 7月, 2017 3 次提交
    • Y
      Rename ActiverecordSerialize cop · e1a3bf30
      Yorick Peterse 提交于
      This cop has been renamed to ActiveRecordSerialize to match the way
      "ActiveRecord" is usually written.
      e1a3bf30
    • Y
      Added Cop to blacklist the use of `dependent:` · 8fbbf41e
      Yorick Peterse 提交于
      This is allowed for existing instances so we don't end up 76 offenses
      right away, but for new code one should _only_ use this if they _have_
      to remove non database data. Even then it's usually better to do this in
      a service class as this gives you more control over how to remove the
      data (e.g. in bulk).
      8fbbf41e
    • Y
      Add many foreign keys to the projects table · c63e3221
      Yorick Peterse 提交于
      This removes the need for relying on Rails' "dependent" option for data
      removal, which is _incredibly_ slow (even when using :delete_all) when
      deleting large amounts of data. This also ensures data consistency is
      enforced on DB level and not on application level (something Rails is
      really bad at).
      
      This commit also includes various migrations to add foreign keys to
      tables that eventually point to "projects" to ensure no rows get
      orphaned upon removing a project.
      c63e3221
  3. 26 6月, 2017 1 次提交
  4. 21 6月, 2017 2 次提交
  5. 16 6月, 2017 1 次提交
  6. 15 6月, 2017 1 次提交
  7. 01 6月, 2017 1 次提交
  8. 31 5月, 2017 1 次提交
  9. 30 5月, 2017 1 次提交
  10. 24 5月, 2017 2 次提交
  11. 19 5月, 2017 1 次提交
  12. 13 5月, 2017 1 次提交
    • S
      Fix conflict resolution from corrupted upstream · ad2bfeb8
      Sean McGivern 提交于
      I don't know why this happens exactly, but given an upstream and fork repository
      from a customer, both of which required GC, resolving conflicts would corrupt
      the fork so badly that it couldn't be cloned.
      
      This isn't a perfect fix for that case, because the MR may still need to be
      merged manually, but it does ensure that the repository is at least usable.
      
      My best guess is that when we generate the index for the conflict
      resolution (which we previously did in the target project), we obtain a
      reference to an OID that doesn't exist in the source, even though we already
      fetch the refs from the target into the source.
      
      Explicitly setting the source project as the place to get the merge index from
      seems to prevent repository corruption in this way.
      ad2bfeb8
  13. 12 5月, 2017 1 次提交
  14. 09 5月, 2017 1 次提交
  15. 08 5月, 2017 1 次提交
  16. 04 5月, 2017 2 次提交
  17. 27 4月, 2017 1 次提交
  18. 25 4月, 2017 1 次提交
    • S
      Show correct size when MR diff overflows · a0979c05
      Sean McGivern 提交于
      The problem is that we often go via a diff object constructed from the diffs
      stored in the DB. Those diffs, by definition, don't overflow, so we don't have
      access to the 'correct' `real_size` - that is stored on the MR diff object
      iself.
      a0979c05
  19. 11 4月, 2017 1 次提交
  20. 09 4月, 2017 3 次提交
  21. 06 4月, 2017 3 次提交
  22. 04 4月, 2017 2 次提交
  23. 22 3月, 2017 1 次提交
  24. 21 3月, 2017 1 次提交
  25. 20 3月, 2017 1 次提交
  26. 15 3月, 2017 1 次提交
  27. 02 3月, 2017 1 次提交
  28. 01 3月, 2017 1 次提交
    • J
      Update occurrences of MWBS to MWPS · a0101ebf
      James Lopez 提交于
       Rename column in the database
       Rename fields related to import/export feature
       Rename API endpoints
       Rename documentation links
       Rename the rest of occurrences in the code
       Replace the images that contain the words "build succeeds" and docs referencing to them
       Make sure pipeline is green and nothing is missing.
      
      updated doc images
      
      renamed only_allow_merge_if_build_succeeds in projects and fixed references
      
      more updates
      
      fix some spec failures
      
      fix rubocop offences
      
      fix v3 api spec
      
      fix MR  specs
      
      fixed issues with partials
      
      fix MR spec
      
      fix alignment
      
      add missing v3 to v4 doc
      
      wip - refactor v3 endpoints
      
      fix specs
      
      fix a few typos
      
      fix project specs
      
      copy entities fully to V3
      
      fix  entity error
      
      more fixes
      
      fix failing specs
      
      fixed missing entities in V3 API
      
      remove comment
      
      updated code based on feedback
      
      typo
      
      fix spec
      a0101ebf
  29. 25 2月, 2017 1 次提交
    • S
      Only create unmergeable todos once · 2da8bc3d
      Sean McGivern 提交于
      Previously, we created an unmergeable todo when a merge request:
      
      1. Had merge when pipeline succeeds set.
      2. Became unmergeable.
      
      However, when merge when pipeline succeeds fails due to unmergeability,
      the flag isn't actually removed. And a merge request can become
      unmergeable multiple times, as every time the target branch is updated
      we need to re-check the mergeable status. This means that if the todo
      was marked done, and the MR was checked again, a new todo would be
      created for the same event.
      
      Instead of checking this, we should create the todo from the service
      responsible for merging when the pipeline succeeds. That way the todo is
      guaranteed to only be created when we care about it.
      2da8bc3d
  30. 23 2月, 2017 1 次提交
    • D
      Revert "Enable Style/DotPosition" · 56de781a
      Douwe Maan 提交于
      This reverts commit e00fb2bdc2090e9cabeb1eb35a2672a882cc96e9.
      
      # Conflicts:
      #	.rubocop.yml
      #	.rubocop_todo.yml
      #	lib/gitlab/ci/config/entry/global.rb
      #	lib/gitlab/ci/config/entry/jobs.rb
      #	spec/lib/gitlab/ci/config/entry/factory_spec.rb
      #	spec/lib/gitlab/ci/config/entry/global_spec.rb
      #	spec/lib/gitlab/ci/config/entry/job_spec.rb
      #	spec/lib/gitlab/ci/status/build/factory_spec.rb
      #	spec/lib/gitlab/incoming_email_spec.rb
      56de781a