Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

So we have raw_diffs too

This object will manage Gitlab::Git::Compare instances

Instead calling diff_collection.count use diff_collection.size which is cache on the diff_collection

Introducing the concept of SafeDiffs which relates 
diffs with UI highlighting.

Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

* Use commit objects instead of IDs when generating diffs
* Use proper references when generating MR's source and target
* Update broken specs

Now we apply syntax highlighting to the whole old and new files.
This basically help us to highlight adequately multiline content.

fix this issue(https://gitlab.com/gitlab-org/gitlab-ce/issues/1393).

Add ignore whitespace optoin to Commits Compare view

This reverts commit 5daf44b7, reversing
changes made to 2f706fbd.

This reverts commit 4773f38e, reversing
changes made to 0d5d80b7.

Now when changes in merge requests stored in target project we can
always link commits and diffs to target project. So even people without
access to fork can browse commits and diffs
Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

Use the path helpers for nested project resources, for Rails 4.1.9
compatibility.

Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

-Had to do some minor test clean up as well

Change-Id: I8f378f1b5fe676d73b8691e870c11ca6def90cbf

-Disable observers post test run
-Allow db:seed_fu RAILS_ENV=test to be run more than once without error
-fix diffs_in_between, was passing in the default_options for grit, but grit in this case doesn't take options, fixed the test to actually fail if the incorrect diffs are returned
-make notes/commits render against proper project
-MR discussion file links should reference note's project
-Added tests for commit links on edit merge request
-fixes edit issues (canceling an edited mr, updating an edited mr)
-updates tests with checks for source code updates
-still forked_merge_requests.feature (project_forked_merge_requests) test not passing (commented out -- "stable" not being set)

MR API: error on bad target_project

-If the target project id is specified and it is not the same as the project the request is being made on (the source), and the it isn't a fork of that project, error out, otherwise use it as the target
-Fixes some busted (but hidden) test cases

Conflicts:
	app/views/merge_requests/show/_diffs.html.haml
	spec/features/notes_on_merge_requests_spec.rb

Change-Id: I20e595c156d0e8a63048baaead7be6330c738a05

Needed to add a constraint on the id. Otherwise the format was parsed as part of the id.

Didn't bother with files in db/, config/, or features/