1. 22 2月, 2019 1 次提交
  2. 21 2月, 2019 1 次提交
  3. 16 2月, 2019 1 次提交
  4. 15 2月, 2019 1 次提交
  5. 14 2月, 2019 1 次提交
  6. 05 2月, 2019 1 次提交
  7. 24 1月, 2019 1 次提交
  8. 14 1月, 2019 1 次提交
  9. 28 11月, 2018 1 次提交
  10. 05 11月, 2018 1 次提交
  11. 01 11月, 2018 1 次提交
  12. 30 10月, 2018 1 次提交
  13. 26 10月, 2018 3 次提交
  14. 30 9月, 2018 1 次提交
  15. 11 9月, 2018 1 次提交
  16. 22 8月, 2018 2 次提交
  17. 01 8月, 2018 1 次提交
  18. 05 6月, 2018 2 次提交
    • S
      Remove N+1 query for author in issues API · c26cbfcd
      Stan Hu 提交于
      This was being masked by the statement cache because only one author was used
      per issue in the test..
      
      Also adds support for an Rspec matcher `exceed_all_query_limit`.
      c26cbfcd
    • S
      Remove N+1 query for author in issues API · cbc20d2b
      Stan Hu 提交于
      This was being masked by the statement cache because only one author was used
      per issue in the test..
      
      Also adds support for an Rspec matcher `exceed_all_query_limit`.
      cbc20d2b
  19. 31 5月, 2018 1 次提交
    • S
      Eliminate cached N+1 queries for projects in Issue API · ef253a1e
      Stan Hu 提交于
      In CE, every `Issue` entity is also a `ProjectEntity`, which calls
      `entity&.project.try(:id)` to show the project ID. In an API
      request with 100 issues, this would hit the Rails statement cache 100 times
      for the same project and cause unnecessary overhead as related models would
      also be loaded.
      
      In EE, we call `Issue#supports_weight?` for each issue, which then calls
      `project&.feature_available?(:issue_weights)`. If the project is not
      preloaded, this incurs additional overhead, as each individual Project
      object has to be queried. This can lead to a significant performance hit.
      In loading the CE project with 100 issues, this contributed to at least 22%
      of the load time.
      
      See https://gitlab.com/gitlab-org/gitlab-ce/issues/47031 for why testing this
      is a bit tricky.
      ef253a1e
  20. 21 5月, 2018 1 次提交
  21. 15 5月, 2018 1 次提交
  22. 18 4月, 2018 1 次提交
  23. 06 4月, 2018 1 次提交
  24. 05 3月, 2018 1 次提交
  25. 02 2月, 2018 1 次提交
    • Y
      Track and act upon the number of executed queries · cca61980
      Yorick Peterse 提交于
      This ensures that we have more visibility in the number of SQL queries
      that are executed in web requests. The current threshold is hardcoded to
      100 as we will rarely (maybe once or twice) change it.
      
      In production and development we use Sentry if enabled, in the test
      environment we raise an error. This feature is also only enabled in
      production/staging when running on GitLab.com as it's not very useful to
      other users.
      cca61980
  26. 12 1月, 2018 1 次提交
  27. 05 1月, 2018 1 次提交
  28. 20 12月, 2017 1 次提交
  29. 09 12月, 2017 1 次提交
    • S
      Merge branch 'issue_30663' into 'security-10-2' · c59ae547
      Sean McGivern 提交于
      Prevent creating issues through API without having permissions
      
      See merge request gitlab/gitlabhq!2225
      
      (cherry picked from commit c298bbaa88883343dc9cbbb6abec0808fb3b546c)
      
      915b97c5 Prevent creating issues through API without having permissions
      c59ae547
  30. 26 11月, 2017 1 次提交
  31. 08 11月, 2017 1 次提交
    • S
      Fail when issuable_meta_data is called on an unlimited collection · 4d4ddb60
      Sean McGivern 提交于
      This method can be called with an array, or a relation:
      
      1. Arrays always have a limited amount of values, so that's fine.
      2. If the relation does not have a limit value applied, then we will load every
         single object in that collection, and prevent N+1 queries for the metadata
         for that. But that's wrong, because we should never call this without an
         explicit limit set. So we raise in that case, and this commit will see which
         specs fail.
      
      The only failing specs here were the issues API specs, and the specs for
      IssuableMetadata itself, and both have been addressed.
      4d4ddb60
  32. 14 9月, 2017 2 次提交
  33. 05 9月, 2017 1 次提交
  34. 31 8月, 2017 1 次提交
  35. 29 8月, 2017 1 次提交