- 31 5月, 2017 1 次提交
-
-
由 Douwe Maan 提交于
-
- 30 5月, 2017 1 次提交
-
-
由 Douwe Maan 提交于
-
- 29 5月, 2017 1 次提交
-
-
由 Valery Sizov 提交于
-
- 27 5月, 2017 2 次提交
-
-
由 Stan Hu 提交于
-
由 Alejandro Rodríguez 提交于
-
- 26 5月, 2017 2 次提交
-
-
由 Jarka Kadlecova 提交于
-
由 winh 提交于
-
- 25 5月, 2017 6 次提交
-
-
由 Kamil Trzcinski 提交于
It was broken, because we introduced a default namespace, which was not used by terminal methods.
-
由 Alexander Randa 提交于
* implemented logging of project and system web hooks * implemented UI for user area (project hooks) * implemented UI for admin area (system hooks) * implemented retry of logged webhook * NOT imeplemented log remover
-
由 Douwe Maan 提交于
This reverts commit b0498c17
-
由 Alexis Reigel 提交于
we do this on attribute read since migrating all existing users is not a feasible solution.
-
由 Alexis Reigel 提交于
-
由 Alexis Reigel 提交于
-
- 24 5月, 2017 5 次提交
-
-
由 Douwe Maan 提交于
-
由 Douwe Maan 提交于
-
由 Douwe Maan 提交于
-
由 Douwe Maan 提交于
-
由 Douwe Maan 提交于
-
- 23 5月, 2017 2 次提交
-
-
由 Z.J. van de Weg 提交于
These were untested by the cherry picked commit.
-
由 Felipe Artur 提交于
-
- 20 5月, 2017 1 次提交
-
-
由 Grzegorz Bizon 提交于
-
- 19 5月, 2017 1 次提交
-
-
由 Rémy Coutable 提交于
Signed-off-by: NRémy Coutable <remy@rymai.me>
-
- 18 5月, 2017 3 次提交
-
-
由 Michael Kozono 提交于
Older namespace records may be both `type == ‘Group` AND `owner_id` is not null.
-
由 Douwe Maan 提交于
-
由 Douwe Maan 提交于
-
- 17 5月, 2017 1 次提交
-
-
由 Yorick Peterse 提交于
This commit introduces the usage of Common Table Expressions (CTEs) to efficiently retrieve nested group hierarchies, without having to rely on the "routes" table (which is an _incredibly_ inefficient way of getting the data). This requires a patch to ActiveRecord (found in the added initializer) to work properly as ActiveRecord doesn't support WITH statements properly out of the box. Unfortunately MySQL provides no efficient way of getting nested groups. For example, the old routes setup could easily take 5-10 seconds depending on the amount of "routes" in a database. Providing vastly different logic for both MySQL and PostgreSQL will negatively impact the development process. Because of this the various nested groups related methods return empty relations when used in combination with MySQL. For project authorizations the logic is split up into two classes: * Gitlab::ProjectAuthorizations::WithNestedGroups * Gitlab::ProjectAuthorizations::WithoutNestedGroups Both classes get the fresh project authorizations (= as they should be in the "project_authorizations" table), including nested groups if PostgreSQL is used. The logic of these two classes is quite different apart from their public interface. This complicates development a bit, but unfortunately there is no way around this. This commit also introduces Gitlab::GroupHierarchy. This class can be used to get the ancestors and descendants of a base relation, or both by using a UNION. This in turn is used by methods such as: * Namespace#ancestors * Namespace#descendants * User#all_expanded_groups Again this class relies on CTEs and thus only works on PostgreSQL. The Namespace methods will return an empty relation when MySQL is used, while User#all_expanded_groups will return only the groups a user is a direct member of. Performance wise the impact is quite large. For example, on GitLab.com Namespace#descendants used to take around 580 ms to retrieve data for a particular user. Using CTEs we are able to reduce this down to roughly 1 millisecond, returning the exact same data. == On The Fly Refreshing Refreshing of authorizations on the fly (= when users.authorized_projects_populated was not set) is removed with this commit. This simplifies the code, and ensures any queries used for authorizations are not mutated because they are executed in a Rails scope (e.g. Project.visible_to_user). This commit includes a migration to schedule refreshing authorizations for all users, ensuring all of them have their authorizations in place. Said migration schedules users in batches of 5000, with 5 minutes between every batch to smear the load around a bit. == Spec Changes This commit also introduces some changes to various specs. For example, some specs for ProjectTeam assumed that creating a personal project would _not_ lead to the owner having access, which is incorrect. Because we also no longer refresh authorizations on the fly for new users some code had to be added to the "empty_project" factory. This chunk of code ensures that the owner's permissions are refreshed after creating the project, something that is normally done in Projects::CreateService.
-
- 16 5月, 2017 2 次提交
-
-
由 Alejandro Rodríguez 提交于
-
由 Valery Sizov 提交于
-
- 15 5月, 2017 1 次提交
-
-
由 Douwe Maan 提交于
-
- 14 5月, 2017 2 次提交
-
-
由 Douwe Maan 提交于
-
由 Ahmad Sherif 提交于
Closes gitaly#199
-
- 13 5月, 2017 3 次提交
-
-
由 Gabriel Mazetto 提交于
-
由 Gabriel Mazetto 提交于
-
由 Sean McGivern 提交于
I don't know why this happens exactly, but given an upstream and fork repository from a customer, both of which required GC, resolving conflicts would corrupt the fork so badly that it couldn't be cloned. This isn't a perfect fix for that case, because the MR may still need to be merged manually, but it does ensure that the repository is at least usable. My best guess is that when we generate the index for the conflict resolution (which we previously did in the target project), we obtain a reference to an OID that doesn't exist in the source, even though we already fetch the refs from the target into the source. Explicitly setting the source project as the place to get the merge index from seems to prevent repository corruption in this way.
-
- 12 5月, 2017 6 次提交
-
-
由 Dmitriy Zaporozhets 提交于
Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
由 Douwe Maan 提交于
-
由 Dmitriy Zaporozhets 提交于
Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
由 Valery Sizov 提交于
-
由 Phil Hughes 提交于
-
由 Pawel Chojnacki 提交于
+ fix tests
-