Skip to content

G
gitlab-foss

李少辉-开发者 / gitlab-foss

通知 15
Star 0
Fork 0
G
gitlab-foss

体验新版 GitCode，发现更多精彩内容 >>

切换分支/标签
  1. 15 12月, 2015 1 次提交
  3. 12 12月, 2015 1 次提交
  5. 11 12月, 2015 1 次提交
  7. 10 12月, 2015 1 次提交
  9. 09 12月, 2015 1 次提交
  11. 08 12月, 2015 2 次提交
  13. 05 12月, 2015 1 次提交
    • S
      Fix Error 500 when creating global milestones with Unicode characters · d800a949
      由 Stan Hu 提交于 
      Two issues:

1. The constraints in the resources were incorrect. Here's what it was before:
```
group_milestone  GET /groups/:group_id/milestones/:id(.:format)  groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
```

In this case, id is actually the title of the milestone, which can be anything at the moment.

After:

```
group_milestone  GET /groups/:group_id/milestones/:id(.:format)  groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
```

2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like:

ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]):

This change uses the babosa library to create a better slug, which surprisingly
isn't actually used by the global milestone controllers. Instead, they use the
title passed as a query string for some reason.

Closes https://github.com/gitlabhq/gitlabhq/issues/9881

Fix constraints
      d800a949
  15. 04 12月, 2015 1 次提交
  17. 26 11月, 2015 1 次提交
  19. 23 11月, 2015 1 次提交
  21. 19 11月, 2015 1 次提交
  23. 18 11月, 2015 1 次提交
  25. 17 11月, 2015 1 次提交
  27. 16 11月, 2015 2 次提交
  29. 12 11月, 2015 1 次提交
    • J
      Avoid render edit_form in each notes. · 19740871
      由 Jason Lee 提交于 
      Use RJS to render edit note feature.

Before:

```
Rendered projects/notes/_note.html.haml (27.9ms)
Rendered projects/_zen.html.haml (0.3ms)
Rendered projects/notes/_hints.html.haml (0.7ms)
Rendered projects/_md_preview.html.haml (3.9ms)
Rendered projects/notes/_edit_form.html.haml (6.9ms)
Rendered projects/notes/_note.html.haml (17.7ms)
Rendered projects/_zen.html.haml (0.3ms)
Rendered projects/notes/_hints.html.haml (0.6ms)
Rendered projects/_md_preview.html.haml (3.4ms)
Rendered projects/notes/_edit_form.html.haml (7.0ms)
```

After:

```
Rendered projects/notes/_note.html.haml (13.8ms)
Rendered projects/notes/_note.html.haml (7.1ms)
Rendered projects/notes/_note.html.haml (9.5ms)
Rendered projects/notes/_note.html.haml (8.5ms)
```

This change reduce at least 6ms * N ('N' - number of notes).
      19740871
  31. 10 11月, 2015 2 次提交
  33. 09 11月, 2015 1 次提交
    • Y
      Added Sherlock, a custom profiling tool for GitLab · dec3e4ce
      由 Yorick Peterse 提交于 
      Sherlock will be a new GitLab specific tool for measuring the
performance of Rails requests (and SideKiq jobs at some point). Some of
the things that are currently tracked:

* SQL queries along with their timings, backtraces and query plans
  (using "EXPLAIN ANALYZE" for PostgreSQL and regular "EXPLAIN" for
  MySQL)
* Timings of application files (including views) on a per line basis
* Some meta data such as the request method, path, total duration, etc

More tracking (e.g. Rugged or gitlab-shell timings) might be added in
the future.

Sherlock will replace any existing tools we have used so far (e.g.
active_record_query_trace and rack-mini-profiler), hence the
corresponding Gems have been removed from the Gemfile.

Sherlock can be enabled by starting Rails as following:

    ENABLE_SHERLOCK=1 bundle exec rails s

Recorded transactions can be found at `/sherlock/transactions`.
      dec3e4ce
  35. 05 11月, 2015 4 次提交
  37. 03 11月, 2015 1 次提交
  39. 29 10月, 2015 1 次提交
  41. 28 10月, 2015 1 次提交
  43. 15 10月, 2015 1 次提交
  45. 14 10月, 2015 2 次提交
  47. 13 10月, 2015 2 次提交
  49. 07 10月, 2015 6 次提交
  51. 06 10月, 2015 1 次提交
  53. 05 10月, 2015 1 次提交