- 07 2月, 2017 2 次提交
-
-
由 Douwe Maan 提交于
-
由 Douwe Maan 提交于
-
- 28 1月, 2017 2 次提交
-
-
由 Oswaldo Ferreira 提交于
-
由 Oswaldo Ferreira 提交于
-
- 14 1月, 2017 1 次提交
-
-
由 twonegatives 提交于
-
- 11 1月, 2017 1 次提交
-
-
由 Jarka Kadlecova 提交于
-
- 04 1月, 2017 1 次提交
-
-
由 Mike Greiling 提交于
-
- 03 1月, 2017 1 次提交
-
-
由 James Lopez 提交于
Also added relevant specs and refactored to_references in a bunch of places to be more consistent.
-
- 30 12月, 2016 1 次提交
-
-
由 Valery Sizov 提交于
-
- 28 12月, 2016 1 次提交
-
-
由 Gabriel Gizotti 提交于
use MergeRequest#closes_issues instead of rewriting code to retrieve closing issues on MergeRequest#issues_mentioned_but_not_closing
-
- 26 12月, 2016 1 次提交
-
-
由 Sean McGivern 提交于
We don't need to create the intermediate FileCollection object with its associated highlighting in order to count how many files changed. Both the compare object and the MR diff object have a raw_diffs method that is perfectly fine for this case.
-
- 19 12月, 2016 1 次提交
-
-
由 James Lopez 提交于
-
- 16 12月, 2016 10 次提交
-
-
由 Gabriel Gizotti 提交于
Change closes issues reference text on MergeRequest#merge_commit_message to match existing text generated by the system
-
由 Gabriel Gizotti 提交于
-
由 Gabriel Gizotti 提交于
Show either description or closes issues references on MergeRequest#merge_commit_message so closes issues references are not duplicated
-
由 Gabriel Gizotti 提交于
-
由 Gabriel Gizotti 提交于
-
由 Gabriel Gizotti 提交于
-
由 Gabriel Gizotti 提交于
-
由 Gabriel Gizotti 提交于
-
由 Gabriel Gizotti 提交于
-
由 Gabriel Gizotti 提交于
-
- 15 12月, 2016 1 次提交
-
-
由 Douwe Maan 提交于
Fix missing Note access checks in by moving Note#search to updated NoteFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ## Which fixes are in this MR?
⚠ - Potentially untested💣 - No test coverage🚥 - Test coverage of some sort exists (a test failed when error raised)🚦 - Test coverage of return value (a test failed when nil used)✅ - Permissions check tested ### Note lookup without access check - [x]✅ app/finders/notes_finder.rb:13 :download_code check - [x]✅ app/finders/notes_finder.rb:19 `SnippetsFinder` - [x]✅ app/models/note.rb:121 [`Issue#visible_to_user`] - [x]✅ lib/gitlab/project_search_results.rb:113 - This is the only use of `app/models/note.rb:121` above, but importantly has no access checks at all. This means it leaks MR comments and snippets when those features are `team-only` in addition to the issue comments which would be fixed by `app/models/note.rb:121`. - It is only called from SearchController where `can?(current_user, :download_code, @project)` is checked, so commit comments are not leaked. ### Previous discussions - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b915c5267a63628b0bafd23d37792ae73ceae272_13_13 `: download_code` check on commit - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b915c5267a63628b0bafd23d37792ae73ceae272_19_19 `SnippetsFinder` should be used - `SnippetsFinder` should check if the snippets feature is enabled -> https://gitlab.com/gitlab-org/gitlab-ce/issues/25223 ### Acceptance criteria met? - [x] Tests added for new code - [x] TODO comments removed - [x] Squashed and removed skipped tests - [x] Changelog entry - [ ] State Gitlab versions affected and issue severity in description - [ ] Create technical debt issue for NotesFinder. - Either split into `NotesFinder::ForTarget` and `NotesFinder::Search` or consider object per notable type such as `NotesFinder::OnIssue`. For the first option could create `NotesFinder::Base` which is either inherited from or which can be included in the other two. - Avoid case statement anti-pattern in this finder with use of `NotesFinder::OnCommit` etc. Consider something on the finder for this? `Model.finder(user, project)` - Move `inc_author` to the controller, and implement `related_notes` to replace `non_diff_notes`/`mr_and_commit_notes` See merge request !2035
-
- 09 12月, 2016 2 次提交
-
-
由 Adam Niedzielski 提交于
The target branch of a merge request has to be a branch in the project for which the merge request is submitted. When a branch changes in a fork, it does not make sense to reload diffs of merge requests in the upstream project that use the same branch name as the target branch. Please note that it does make sense to reload diffs when the source branch changes.
-
由 Douwe Maan 提交于
Replace MR access checks with use of MergeRequestsFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867
⚠ - Potentially untested💣 - No test coverage🚥 - Test coverage of some sort exists (a test failed when error raised)🚦 - Test coverage of return value (a test failed when nil used)✅ - Permissions check tested - [x]💣 app/finders/notes_finder.rb:17 - [x]⚠ app/views/layouts/nav/_project.html.haml:80 [`.count`] - [x]💣 app/controllers/concerns/creates_commit.rb:84 - [x]🚥 app/controllers/projects/commits_controller.rb:24 - [x]🚥 app/controllers/projects/compare_controller.rb:56 - [x]🚦 app/controllers/projects/discussions_controller.rb:29 - [x]✅ app/controllers/projects/todos_controller.rb:27 - [x]🚦 app/models/commit.rb:268 - [x]✅ lib/gitlab/search_results.rb:71 - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_267_266 Memoize ` merged_merge_request(current_user)` - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_248_247 Expected side effect for `merged_merge_request!`, consider `skip_authorization: true`. - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_269_269 Scary use of unchecked `merged_merge_request?` See merge request !2033
-
- 06 12月, 2016 1 次提交
-
-
由 Bob Van Landuyt 提交于
When a merge request can only be merged when all discussions are resolved. This feature allows to easily delegate those discussions to a new issue, while marking them as resolved in the merge request. The user is presented with a new issue, prepared with mentions of all unresolved discussions, including the first unresolved note of the discussion, time and link to the note. When the issue is created, the discussions in the merge request will get a system note directing the user to the newly created issue.
-
- 03 12月, 2016 1 次提交
-
-
由 Oswaldo Ferreira 提交于
-
- 01 12月, 2016 1 次提交
-
-
由 Adam Niedzielski 提交于
when we care only about the number of commits We do not have to instantiate all objects in this case.
-
- 29 11月, 2016 1 次提交
-
-
由 Grzegorz Bizon 提交于
-
- 28 11月, 2016 1 次提交
-
-
由 Adam Niedzielski 提交于
-
- 23 11月, 2016 2 次提交
-
-
由 Yorick Peterse 提交于
Flushing the events cache worked by updating a recent number of rows in the "events" table. This has the result that on PostgreSQL a lot of dead tuples are produced on a regular basis. This in turn means that PostgreSQL will spend considerable amounts of time vacuuming this table. This in turn can lead to an increase of database load. For GitLab.com we measured the impact of not using events caching and found no measurable increase in response timings. Meanwhile not flushing the events cache lead to the "events" table having no more dead tuples as now rows are only inserted into this table. As a result of this we are hereby removing events caching as it does not appear to help and only increases database load. For more information see the following comment: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6578#note_18864037
-
由 Douwe Maan 提交于
-
- 21 11月, 2016 1 次提交
-
-
由 Rémy Coutable 提交于
Also allow merge request to be merged with skipped pipeline and the "only allow merge when pipeline is green" feature enabled Signed-off-by: NRémy Coutable <remy@rymai.me>
-
- 17 11月, 2016 2 次提交
-
-
由 James Lopez 提交于
-
由 James Lopez 提交于
add pipeline id to merge request metrics table. Also, updated the pipeline worker to populate this field.
-
- 09 11月, 2016 1 次提交
-
-
由 Grzegorz Bizon 提交于
-
- 04 11月, 2016 2 次提交
-
-
由 Rodolfo Santos 提交于
Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 Rémy Coutable 提交于
Signed-off-by: NRémy Coutable <remy@rymai.me>
-
- 29 10月, 2016 1 次提交
-
-
由 Guilherme Salazar 提交于
fix issues pointed out in !6527 add task completion status feature to CHANGELOG
-
- 25 10月, 2016 1 次提交
-
-
由 David Wagner 提交于
They were Rails' default and are unnecessarily overridden. Signed-off-by: NDavid Wagner <david@marvid.fr>
-