Skip to content

G
gitlab-foss

李少辉-开发者 / gitlab-foss

通知 15
Star 0
Fork 0
G
gitlab-foss

体验新版 GitCode，发现更多精彩内容 >>

切换分支/标签
  1. 06 7月, 2016 3 次提交
  3. 09 5月, 2016 1 次提交
    • S
      Improve multiple branch push performance by memoizing permission checking · 4be77d0b
      由 Stan Hu 提交于 
      If you attempt to push thousands of branches at once, the 60-second timeout
will occur because GitAccess checking does a lot of work to check if the
user has permission to push to a branch. This changes does two things:

1. Instead of making 1 DB query per branch push, use a memoized list of protected branches to check
2. Memoize what permissions the user has to perform on this project

On a test of 10,000 branch pushes, this prevents gitlab-shell from hitting the 60-second
timeout.

Closes #17225
      4be77d0b
  5. 06 5月, 2016 2 次提交
    • Y
      Fix passing nil to protected_tag? · 00367120
      由 Yorick Peterse 提交于 
      Previously this method would directly receive the output of tag_name().
This method could either return a String or nil. In the previous setup
this would somehow magically work but because Rugged::TagCollection#[]
doesn't accept nil values it started to fail.

To work around this the elsif in change_access_check() assigns the
result of tag_name() to a local and then _only_ calls protected_tag?()
if the tag name is not nil. The extra parenthesis are put in place to
ensure that things are parsed correctly, without these the code would be
parsed as follows:

    elsif tag_ref = (tag_name(ref) && protected_tag(tag_ref))

During runtime this would basically resolve to:

    elsif tag_ref = (tag_name(ref) && protected_tag(nil))

This is because when you refer to the variable you're assigning _in_ the
assignment Ruby returns nil instead of raising an error.
      00367120
    • Y
      Use tag_exists? in GitAccess#protected_tag? · 93ce2296
      由 Yorick Peterse 提交于 
      This removes the need for retrieving the entire list of tags just to
check if a specific one exists.
      93ce2296
  7. 16 11月, 2015 1 次提交
  9. 13 5月, 2015 2 次提交
  11. 25 3月, 2015 1 次提交
  13. 24 3月, 2015 1 次提交
  15. 10 3月, 2015 1 次提交
  17. 19 2月, 2015 1 次提交
  19. 03 2月, 2015 2 次提交
  21. 29 1月, 2015 1 次提交
  23. 21 1月, 2015 1 次提交
  25. 26 12月, 2014 3 次提交
  27. 06 12月, 2014 1 次提交
  29. 02 12月, 2014 1 次提交
  31. 01 12月, 2014 1 次提交
  33. 18 11月, 2014 1 次提交
  35. 04 11月, 2014 1 次提交
  37. 07 10月, 2014 1 次提交
  39. 23 9月, 2014 1 次提交
  41. 02 9月, 2014 1 次提交
  43. 30 5月, 2014 1 次提交
  45. 22 5月, 2014 1 次提交
  47. 15 5月, 2014 2 次提交
  49. 03 4月, 2014 1 次提交
  51. 26 3月, 2014 1 次提交
  53. 21 3月, 2014 1 次提交
  55. 20 3月, 2014 1 次提交