- 28 2月, 2017 4 次提交
-
-
由 Robert Schilling 提交于
-
由 Robert Schilling 提交于
-
由 Robert Schilling 提交于
-
由 Alex Sanford 提交于
-
- 27 2月, 2017 3 次提交
-
-
由 Sean McGivern 提交于
-
由 Phil Hughes 提交于
Previously it was listening for focusout, it now listens for blur & paste events Closes #28436
-
由 Dmitriy Zaporozhets 提交于
Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 25 2月, 2017 5 次提交
-
-
由 Robert Speicher 提交于
-
由 Robert Speicher 提交于
- Moves a duplicate `file_storage?` definition into the common `GitlabUploader` ancestor. - Get the `uploads` base directory from a class method rather than hard-coding it where it's needed. This will be used in a subsequent MR to store Uploads in the database. - Improves the specs for uploaders.
-
由 Robert Schilling 提交于
-
由 Felipe Artur 提交于
-
由 Sean McGivern 提交于
Previously, we created an unmergeable todo when a merge request: 1. Had merge when pipeline succeeds set. 2. Became unmergeable. However, when merge when pipeline succeeds fails due to unmergeability, the flag isn't actually removed. And a merge request can become unmergeable multiple times, as every time the target branch is updated we need to re-check the mergeable status. This means that if the todo was marked done, and the MR was checked again, a new todo would be created for the same event. Instead of checking this, we should create the todo from the service responsible for merging when the pipeline succeeds. That way the todo is guaranteed to only be created when we care about it.
-
- 24 2月, 2017 28 次提交
-
-
由 Douwe Maan 提交于
-
由 Douwe Maan 提交于
-
由 Douwe Maan 提交于
-
由 Douwe Maan 提交于
-
由 Douwe Maan 提交于
-
由 Jan Christophersen 提交于
-
由 Douwe Maan 提交于
-
由 Timothy Andrew 提交于
-
由 Timothy Andrew 提交于
- Add a `destroy_user` ability. This didn't exist before, and was implicit in other abilities (only admins could access the admin area, so only they could destroy all users; a user can only access their own account page, and so can destroy only themselves). - Grant this ability to admins, and when the current user is trying to destroy themselves. Disallow destroying ghost users in all cases. - Modify the `Users::DestroyService` to check this ability. Also check it in views to decide whether or not to show the "Delete User" button. - Add a short summary of the Ghost User to the bio.
-
由 Timothy Andrew 提交于
- Have `Uniquify` take a block instead of a Proc/function. This is more idiomatic than passing around a function in Ruby. - Block a user before moving their issues to the ghost user. This avoids a data race where an issue is created after the issues are migrated to the ghost user, and before the destroy takes place. - No need to migrate issues (to the ghost user) in a transaction, because we're using `update_all` - Other minor changes
-
由 Timothy Andrew 提交于
1. Refactoring and specs in the `Uniquify` class. 2. Don't use the `AdvisoryLocking` class. Similar functionality is provided (backed by Redis) in the `ExclusiveLease` class.
-
由 Timothy Andrew 提交于
Rather than using a separate `ghost` state. This lets us have the benefits of both ghost and blocked users (ghost: true, state: blocked) without having to rewrite a number of queries to include cases for `state: ghost`.
-
由 Timothy Andrew 提交于
1. Create a `Uniquify` class, which generalizes the process of generating unique strings, by accepting a function that defines what "uniqueness" means in a given context. 2. WIP: Make sure tests for `Namespace` pass, add more if necessary. 3. WIP: Add tests for `Uniquify`
-
由 Timothy Andrew 提交于
- "Associated" issues are issues the user has created + issues that the user is assigned to. - Issues that a user owns are transferred to a "Ghost User" (just a regular user with `state = 'ghost'` that is created when `User.ghost` is called). - Issues that a user is assigned to are moved to the "Unassigned" state. - Fix a spec failure in `profile_spec` — a spec was asserting that when a user is deleted, `User.count` decreases by 1. After this change, deleting a user creates (potentially) a ghost user, causing `User.count` not to change. The spec has been updated to look for the relevant user in the assertion.
-
由 Robert Schilling 提交于
-
由 Robert Schilling 提交于
-
由 Lin Jen-Shin 提交于
-
由 Mike Greiling 提交于
-
由 Mike Greiling 提交于
-
由 Mike Greiling 提交于
-
由 Alfredo Sumaran 提交于
-
由 Douwe Maan 提交于
-
由 Oswaldo 提交于
-
由 Jose Ivan Vargas 提交于
Now it appends a template instead of relying in a partial to show it.
-
由 Jose Ivan Vargas 提交于
Also changed the cookie sets to true and false values to make it consistent with the rest of the javascript. Fixed some haml and a missing new line
-
由 Jose Ivan Vargas 提交于
-
由 Jose Ivan Vargas 提交于
Also improved accesibility and change the id from user_callouts to a class
-
由 Jose Ivan Vargas 提交于
-