- 29 12月, 2015 3 次提交
-
-
由 Gabriel Mazetto 提交于
-
由 Yorick Peterse 提交于
-
由 Yorick Peterse 提交于
-
- 28 12月, 2015 7 次提交
-
-
由 Sytse Sijbrandij 提交于
-
由 Yorick Peterse 提交于
-
由 Sytse Sijbrandij 提交于
-
由 Stan Hu 提交于
-
由 Stan Hu 提交于
-
由 Sytse Sijbrandij 提交于
-
由 Sytse Sijbrandij 提交于
-
- 25 12月, 2015 1 次提交
-
-
由 Gabriel Mazetto 提交于
-
- 22 12月, 2015 1 次提交
-
-
由 Gabriel Mazetto 提交于
-
- 19 12月, 2015 1 次提交
-
-
由 Drew Blessing 提交于
-
- 18 12月, 2015 5 次提交
-
-
由 Yorick Peterse 提交于
This works by searching the raw source code for any references to commonly used ActiveRecord methods. While not bulletproof it saves us from having to list hundreds of methods by hand. It also ensures that (most) newly added methods are instrumented automatically. This _only_ instruments models defined in app/models, should a model reside somewhere else (e.g. somewhere in lib/) it _won't_ be instrumented.
-
由 Yorick Peterse 提交于
This ensures we don't end up wasting resources by tracking method calls that only take a few microseconds. By default the threshold is 10 milliseconds but this can be changed using the gitlab.yml configuration file.
-
由 Yorick Peterse 提交于
-
由 Yorick Peterse 提交于
The use of ActiveSupport would slow down instrumented method calls by about 180x due to: 1. ActiveSupport itself not being the fastest thing on the planet 2. caller_locations() having quite some overhead The use of caller_locations() has been removed because it's not _that_ useful since we already know the full namespace of receivers and the names of the called methods. The use of ActiveSupport has been replaced with some custom code that's generated using eval() (which can be quite a bit faster than using define_method). This new setup results in instrumented methods only being about 35-40x slower (compared to non instrumented methods).
-
由 Yorick Peterse 提交于
This adds the ability to write application metrics (e.g. SQL timings) to InfluxDB. These metrics can in turn be visualized using Grafana, or really anything else that can read from InfluxDB. These metrics can be used to track application performance over time, between different Ruby versions, different GitLab versions, etc. == Transaction Metrics Currently the following is tracked on a per transaction basis (a transaction is a Rails request or a single Sidekiq job): * Timings per query along with the raw (obfuscated) SQL and information about what file the query originated from. * Timings per view along with the path of the view and information about what file triggered the rendering process. * The duration of a request itself along with the controller/worker class and method name. * The duration of any instrumented method calls (more below). == Sampled Metrics Certain metrics can't be directly associated with a transaction. For example, a process' total memory usage is unrelated to any running transactions. While a transaction can result in the memory usage going up there's no accurate way to determine what transaction is to blame, this becomes especially problematic in multi-threaded environments. To solve this problem there's a separate thread that takes samples at a fixed interval. This thread (using the class Gitlab::Metrics::Sampler) currently tracks the following: * The process' total memory usage. * The number of file descriptors opened by the process. * The amount of Ruby objects (using ObjectSpace.count_objects). * GC statistics such as timings, heap slots, etc. The default/current interval is 15 seconds, any smaller interval might put too much pressure on InfluxDB (especially when running dozens of processes). == Method Instrumentation While currently not yet used methods can be instrumented to track how long they take to run. Unlike the likes of New Relic this doesn't require modifying the source code (e.g. including modules), it all happens from the outside. For example, to track `User.by_login` we'd add the following code somewhere in an initializer: Gitlab::Metrics::Instrumentation. instrument_method(User, :by_login) to instead instrument an instance method: Gitlab::Metrics::Instrumentation. instrument_instance_method(User, :save) Instrumentation for either all public model methods or a few crucial ones will be added in the near future, I simply haven't gotten to doing so just yet. == Configuration By default metrics are disabled. This means users don't have to bother setting anything up if they don't want to. Metrics can be enabled by editing one's gitlab.yml configuration file (see config/gitlab.yml.example for example settings). == Writing Data To InfluxDB Because InfluxDB is still a fairly young product I expect the worse. Data loss, unexpected reboots, the database not responding, you name it. Because of this data is _not_ written to InfluxDB directly, instead it's queued and processed by Sidekiq. This ensures that users won't notice anything when InfluxDB is giving trouble. The metrics worker can be started in a standalone manner as following: bundle exec sidekiq -q metrics The corresponding class is called MetricsWorker.
-
- 16 12月, 2015 1 次提交
-
-
由 Drew Blessing 提交于
-
- 15 12月, 2015 4 次提交
-
-
由 tduehr 提交于
-
由 Gabriel Mazetto 提交于
-
由 Drew Blessing 提交于
-
由 Gabriel Mazetto 提交于
-
- 12 12月, 2015 1 次提交
-
-
由 Kamil Trzcinski 提交于
-
- 11 12月, 2015 3 次提交
-
-
由 Grzegorz Bizon 提交于
-
由 Grzegorz Bizon 提交于
-
由 Gabriel Mazetto 提交于
-
- 10 12月, 2015 2 次提交
-
-
由 Kamil Trzcinski 提交于
-
由 Drew Blessing 提交于
Skipped CI because it has already passed. Had to rebase due to CHANGELOG.
-
- 09 12月, 2015 1 次提交
-
-
由 Douwe Maan 提交于
-
- 08 12月, 2015 3 次提交
-
-
由 Douwe Maan 提交于
-
由 Douwe Maan 提交于
-
由 Dmitriy Zaporozhets 提交于
Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 07 12月, 2015 1 次提交
-
-
由 Douwe Maan 提交于
-
- 05 12月, 2015 1 次提交
-
-
由 Stan Hu 提交于
Two issues: 1. The constraints in the resources were incorrect. Here's what it was before: ``` group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/} ``` In this case, id is actually the title of the milestone, which can be anything at the moment. After: ``` group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/} ``` 2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like: ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]): This change uses the babosa library to create a better slug, which surprisingly isn't actually used by the global milestone controllers. Instead, they use the title passed as a query string for some reason. Closes https://github.com/gitlabhq/gitlabhq/issues/9881 Fix constraints
-
- 04 12月, 2015 1 次提交
-
-
由 Gabriel Mazetto 提交于
Updated Sidekiq to 3.5.x
-
- 03 12月, 2015 1 次提交
-
-
由 Valery Sizov 提交于
-
- 01 12月, 2015 1 次提交
-
-
由 Douwe Maan 提交于
-
- 30 11月, 2015 2 次提交
-
-
由 Valery Sizov 提交于
-
由 Robert Speicher 提交于
-