- 02 7月, 2016 1 次提交
-
-
由 Grzegorz Bizon 提交于
-
- 30 6月, 2016 4 次提交
-
-
由 Paco Guzman 提交于
When pushing commits to existing branches we don’t need to flush branch git data (branch names / counts) When flushes the cache when pushing commits skip to flush branch and tag git data (names / counts) because those operations are managed explicitly in each case Repopulated expired cache as soon as possible
-
由 Grzegorz Bizon 提交于
This method now should return false if build is not completed. If build is running then it is not retryable, therefore `Ci::Build#retryable?` returned wrong value. This commit changes this behavior
-
由 Alejandro Rodríguez 提交于
-
由 Alejandro Rodríguez 提交于
-
- 29 6月, 2016 1 次提交
-
-
由 Tim 提交于
Requested in #14669 Added note to changelog
-
- 28 6月, 2016 1 次提交
-
-
由 Ruben Davila 提交于
This fix avoids exposing the information from the wiki repository of other project.
-
- 24 6月, 2016 1 次提交
-
-
由 Rémy Coutable 提交于
The issue was with the `User#groups` and `User#projects` associations which goes through the `User#group_members` and `User#project_members`. Initially I chose to use a secure approach by storing the requester's user ID in `Member#created_by_id` instead of `Member#user_id` because I was aware that there was a security risk since I didn't know the codebase well enough. Then during the review, we decided to change that and directly store the requester's user ID into `Member#user_id` (for the sake of simplifying the code I believe), meaning that every `group_members` / `project_members` association would include the requesters by default... My bad for not checking that all the `group_members` / `project_members` associations and the ones that go through them (e.g. `Group#users` and `Project#users`) were made safe with the `where(requested_at: nil)` / `where(members: { requested_at: nil })` scopes. Now they are all secure. Signed-off-by: NRémy Coutable <remy@rymai.me>
-
- 23 6月, 2016 3 次提交
-
-
由 Sean McGivern 提交于
Postgres and MySQL don't guarantee that pagination with `LIMIT` and `OFFSET` will work if the ordering isn't unique. From the Postgres docs: > When using `LIMIT`, it is important to use an `ORDER BY` clause that > constrains the result rows into a unique order. Otherwise you will get > an unpredictable subset of the query's rows Before: [1] pry(main)> issues = 1.upto(Issue.count).map { |i| Issue.sort('priority').page(i).per(1).map(&:id) }.flatten [2] pry(main)> issues.count => 81 [3] pry(main)> issues.uniq.count => 42 After: [1] pry(main)> issues = 1.upto(Issue.count).map { |i| Issue.sort('priority').page(i).per(1).map(&:id) }.flatten [2] pry(main)> issues.count => 81 [3] pry(main)> issues.uniq.count => 81
-
-
-
- 21 6月, 2016 3 次提交
-
-
由 Alejandro Rodríguez 提交于
A lot of git operations were being repeated, for example, to build a url you would ask if the path was a Tree, which would call a recursive routine in Gitlab::Git::Tree#where, then ask if the path was a Blob, which would call a recursive routine at Gitlab::Git::Blob#find, making reference to the same git objects several times. Now we call Rugged::Tree#path, which allows us to determine the type of the path in one pass. Some other minor improvement added, like saving commonly used references instead of calculating them each time.
-
由 Grzegorz Bizon 提交于
-
由 Paco Guzman 提交于
-
- 20 6月, 2016 2 次提交
-
-
由 Paco Guzman 提交于
-
由 Lin Jen-Shin 提交于
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12563922 For clarification and consistency
-
- 18 6月, 2016 1 次提交
-
-
由 Rémy Coutable 提交于
This is to ensure we don't send unwanted notifications when deleting a project. In other words, stop abusing AR callbacks and use services. Signed-off-by: NRémy Coutable <remy@rymai.me>
-
- 17 6月, 2016 1 次提交
-
-
由 Alejandro Rodríguez 提交于
-
- 16 6月, 2016 7 次提交
-
-
由 Yorick Peterse 提交于
This ensures that Project.find_with_namespace returns a row matching literally as the first value, instead of returning a random value. The ordering here is _only_ applied to Project.find_with_namespace and _not_ Project.where_paths_in as currently there's no code that requires Project.where_paths_in to return rows in a certain order. Since this method also returns all rows that match there's no real harm in not setting a specific order either. Another reason is that generating all the "WHEN" arms for multiple values in Project.where_paths_in becomes really messy. On MySQL we have to use the "BINARY" operator to turn a "WHERE" into a case-sensitive WHERE as otherwise MySQL may still end up returning rows in an unpredictable order. Fixes gitlab-org/gitlab-ce#18603
-
由 James Lopez 提交于
This reverts commit 13e37a3e.
-
由 James Lopez 提交于
-
由 Yorick Peterse 提交于
This allows the owners to be eager loaded where needed.
-
由 Ilan Shamir 提交于
- 15 6月, 2016 4 次提交
-
-
由 Felipe Artur 提交于
-
由 Grzegorz Bizon 提交于
-
由 Lin Jen-Shin 提交于
-
由 Grzegorz Bizon 提交于
This fixes compatibility with trigger request create service.
-
- 14 6月, 2016 11 次提交
-
-
由 Felipe Artur 提交于
-
由 Kamil Trzcinski 提交于
-
由 Grzegorz Bizon 提交于
-
由 Kamil Trzcinski 提交于
-
由 Rémy Coutable 提交于
+ Move 'Edit Project/Group' out of membership-related partial + Show the access request buttons only to logged-in users + Put the request access buttons out of in a more visible button + Improve the copy in the #remove_member_message helper Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 Rémy Coutable 提交于
Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 Kamil Trzcinski 提交于
-
由 Lin Jen-Shin 提交于
Feedback from: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12413950
-
由 Rémy Coutable 提交于
If one had configured a `teamcity_url` like http://foo.bar/teamcity in the previous implementation the plugin directed it's request i.e. to http://foo.bar/httpAuth/... instead of http://foo.bar/teamcity/httpAuth/... `URI.join` only works correctly, if the prefix URL has - at least one or more trailing '/' - the appended parts are _not_ prefixed with '/' The current implementation should work with all sorts of TeamCity base URLs. Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 Rémy Coutable 提交于
Signed-off-by: NRémy Coutable <remy@rymai.me>
-
-