- 02 7月, 2016 2 次提交
-
-
由 Grzegorz Bizon 提交于
-
由 Stan Hu 提交于
If a site specifies a relative URL root, emoji files would omit the path from the URL, leading to lots of 404s. Closes #15642
-
- 01 7月, 2016 2 次提交
-
-
由 James Lopez 提交于
-
由 Eric K Idema 提交于
This stands as an alternative to using OAuth to access a user's Github repositories. This is setup in such a way that it can be used without OAuth configuration. From a UI perspective, the how to import modal has been replaced by a full page, which includes a form for posting a personal access token back to the Import::GithubController. If the user has logged in via GitHub, skip the Personal Access Token and go directly to Github for an access token via OAuth.
-
- 30 6月, 2016 5 次提交
-
-
由 Grzegorz Bizon 提交于
-
由 Alejandro Rodríguez 提交于
-
由 Alejandro Rodríguez 提交于
-
由 Stan Hu 提交于
-
由 Stan Hu 提交于
If Redis were not running or USE_DB were set to false, the application settings retrieval would fail completely. This change only attempts to use the cache if the system actually wants to connect to the DB and rescues any failures in talking to Redis. Closes #17557
-
- 29 6月, 2016 4 次提交
-
-
由 Grzegorz Bizon 提交于
-
由 Grzegorz Bizon 提交于
-
由 James Lopez 提交于
-
由 James Lopez 提交于
-
- 28 6月, 2016 6 次提交
-
-
由 Yorick Peterse 提交于
Process.clock_gettime allows getting the real time in nanoseconds as well as allowing one to get a monotonic timestamp. This offers greater accuracy without the overhead of having to allocate a Time instance. In general using Time.now/Time.new is about 2x slower than using Process.clock_gettime(). For example: require 'benchmark/ips' Benchmark.ips do |bench| bench.report 'Time.now' do Time.now.to_f end bench.report 'clock_gettime' do Process.clock_gettime(Process::CLOCK_MONOTONIC, :millisecond) end bench.compare! end Running this benchmark gives: Calculating ------------------------------------- Time.now 108.052k i/100ms clock_gettime 125.984k i/100ms ------------------------------------------------- Time.now 2.343M (± 7.1%) i/s - 11.670M clock_gettime 4.979M (± 0.8%) i/s - 24.945M Comparison: clock_gettime: 4979393.8 i/s Time.now: 2342986.8 i/s - 2.13x slower Another benefit of using Process.clock_gettime() is that we can simplify the code a bit since it can give timestamps in nanoseconds out of the box.
-
由 http://jneen.net/ 提交于
-
由 http://jneen.net/ 提交于
-
由 http://jneen.net/ 提交于
-
由 http://jneen.net/ 提交于
-
由 http://jneen.net/ 提交于
paired with @stanhu
-
- 23 6月, 2016 3 次提交
-
-
由 Paco Guzman 提交于
-
由 James Lopez 提交于
-
由 Drew Blessing 提交于
-
- 21 6月, 2016 2 次提交
-
-
由 Kamil Trzcinski 提交于
-
由 ZJ van de Weg 提交于
-
- 18 6月, 2016 2 次提交
-
-
由 Yorick Peterse 提交于
Previously we'd create a separate Metric instance for every method call that would exceed the method call threshold. This is problematic because it doesn't provide us with information to accurately get the _total_ execution time of a particular method. For example, if the method "Foo#bar" was called 4 times with a runtime of ~10 milliseconds we'd end up with 4 different Metric instances. If we were to then get the average/95th percentile/etc of the timings this would be roughly 10 milliseconds. However, the _actual_ total time spent in this method would be around 40 milliseconds. To solve this problem we now create a single Metric instance per method. This Metric instance contains the _total_ real/CPU time and the call count for every instrumented method.
-
由 Paco Guzman 提交于
-
- 17 6月, 2016 3 次提交
-
-
由 Grzegorz Bizon 提交于
-
由 Grzegorz Bizon 提交于
This follows a standard `ActiveModel` pattern of creating a custom validators. We use `ActiveModel::EachValidator` here that reuses methods provided by `LegacyValidationHelpers`. We will remove `LegacyValidationHelpers` on some point in the future, at the later stages of CI configuration refactoring. It may be possible to rewrite custom validators to use format like: `validates :config, array_of: String`
-
由 Grzegorz Bizon 提交于
-
- 16 6月, 2016 4 次提交
-
-
由 Grzegorz Bizon 提交于
This makes use of `ActiveModel::Validations` encapsulated in a separate class that is accessible from a node object.
-
由 James Lopez 提交于
This reverts commit 13e37a3e.
-
由 James Lopez 提交于
-
由 Ilan Shamir 提交于
-
- 15 6月, 2016 6 次提交
-
-
由 Yorick Peterse 提交于
This ensures that whatever locks are acquired aren't held onto until the end of the transaction (= after _all_ rows have been updated). Timing wise there's also no difference between using a transaction and not using one.
-
由 Yorick Peterse 提交于
By passing a block to update_column_in_batches() one can now customize the queries executed. This in turn can be used to only update a specific set of rows instead of simply all the rows in the table.
-
由 Grzegorz Bizon 提交于
-
由 James Lopez 提交于
-
由 James Lopez 提交于
-
由 Yorick Peterse 提交于
We can't do a lot with classes without names as we can't filter by them, have no idea where they come from, etc. As such it's best to just ignore these.
-
- 14 6月, 2016 1 次提交
-
-
由 Paco Guzman 提交于
By default instrumentation will instrument public, protected and private methods, because usually heavy work is done on private method or at least that’s what facts is showing
-