1. 27 8月, 2019 3 次提交
    • O
      Avoid exposing unaccessible repo data upon GFM processing · 9dde7259
      Oswaldo Ferreira 提交于
      When post-processing relative links to absolute links
      RelativeLinkFilter didn't take into consideration that
      internal repository data could be exposed for users
      that do not have repository access to the project.
      
      This commit solves that by checking whether the user
      can `download_code` at this repository, avoiding any
      processing of this filter if the user can't.
      
      Additionally, if we're processing for a group (
      no project was given), we check if the user can
      read it in order to expand the href as an extra.
      That doesn't seem necessarily a breach now,
      but an extra check doesn't hurt as after all
      the user needs to be able to `read_group`.
      9dde7259
    • G
      Merge branch 'security-2853-prevent-comments-on-private-mrs-12-2' into '12-2-stable' · f73a46ca
      GitLab Release Tools Bot 提交于
      Ensure only authorised users can create notes on merge requests and issues
      
      See merge request gitlab/gitlabhq!3324
      f73a46ca
    • A
      Prevent unauthorised comments on merge requests · d9ecd83c
      Alex Kalderimis 提交于
      * Prevent creating notes on inaccessible MRs
      
      This applies the notes rules at the MR scope. Rather than adding extra
      rules to the Project level policy, preventing :create_note here is
      better since it only prevents creating notes on MRs.
      
      * Prevent creating notes in inaccessible Issues
      
      without this policy, non-team-members are allowed to comment on issues
      even when the project has the private-issues policy set. This means that
      without this change, users are allowed to comment on issues that they
      cannot read.
      
      * Add CHANGELOG entry
      d9ecd83c
  2. 26 8月, 2019 22 次提交
  3. 24 8月, 2019 3 次提交
  4. 23 8月, 2019 12 次提交
    • S
      Merge branch 'master' into 'master' · 41f47198
      Stan Hu 提交于
      Reduce dedup calls to gc only
      
      See merge request gitlab-org/gitlab-ce!32083
      41f47198
    • N
      Send TODOs for comments on commits correctly · 89ced3fb
      Nick Thomas 提交于
      At present, the TodoService uses the `:read_project` ability to decide
      whether a user can read a note on a commit. However, commits can have a
      visibility level that is more restricted than the project, so this is a
      security issue.
      
      This commit changes the code to use the `:read_commit` ability in this
      case instead, which ensures TODOs are only generated for commit notes
      if the users can see the commit.
      89ced3fb
    • M
      Merge branch 'sh-revert-redis-cache-store' into 'master' · a81d63d5
      Mayra Cabrera 提交于
      Fix "ERR value is not an integer or out of range" errors
      
      Closes #66449
      
      See merge request gitlab-org/gitlab-ce!32126
      
      (cherry picked from commit 8832aa95)
      
      6bda359b Fix "ERR value is not an integer or out of range" errors
      a81d63d5
    • C
      Merge branch 'tr-param-undefined-fix' into 'master' · 8d6156cd
      Clement Ho 提交于
      Embed metrics undefined param fix
      
      Closes #66177
      
      See merge request gitlab-org/gitlab-ce!31975
      
      (cherry picked from commit 04b37e42)
      
      1ebc87e9 Remove dashboard param when undefined
      8122a21a Insert additional assertion
      2c4e17f9 Ensure all params have the option to be dropped when falsy
      3812e4f3 Use isNil check
      5ed2c263 Add tests and null check
      2ebe1715 Add change log entry
      8d6156cd
    • A
      Merge branch 'docs/clarify-new-values' into 'master' · 0aed49db
      Achilleas Pipinellis 提交于
      Clarify when new values are valid
      
      See merge request gitlab-org/gitlab-ce!31951
      
      (cherry picked from commit 47c069cc)
      
      1efa52be Clarify when new values are valid
      0aed49db
    • S
      Merge branch 'sh-fix-issues-api-gitaly-nplusone' into 'master' · bdc80896
      Sean McGivern 提交于
      Fix Gitaly N+1 calls with listing issues/MRs via API
      
      Closes #66202
      
      See merge request gitlab-org/gitlab-ce!31938
      
      (cherry picked from commit 57ec78d5)
      
      ba7c501f Fix Gitaly N+1 calls with listing issues/MRs via API
      bdc80896
    • E
      Merge branch 'docs-userid-ff' into 'master' · 21a6f54a
      Evan Read 提交于
      Add Documentation for Feature Flag Target Users
      
      Closes gitlab-ee#11459
      
      See merge request gitlab-org/gitlab-ce!31918
      
      (cherry picked from commit 69df0594)
      
      c42f5bbc Add documentation for feature flag Target Users
      21a6f54a
    • A
      Merge branch '62971-embed-specific-metrics-chart-in-issue-docs' into 'master' · 38e796ba
      Achilleas Pipinellis 提交于
      Embed specific metrics chart in issue docs
      
      See merge request gitlab-org/gitlab-ce!31900
      
      (cherry picked from commit aed489bf)
      
      482642b0 Adds specific metric styles and prop
      146243da Updated styles, removed css :D
      0a5d49f7 Adds docs for embedding chart
      4bbb0ddf Simpler null checks
      758a195b Fix some wrapping issues
      d6550ad4 Fix lint and prop type
      675639cc Remove everything that isn't docs
      eb27d0f1 Apply suggestion to doc/user/project/integrations/prometheus.md
      364e7219 Compress generate_link_to_chart.png image
      38e796ba
    • E
      Merge branch 'docs-66076-expansion-options' into 'master' · 8e15396b
      Evan Read 提交于
      Add documentation for incrementally expand mr diffs
      
      See merge request gitlab-org/gitlab-ce!31878
      
      (cherry picked from commit 0a16c8e1)
      
      c867db91 Add documentation for incrementally expand mr diffs
      e9d917c2 Apply suggestion to doc/user/project/merge_requests/index.md
      8e15396b
    • A
      Merge branch... · 34cb960a
      Achilleas Pipinellis 提交于
      Merge branch '64950-move-download-csv-button-functionality-in-metrics-dashboard-cards-into-the-dropdown' into 'master'
      
      Add docs for csv download
      
      Closes #66291
      
      See merge request gitlab-org/gitlab-ce!31870
      
      (cherry picked from commit 8b0acc31)
      
      40327645 Adds docs for downloading csv
      11f959ad Compress download_as_csv.png image
      5cf5a52f Merge remote-tracking branch 'origin/master' into...
      34cb960a
    • E
      Merge branch 'docs-update-design-management-limitations' into 'master' · 6127c156
      Evan Read 提交于
      Link more issues in Design Management Limitations
      
      See merge request gitlab-org/gitlab-ce!31697
      
      (cherry picked from commit e40abf97)
      
      50956e5c Link more issues in Design Management Limitations
      6127c156
    • A
      Merge branch 'docs/license-compliance' into 'master' · 56fe1b1c
      Achilleas Pipinellis 提交于
      Rename License Management to License Compliance
      
      Closes #63329
      
      See merge request gitlab-org/gitlab-ce!31590
      
      (cherry picked from commit 11fd6bdf)
      
      80b05132 Rename License Management to License Compliance
      56fe1b1c