- 22 12月, 2016 1 次提交
-
-
由 Tiago Botelho 提交于
-
- 21 12月, 2016 8 次提交
-
-
由 James Lopez 提交于
-
由 James Lopez 提交于
-
由 Filipa Lacerda 提交于
Fix broken test Remove spinach tests for the builds tab
-
由 Filipa Lacerda 提交于
Remove unused file Fix commit link
-
由 Filipa Lacerda 提交于
Fix specs
-
由 James Lopez 提交于
-
由 Kamil Trzcinski 提交于
-
由 James Lopez 提交于
-
- 20 12月, 2016 11 次提交
-
-
由 Kamil Trzcinski 提交于
-
由 Kamil Trzcinski 提交于
-
由 Kamil Trzcinski 提交于
- Add proper error handling, - Use flash[:alert] and flash[:notice], - Use `resource` instead of `resources`,
-
由 Fatih Acet 提交于
-
由 Z.J. van de Weg 提交于
[ci skip]
-
由 Nick Thomas 提交于
-
由 Rémy Coutable 提交于
Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 Rémy Coutable 提交于
Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 Rémy Coutable 提交于
The reason is that Gitea plan to be GitHub-compatible so it makes sense to just modify GitHubImport a bit for now, and hopefully we can change it to GitHubishImport once Gitea is 100%-compatible. Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 Rémy Coutable 提交于
Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 Kim "BKC" Carlbäcker 提交于
-
- 19 12月, 2016 1 次提交
-
-
由 Kamil Trzcinski 提交于
``` Endpoint: /group/project/pipelines/id/stage.json?stage=name Call: stage_namespace_project_pipeline_path(pipeline.project.namespace, pipeline.project, pipeline, stage: stage.name) ```
-
- 18 12月, 2016 1 次提交
-
-
由 Jeff Stubler 提交于
Closes #25761.
-
- 17 12月, 2016 7 次提交
-
-
-
-
-
由 Nur Rony 提交于
-
-
由 Z.J. van de Weg 提交于
-
由 Rydkin Maxim 提交于
-
- 16 12月, 2016 7 次提交
-
-
由 Z.J. van de Weg 提交于
-
由 Drew Blessing 提交于
The two factor authentication account string only had the user's email address. This led to ambiguous entries in two factor code generating apps. This adds the GitLab host to the account string in the standard format (according to Google). No matter the code generator this change disambiguates the entry.
-
由 Z.J. van de Weg 提交于
-
由 Z.J. van de Weg 提交于
-
由 Z.J. van de Weg 提交于
-
由 Timothy Andrew 提交于
- Mainly whitespace changes. - Require the migration adding the `scope` column to the `personal_access_tokens` table to have downtime, since API calls will fail if the new code is in place, but the migration hasn't run. - Minor refactoring - load `@scopes` in a `before_action`, since we're doing it in three different places.
-
由 Timothy Andrew 提交于
-
- 15 12月, 2016 4 次提交
-
-
由 Luke Bennett 提交于
Finished up autocomplete_sources action and added frontend to fetch data only when its needed Added wait_for_ajax to specs Fixed builds and improved the setup/destroy lifecycle Changed global namespace and DRYed up loading logic Added safety for accidentally loading data twice Removed destroy as its not necessary and is messing with click events from a blur race condition Created AutocompleteSourcesController and updated routes Fixed @undefined from tabbing before load ends Disable tabSelectsMatch until we have loaded data Review changes
-
由 Douwe Maan 提交于
Fix missing Note access checks in by moving Note#search to updated NoteFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ## Which fixes are in this MR?
⚠ - Potentially untested💣 - No test coverage🚥 - Test coverage of some sort exists (a test failed when error raised)🚦 - Test coverage of return value (a test failed when nil used)✅ - Permissions check tested ### Note lookup without access check - [x]✅ app/finders/notes_finder.rb:13 :download_code check - [x]✅ app/finders/notes_finder.rb:19 `SnippetsFinder` - [x]✅ app/models/note.rb:121 [`Issue#visible_to_user`] - [x]✅ lib/gitlab/project_search_results.rb:113 - This is the only use of `app/models/note.rb:121` above, but importantly has no access checks at all. This means it leaks MR comments and snippets when those features are `team-only` in addition to the issue comments which would be fixed by `app/models/note.rb:121`. - It is only called from SearchController where `can?(current_user, :download_code, @project)` is checked, so commit comments are not leaked. ### Previous discussions - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b915c5267a63628b0bafd23d37792ae73ceae272_13_13 `: download_code` check on commit - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b915c5267a63628b0bafd23d37792ae73ceae272_19_19 `SnippetsFinder` should be used - `SnippetsFinder` should check if the snippets feature is enabled -> https://gitlab.com/gitlab-org/gitlab-ce/issues/25223 ### Acceptance criteria met? - [x] Tests added for new code - [x] TODO comments removed - [x] Squashed and removed skipped tests - [x] Changelog entry - [ ] State Gitlab versions affected and issue severity in description - [ ] Create technical debt issue for NotesFinder. - Either split into `NotesFinder::ForTarget` and `NotesFinder::Search` or consider object per notable type such as `NotesFinder::OnIssue`. For the first option could create `NotesFinder::Base` which is either inherited from or which can be included in the other two. - Avoid case statement anti-pattern in this finder with use of `NotesFinder::OnCommit` etc. Consider something on the finder for this? `Model.finder(user, project)` - Move `inc_author` to the controller, and implement `related_notes` to replace `non_diff_notes`/`mr_and_commit_notes` See merge request !2035 -
由 Valery Sizov 提交于
-
由 Nick Thomas 提交于
-