1. 02 5月, 2019 1 次提交
    • J
      Add opentracing integration for graphql · 96750fac
      Jan Provaznik 提交于
      Extends existing graphql's tracer with opentracing measurements. Because
      it also adds Tracing::Graphql class (for opentracing), it also renames
      Graphql::Tracing class to Graphql::GenericTracing to minimize confusion
      with similar class names.
      96750fac
  2. 01 5月, 2019 3 次提交
  3. 30 4月, 2019 4 次提交
  4. 29 4月, 2019 5 次提交
    • S
      Fix slow performance with compiling HAML templates · b02458ef
      Stan Hu 提交于
      In Rails 5, including `ActionView::Context` can have a significant and
      hidden performance penalty because this module also includes
      `ActionView::CompiledTemplates`. This means that any module that
      includes ActionView::Context becomes a descendant of
      `CompiledTemplates`.
      
      When a partial is rendered for the first time, it runs
      `ActionView::CompiledTemplates#module_eval`, which will evaluate a
      string that defines a new method for that partial. For example, the
      source of partial might be this string:
      
      ```
      def _app_views_project_show_html_haml___12345(local_assigns, output)
        "hello world"
      end
      ```
      
      When this string is evaluated, the Ruby interpreter will define the
      method and clear the global method cache for all descendants of
      `ActionView::CompiledTemplates`. Previous to this change, we
      inadvertently made a number of modules fall into this category:
      
      * GroupChildEntity
      * NoteUserEntity
      * Notify
      * MergeRequestUserEntity
      * AnalyticsCommitEntity
      * CommitEntity
      * UserEntity
      * Kaminari::Helpers::Paginator
      * CurrentUserEntity
      * ActionView::Base
      * ActionDispatch::DebugExceptions::DebugView
      * MarkupHelper
      * MergeRequestPresenter
      
      After this change:
      
      * Kaminari::Helpers::Paginator
      * ActionView::Base
      * ActionDispatch::DebugExceptions::DebugView
      
      Each time a partial is rendered for the first time, all methods for
      those modules will have to be redefined. This can exact a significant
      performance penalty.
      
      How bad is this penalty? Using the following benchmark script, we can
      use DTrace to sample the Ruby interpreter:
      
      ```
      Benchmark.bm do |x|
        x.report do
          1000.times do
            ActionView::CompiledTemplates.module_eval("def testme\nend")
          end
        end
      end
      ```
      
      This revealed a 11x jump in the time spent in `core#define_method`
      alone.
      
      Rails 6 fixes this behavior by moving the `include CompiledTemplates`
      into ActionView::Base so that including `ActionView::Context` doesn't
      quietly affect other modules in this way.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11198
      b02458ef
    • P
      Use correct k8s namespace in Prometheus queries · de69a808
      Peter Leitzen 提交于
      Before this commit the wrong namespace could have been used in
      Prometheus queries for group-level installations.
      de69a808
    • J
      Add gitaly session id & catfile-cache feature flag · fe31f63c
      John Cai 提交于
      fe31f63c
    • B
      Port changes for design management to CE · 33cf8eda
      Bob Van Landuyt 提交于
      This ports the changes from
      https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10462/
      to CE
      33cf8eda
    • H
      Change path of bin/sidkiq-cluster in comments · 6229a458
      Hossein Pursultani 提交于
      `sidekiq-cluster` is moved from `bin/` to `ee/bin` in EE code. This
      is a corresponding change in CE.
      6229a458
  5. 27 4月, 2019 4 次提交
  6. 26 4月, 2019 3 次提交
  7. 25 4月, 2019 6 次提交
  8. 24 4月, 2019 11 次提交
  9. 23 4月, 2019 3 次提交