1. 15 7月, 2019 1 次提交
  2. 11 7月, 2019 1 次提交
  3. 08 7月, 2019 1 次提交
    • S
      Fix race condition on merge train ref generation · f8d6f732
      Shinya Maeda 提交于
      Today, Pipelines for merge train run on `refs/merge`,
      however, this causes a race condition that it can be
      overwritten by CheckMergeabilityService.
      
      This patch fixes the problem by generating `refs/train`
      for those pipelines.
      f8d6f732
  4. 04 7月, 2019 1 次提交
    • N
      Allow asynchronous rebase operations to be monitored · 381468d0
      Nick Thomas 提交于
      This MR introduces tracking of the `rebase_jid` for merge requests. As
      with `merge_ongoing?`, `rebase_in_progress?` will now return true if a
      rebase is proceeding in sidekiq.
      
      After one release, we should remove the Gitaly-based lookup of rebases.
      It is much better to track this kind of thing via the database.
      381468d0
  5. 03 7月, 2019 1 次提交
  6. 25 6月, 2019 2 次提交
    • F
      Use actual_head_pipeline to enforce presence · e236fbdb
      Fabio Pitino 提交于
      e236fbdb
    • F
      Require pipeline if "Pipeline must succeed" is set · a26916d1
      Fabio Pitino 提交于
      When a user sets only_allow_merge_if_pipeline_succeeds, also named
      as "Pipeline must succeed" project setting, we require the pipeline
      to be present.
      
      This solves race condition issues especially with external CI
      providers when a build is triggered externally but no pipelines are
      created in GitLab yet.
      
      Document that a head pipeline is expected when using "Pipeline
      must succeed" setting. Also explain limitations with the use of
      only/except where there may not be any jobs created and the merge
      request will not be allowed to be merged.
      a26916d1
  7. 21 6月, 2019 1 次提交
  8. 20 6月, 2019 1 次提交
    • O
      Automatically update MR merge-ref along merge status · 3af348b6
      Oswaldo Ferreira 提交于
      This couples the code that transitions the `MergeRequest#merge_status`
      and refs/merge-requests/:iid/merge ref update.
      
      In general, instead of directly telling `MergeToRefService` to update
      the merge ref, we should rely on `MergeabilityCheckService` to keep
      both the merge status and merge ref synced. Now, if the merge_status is
      `can_be_merged` it means the merge-ref is also updated to the latest.
      
      We've also updated the logic to be more systematic and less user-based.
      3af348b6
  9. 13 6月, 2019 1 次提交
  10. 12 6月, 2019 1 次提交
  11. 06 6月, 2019 1 次提交
  12. 03 6月, 2019 1 次提交
    • S
      Abstract auto merge processes · d4b46936
      Shinya Maeda 提交于
      We have one auto merge strategy today - Merge When Pipeline
      Succeeds.
      
      In order to add more strategies for Merge Train feature,
      we abstract the architecture to be more extensible.
      
      Removed arguments
      
      Fix spec
      d4b46936
  13. 01 6月, 2019 3 次提交
    • O
      Add payload to the service response · 4246a621
      Oswaldo Ferreira 提交于
      This introduces payload to the ServiceResponse with
      the merge ref HEAD commit data
      4246a621
    • O
      Simplify merge_ref_head methods · 96db70a4
      Oswaldo Ferreira 提交于
      96db70a4
    • O
      Automatically update MR merge-ref along merge status · b965009d
      Oswaldo Ferreira 提交于
      This couples the code that transitions the `MergeRequest#merge_status`
      and refs/merge-requests/:iid/merge ref update.
      
      In general, instead of directly telling `MergeToRefService` to update
      the merge ref, we should rely on `MergeabilityCheckService` to keep
      both the merge status and merge ref synced. Now, if the merge_status is
      `can_be_merged` it means the merge-ref is also updated to the latest.
      
      We've also updated the logic to be more systematic and less user-based.
      b965009d
  14. 22 5月, 2019 1 次提交
    • S
      Fix remaining failures in shoulda-matcher · 37a335e6
      Stan Hu 提交于
      Starting with Rails 5, belongs_to now adds a presence validation to the
      association, and so as of shoulda-matchers 4.0.0 the belong_to matcher
      follows suit and tests that this validation is there by setting the
      association to nil and asserting that there are validation errors. This
      exposed an error with the `validate_branches` method: we need to check
      the source and target project exist.
      37a335e6
  15. 06 5月, 2019 1 次提交
  16. 03 5月, 2019 1 次提交
    • M
      Validate MR branch names · d8bddb16
      Mark Chao 提交于
      Prevents refspec as branch name, which would bypass branch protection
      when used in conjunction with rebase.
      
      HEAD seems to be a special case with lots of occurrence,
      so it is considered valid for now.
      
      Another special case is `refs/head/*`, which can be imported.
      d8bddb16
  17. 30 4月, 2019 1 次提交
    • S
      Fix environment automatic on_stop trigger · daa8f784
      Shinya Maeda 提交于
      Due to the nature of pipelines for merge requests, deployments.ref can
      be a merge request ref instead of a branch name.
      
      We support the environment auto-stop hook for this case
      daa8f784
  18. 23 4月, 2019 1 次提交
  19. 16 4月, 2019 1 次提交
  20. 09 4月, 2019 1 次提交
  21. 02 4月, 2019 2 次提交
  22. 01 4月, 2019 2 次提交
  23. 29 3月, 2019 2 次提交
  24. 27 3月, 2019 1 次提交
  25. 26 3月, 2019 1 次提交
  26. 21 3月, 2019 1 次提交
    • N
      Update merge request widget pipeline block · 7e6b5749
      Nathan Friend 提交于
      This commit updates the pipeline block that appears on the merge request
      page to include information that will be exposed by the API as part of
      the post-merge pipeline feature.
      7e6b5749
  27. 13 3月, 2019 1 次提交
  28. 09 3月, 2019 1 次提交
  29. 06 3月, 2019 1 次提交
  30. 05 3月, 2019 2 次提交
  31. 25 2月, 2019 1 次提交
    • O
      Support merge to ref for merge-commit and squash · 1ad69967
      Oswaldo Ferreira 提交于
      Adds the ground work for writing into
      the merge ref refs/merge-requests/:iid/merge the
      merge result between source and target branches of
      a MR, without further side-effects such as
      mailing, MR updates and target branch changes.
      1ad69967
  32. 15 2月, 2019 2 次提交