Skip to content

G
gitlab-foss

李少辉-开发者 / gitlab-foss

通知 15
Star 0
Fork 0
G
gitlab-foss

体验新版 GitCode，发现更多精彩内容 >>

切换分支/标签
  1. 24 6月, 2016 33 次提交
  3. 23 6月, 2016 7 次提交
    • N
      Fix user creation with stronger minimum password requirements:q · 64883faa
      由 Nathan Bush 提交于
      64883faa
    • S
      Fix merge requests project settings help link anchor. · 23c898fc
      由 Steve Norman 提交于
      23c898fc
    • R
      Merge branch '18915-pagination-with-priority-sort-repeats-results' into 'master' · 26b95777
      由 Rémy Coutable 提交于 
      Fix pagination on sorts with lots of ties

## What does this MR do?

Fixes #18915. As we only order by the sorted column, we don't have any tie-breaker. Some orderings, like priority and weight, have lots of ties, so you can see duplicate results as you page through. (Timestamp columns are less susceptible to this.)

## Are there points in the code the reviewer needs to double check?

I just picked `id DESC`, this could as easily be `id ASC`.

## Why was this MR needed?

Postgres and MySQL don't guarantee that pagination with `LIMIT` and
`OFFSET` will work as expected if the ordering isn't unique. From the Postgres docs:

> When using `LIMIT`, it is important to use an `ORDER BY` clause that
> constrains the result rows into a unique order. Otherwise you will get
> an unpredictable subset of the query's rows

Before:

    [1] pry(main)> issues = 1.upto(Issue.count).map { |i| Issue.sort('priority').page(i).per(1).map(&:id) }.flatten
    [2] pry(main)> issues.count
    => 81
    [3] pry(main)> issues.uniq.count
    => 42

After:

    [1] pry(main)> issues = 1.upto(Issue.count).map { |i| Issue.sort('priority').page(i).per(1).map(&:id) }.flatten
    [2] pry(main)> issues.count
    => 81
    [3] pry(main)> issues.uniq.count
    => 81

See merge request !4878
      26b95777
    • R
      Merge branch 'fix-clickable-code-search-results' into 'master' · 110b2759
      由 Robert Speicher 提交于 
      Fix clickable code search results

Closes #17860

See merge request !4654
      110b2759
    • K
      Fix 404 when accessing pipelines as guest user on public projects · 3aaf04ce
      由 Kamil Trzcinski 提交于
      3aaf04ce
    • K
      Fix 404 for pipelines · aa05fbc0
      由 Kamil Trzcinski 提交于
      aa05fbc0
    • S
      Fix pagination on sorts with lots of ties · d7a5a28c
      由 Sean McGivern 提交于 
      Postgres and MySQL don't guarantee that pagination with `LIMIT` and
`OFFSET` will work if the ordering isn't unique. From the Postgres docs:

> When using `LIMIT`, it is important to use an `ORDER BY` clause that
> constrains the result rows into a unique order. Otherwise you will get
> an unpredictable subset of the query's rows

Before:

    [1] pry(main)> issues = 1.upto(Issue.count).map { |i| Issue.sort('priority').page(i).per(1).map(&:id) }.flatten
    [2] pry(main)> issues.count
    => 81
    [3] pry(main)> issues.uniq.count
    => 42

After:

    [1] pry(main)> issues = 1.upto(Issue.count).map { |i| Issue.sort('priority').page(i).per(1).map(&:id) }.flatten
    [2] pry(main)> issues.count
    => 81
    [3] pry(main)> issues.uniq.count
    => 81
      d7a5a28c