- 01 2月, 2017 40 次提交
-
-
由 Yorick Peterse 提交于
-
由 Grzegorz Bizon 提交于
-
由 Valery Sizov 提交于
-
由 Timothy Andrew 提交于
================== = Implementation = ================== 1. The path of the page is of the form 'group/project/pages/domains/<domain_name>' 2. Rails looks at `params[:id]` (which should be the domain name), and finds the relevant model record. 3. Given a domain like `foo.bar`, Rails sets `params[:id]` to `foo` (should be `foo.bar`), and sets `params[:format]` to `bar` 4. This commit fixes the issue by adding a route constraint, so that `params[:id]` is set to the entire `foo.bar` domain name. ========= = Tests = ========= 1. Add controller specs for the `PagesDomainController`. These are slightly orthogonal to this bug fix (they don't fail when this bug is present), but should be present nonetheless. 2. Add routing specs that catch this bug (by asserting that the `id` param is passed as expected when it contains a domain name). 3. Modify the 'RESTful project resources' routing spec shared example to accomodate controllers where the controller path (such as `pages/domains`) is different from the controller name (such as `pages_domains`).
-
由 James Edwards-Jones 提交于
-
由 James Edwards-Jones 提交于
-
由 Achilleas Pipinellis 提交于
Fixes https://gitlab.com/gitlab-org/gitlab-ee/issues/1333 [ci skip]
-
由 Achilleas Pipinellis 提交于
[ci skip]
-
由 Lin Jen-Shin 提交于
-
由 Kamil Trzcinski 提交于
-
由 Lin Jen-Shin 提交于
-
由 Lin Jen-Shin 提交于
-
由 Lin Jen-Shin 提交于
Closes #323
-
由 Connor Shea 提交于
Adds algorithm to the pages domain key and remote mirror credentials encrypted attributes for forward compatibility with attr_encrypted 3.0.0. aes-256-cbc is the default algorithm for attr_encrypted 1.x, but the default is changed in 3.0 and thus must be declared explicitly. See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4216/ for more information. This will prevent OpenSSL errors once the code from that MR is merged into EE.
-
由 Kamil Trzcinski 提交于
-
由 Nick Thomas 提交于
-
由 Kamil Trzcinski 提交于
-
由 Kamil Trzcinski 提交于
-
由 Heather McNamee 提交于
-
由 Achilleas Pipinellis 提交于
[ci skip]
-
由 Achilleas Pipinellis 提交于
-
由 Achilleas Pipinellis 提交于
[ci skip]
-
由 Achilleas Pipinellis 提交于
[ci skip]
-
由 Achilleas Pipinellis 提交于
-
由 Achilleas Pipinellis 提交于
[ci skip]
-
由 Achilleas Pipinellis 提交于
[ci skip]
-
由 Achilleas Pipinellis 提交于
-
由 Achilleas Pipinellis 提交于
-
由 Achilleas Pipinellis 提交于
-
由 Achilleas Pipinellis 提交于
-
由 Achilleas Pipinellis 提交于
[ci skip]
-
由 Achilleas Pipinellis 提交于
[ci skip]
-
由 Achilleas Pipinellis 提交于
[ci skip]
-
由 Achilleas Pipinellis 提交于
-
由 Achilleas Pipinellis 提交于
- Finish user/group/project sections - Give more .gitlab-ci.yml examples [ci skip]
-
由 Achilleas Pipinellis 提交于
-
由 Achilleas Pipinellis 提交于
-
由 Achilleas Pipinellis 提交于
-
由 Achilleas Pipinellis 提交于
-