1. 22 6月, 2015 11 次提交
    • D
      Merge branch 'new-logo' into 'master' · 9179dc6d
      Dmitriy Zaporozhets 提交于
      Replace old logo with new one
      Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
      
      cc @JobV @sytses
      
      See merge request !848
      9179dc6d
    • D
      Merge branch 'web-editor-autocrlf' into 'master' · 75f7a964
      Dmitriy Zaporozhets 提交于
      Convert CRLF newlines to LF when committing using the web editor.
      
      Fixes #1823 and https://github.com/gitlabhq/gitlabhq/issues/7950.
      
      Depends on https://gitlab.com/gitlab-org/gitlab_git/merge_requests/29 being merged and a new gitlab_git being released.
      
      cc @jacobvosmaer
      
      See merge request !858
      75f7a964
    • J
      Merge branch 'change_log_update' into 'master' · 29069abe
      Jacob Vosmaer 提交于
      Minor changelog fix
      
      See merge request !861
      29069abe
    • D
      Merge branch 'restore_uploads_fix' into 'master' · 0214a21d
      Dmitriy Zaporozhets 提交于
      Avoid "cannot copy directory ... to itself" error on restore (on Docker?)
      
      rake gitlab:backup:restore fails for me in my Docker-hosted Gitlab-CE instance; during the restore, any existing "uploads" directory is backed up by [this code](https://gitlab.com/gitlab-org/gitlab-ce/blob/833bc30/lib/backup/uploads.rb#L23) --
      
      ```ruby
          def backup_existing_uploads_dir
            timestamped_uploads_path = File.join(app_uploads_dir, '..', "uploads.#{Time.now.to_i}")
            if File.exists?(app_uploads_dir)
              FileUtils.mv(app_uploads_dir, timestamped_uploads_path)
            end
          end
      ```
      
      When this executes for me, the ```FileUtils.mv``` parameters are "/home/git/gitlab/public/uploads" and "/home/git/gitlab/public/uploads/../uploads.1407019546"; an exception is raised, producing this double stacktrace:
      
      ```
      ArgumentError: cannot copy directory /home/git/gitlab/public/uploads to itself /home/git/gitlab/public/uploads/../uploads.1407019546
      /home/git/gitlab/lib/backup/uploads.rb:26:in `backup_existing_uploads_dir'
      /home/git/gitlab/lib/backup/uploads.rb:18:in `restore'
      /home/git/gitlab/lib/tasks/gitlab/backup.rake:73:in `block (4 levels) in <top (required)>'
      /home/git/gitlab/lib/tasks/gitlab/backup.rake:30:in `block (3 levels) in <top (required)>'
      Errno::EXDEV: Invalid cross-device link @ sys_fail2 - (/home/git/gitlab/public/uploads, /home/git/gitlab/public/uploads/../uploads.1407019546)
      /home/git/gitlab/lib/backup/uploads.rb:26:in `backup_existing_uploads_dir'
      /home/git/gitlab/lib/backup/uploads.rb:18:in `restore'
      /home/git/gitlab/lib/tasks/gitlab/backup.rake:73:in `block (4 levels) in <top (required)>'
      /home/git/gitlab/lib/tasks/gitlab/backup.rake:30:in `block (3 levels) in <top (required)>'
      Tasks: TOP => gitlab:backup:uploads:restore
      (See full trace by running task with --trace)
      ```
      
      I'm guessing from the first message that ```mv``` walks the destination path to ensure that we're not moving the source into itself -- it doesn't get as far as interpreting the '..', but throws when it sees that the destination appears to start with the source path.
      
      The second stacktrace I have no clue about - maybe it's AUFS- or Docker-related?
      
      I attempted to reproduce this separately with the omnibus distribution in a fresh Ubuntu 14.04 install without Docker involved, and was unable to - backup and restore worked fine. I then tested my theory by FileUtils.expand_path-ing the destination in my own Docker setup code, and that made the problem go away, so that's what this merge request does.
      
      (I'm using backups created and restored on gitlab-ce 7-1-stable, at facfec4b; this is on Ubuntu 14.04 with Docker 1.1.1)
      
      I know I'd look askance at a PR without tests for an unreproducable problem, but even if this is rejected, I'm submitting it anyway because maybe someone else will Google it and find it useful. I'm happy to do more work to improve this if you have suggestions.
      
      See merge request !165
      0214a21d
    • D
      Merge branch 'rs-dev-issue-2355' into 'master' · 29b6d465
      Dmitriy Zaporozhets 提交于
      MergeRequest#show performance improvements
      
      This is a first pass on improving the performance of the `MergeRequests#show` page. Notable changes:
      
      - The "Commits" tab is loaded lazily, so the initial page load should be much faster for MRs with many commits.
      - Relative timestamps via `timeago` are only initialized once per load instead of `O(n^2)`. This greatly improves frontend rendering times for a large number of commits.
      - Refactored `User.find_for_commit` to use a single ARel-generated SQL query instead of the old method which resulted in one query, and could result in up to three.
      
      See merge request !838
      29b6d465
    • D
      ea9dda95
    • D
      791bf115
    • J
      Bump gitlab_git to 7.2.5 · cfc261d7
      Jacob Vosmaer 提交于
      cfc261d7
    • V
      changelog fix · 3d45b916
      Valery Sizov 提交于
      3d45b916
    • R
      Add MergeRequestTabs specs · e17020b9
      Robert Speicher 提交于
      e17020b9
    • R
      Minor style fixes in MergeRequestTabs · 8e72c65c
      Robert Speicher 提交于
      8e72c65c
  2. 21 6月, 2015 1 次提交
  3. 20 6月, 2015 19 次提交
  4. 19 6月, 2015 9 次提交