1. 03 8月, 2016 2 次提交
  2. 02 8月, 2016 3 次提交
    • P
      Speedup DiffNote#active? on discussions, preloading noteables and avoid... · 8716ff7f
      Paco Guzman 提交于
      Speedup DiffNote#active? on discussions, preloading noteables and avoid touching git repository to return diff_refs when possible
      
      - Preloading noteable we share the same noteable instance when more than one 
      discussion refers to the same noteable.
      - Any other call to that object that is cached in that object will be for any 
      discussion.
      - In those cases where merge_request_diff has all the sha stored to build a diff_refs get that 
      diff_refs using directly those sha instead accessing to the git repository to first get the 
      commits and later the sha.
      8716ff7f
    • R
      Remove `url_for_new_issue` helper · 901d4d2c
      Robert Speicher 提交于
      Now we link to the standard `IssuesController#new` action, and let it
      redirect if we're using an external tracker.
      901d4d2c
    • R
      Redirect to external issue tracker from `/issues` · a70431f8
      Robert Speicher 提交于
      Prior, in order to display the correct link to "Issues" in the project
      navigation, we were performing a check against the project to see if it
      used an external issue tracker, and if so, we used that URL. This was
      inefficient.
      
      Now, we simply _always_ link to `namespace_project_issues_path`, and
      then in the controller we redirect to the external tracker if it's
      present.
      
      This also removes the need for the url_for_issue helper. Bonus! 🎉
      a70431f8
  3. 01 8月, 2016 2 次提交
    • Z
      State specific default sort order for issuables · 84a3225b
      zs 提交于
      Provide more sensible default sort order for issues and merge requests
      based on the following table:
      
      | type           | state  | default sort order |
      |----------------|--------|--------------------|
      | issues         | open   | last created       |
      | issues         | closed | last updated       |
      | issues         | all    | last created       |
      | merge requests | open   | last created       |
      | merge requests | merged | last updated       |
      | merge requests | closed | last updated       |
      | merge requests | all    | last created       |
      84a3225b
    • Z
      Minor fixes in the Env API endpoints · 34c1c8a3
      Z.J. van de Weg 提交于
      34c1c8a3
  4. 29 7月, 2016 5 次提交
    • Z
      Add an URL field to Environments · be9aa7f1
      Z.J. van de Weg 提交于
      This MR adds a string (thus max 255 chars) field to the enviroments
      table to expose it later in other features.
      be9aa7f1
    • T
      Use `Gitlab::Access` to protected branch access levels. · 0a8aeb46
      Timothy Andrew 提交于
      1. It makes sense to reuse these constants since we had them duplicated
         in the previous enum implementation. This also simplifies our
         `check_access` implementation, because we can use
         `project.team.max_member_access` directly.
      
      2. Use `accepts_nested_attributes_for` to create push/merge access
         levels. This was a bit fiddly to set up, but this simplifies our code
         by quite a large amount. We can even get rid of
         `ProtectedBranches::BaseService`.
      
      3. Move API handling back into the API (previously in
         `ProtectedBranches::BaseService#translate_api_params`.
      
      4. The protected branch services now return a `ProtectedBranch` rather
         than `true/false`.
      
      5. Run `load_protected_branches` on-demand in the `create` action, to
         prevent it being called unneccessarily.
      
      6. "Masters" is pre-selected as the default option for "Allowed to Push"
         and "Allowed to Merge".
      
      7. These changes were based on a review from @rymai in !5081.
      0a8aeb46
    • T
      Humanize protected branches' access levels at one location. · f2df2966
      Timothy Andrew 提交于
      1. The model now contains this humanization data, which is the once
         source of truth.
      
      2. Previously, this was being listed out in the dropdown component as well.
      f2df2966
    • T
      Add "No One Can Push" to the protected branches UI. · ab6096c1
      Timothy Andrew 提交于
      1. Move to dropdowns instead of checkboxes. One each for "Allowed to
         Push" and "Allowed to Merge"
      
      2. Refactor the `ProtectedBranches` coffeescript class into
         `ProtectedBranchesAccessSelect`.
      
      3. Modify the backend to accept the new parameters.
      ab6096c1
    • T
      Use the `{Push,Merge}AccessLevel` models in the UI. · 134fe5af
      Timothy Andrew 提交于
      1. Improve error handling while creating protected branches.
      
      2. Modify coffeescript code so that the "Developers can *" checkboxes
         send a '1' or '0' even when using AJAX. This lets us keep the backend
         code simpler.
      
      3. Use services for both creating and updating protected branches.
         Destruction is taken care of with `dependent: :destroy`
      134fe5af
  5. 28 7月, 2016 2 次提交
    • H
      Fix the title of the toggle dropdown button · 94e6d51e
      Herminio Torres 提交于
      Before when you choose the way of `sort` instead it display the title correctly it was just apply the humanize helper in sort value.
      
      E.g.
      
      When you choose `Last updated` it should display the title `Last updated` instead of `Recently updated`. This fix makes this correctly displays the title.
      
      Change the implementation of the `link_to` `filter_branches_path`
      
      - Change the value of the `params[:sort]` in `link_to`. E.g. instead of using `'recently_updated'` is now using `sort_value_recently_updated`.
      
      - Change the values of the case in the `branches_sorted_by` method for the values it receives in the `params[:sort]` that are: `nil`, `'name'`, `'updated_desc'`, `'updated_asc'`.
      94e6d51e
    • A
      e4027e40
  6. 27 7月, 2016 6 次提交
  7. 26 7月, 2016 1 次提交
    • S
      Show release notes in tag list · e44bbcb9
      Sean McGivern 提交于
      A release's tag reference is just the name of the tag, not the entire
      tag object.
      
      This also fixes the tags index if a tag's message contains non-UTF8 byte
      sequences.
      e44bbcb9
  8. 21 7月, 2016 1 次提交
  9. 20 7月, 2016 12 次提交
  10. 19 7月, 2016 4 次提交
  11. 18 7月, 2016 2 次提交