- 03 7月, 2019 1 次提交
-
-
由 charlieablett 提交于
- Add a complexity of 1 if Gitaly is called at least once - Add an error notification if `calls_gitaly` isn't right for a particular field
-
- 28 6月, 2019 2 次提交
-
-
由 Phil Hughes 提交于
-
由 Luke Duncalfe 提交于
Adding new `AddAwardEmoji`, `RemoveAwardEmoji` and `ToggleAwardEmoji` GraphQL mutations. Adding new `#authorized_find_with_pre_checks!` and (unused, but for completeness `#authorized_find_with_post_checks!`) authorization methods. These allow us to perform an authorized find, and run our own additional checks before or after the authorization runs. https://gitlab.com/gitlab-org/gitlab-ce/issues/62826
-
- 21 6月, 2019 2 次提交
-
-
由 Bob Van Landuyt 提交于
This makes sure we also enforce authorizations for non-nullable fields. We are defining our authorizations on the unwrapped types (Repository). But when a type like that is presented in a non-nullable field, it's type is different (Repository!). The non-nullable type would not have the authorization metadata. This makes sure we check the metadata on the unwrapped type for finding authorizations.
-
由 Bob Van Landuyt 提交于
This also disables the cop with a reasoning in types where appropriate
-
- 20 6月, 2019 1 次提交
-
-
由 Bob Van Landuyt 提交于
This adds a `markdown_field` to our types. Using this helper will render a model's markdown field using the existing `MarkupHelper` with the context of the GraphQL query available to the helper. Having the context available to the helper is needed for redacting links to resources that the current user is not allowed to see. Because rendering the HTML can cause queries, the complexity of a these fields is raised by 5 above the default. The markdown field helper can be used as follows: ``` markdown_field :note_html, null: false ``` This would generate a field that will render the markdown field `note` of the model. This could be overridden by adding the `method:` argument. Passing a symbol for the method name: ``` markdown_field :body_html, null: false, method: :note ``` It will have this description by default: > The GitLab Flavored Markdown rendering of `note` This could be overridden by passing a `description:` argument. The type of a `markdown_field` is always `GraphQL::STRING_TYPE`.
-
- 15 6月, 2019 2 次提交
-
-
由 Patrick Derichs 提交于
Add specs for task completion status (graphql) Fix style issues Changed format of constants in spec Refactor specs to reduce creation of records Reduce parameters to merge request creation Use set's for project and user Move let's out of it_behaves_like block Fix description parameter Fix format of lets Use dig to get task completion status out of graphql response Modified rspec output Add changelog entry
-
由 Mayra Cabrera 提交于
Add the missing check on GraphQL API for project statistics
-
- 14 6月, 2019 1 次提交
-
-
由 Bob Van Landuyt 提交于
This exposes `Note`s on Issues & MergeRequests using a `Types::Notes::NoteableType` in GraphQL. Exposing notes on a new type can be done by implementing the `NoteableType` interface on the type. The presented object should be a `Noteable`.
-
- 11 6月, 2019 1 次提交
-
-
由 Bob Van Landuyt 提交于
Since we're not actually loading commits in that loader, but we're loading blobs with LFS oids in batch and returning only the oids.
-
- 10 6月, 2019 1 次提交
-
-
由 Phil Hughes 提交于
-
- 05 6月, 2019 3 次提交
-
-
由 Brett Walker 提交于
-
由 Brett Walker 提交于
This helps reduce complexity for non-connections
-
由 Phil Hughes 提交于
-
- 04 6月, 2019 3 次提交
-
-
由 Alessio Caiazza 提交于
-
由 Bob Van Landuyt 提交于
Since the `GraphQL::ID_TYPE` usages should represent globally unique ids, this changes some fields for which this is not the case into strings. The `ID_TYPE` is a specialised, so this change should be backwards compatible. https://graphql-ruby.org/type_definitions/scalars.html
-
由 Bob Van Landuyt 提交于
This exposes all fields named `id` as GlobalIDs so they can be used across our entire GraphQL implementation. When the objects loaded are `ApplicationRecord`s. We'll use our existing batchloading to find them. Otherwise, we'll fall back to the default implementation of `GlobalID`: Calling the `.find` method on the class.
-
- 03 6月, 2019 1 次提交
-
-
由 Alessio Caiazza 提交于
We can query namespaces, and nested projects. Projects now exposes statistics
-
- 01 6月, 2019 1 次提交
-
-
由 Brett Walker 提交于
and allow passing of child_complexity to the 'resolver_complexity' metho
-
- 22 5月, 2019 1 次提交
-
-
由 Phil Hughes 提交于
-
- 21 5月, 2019 1 次提交
-
-
由 Brett Walker 提交于
-
- 07 5月, 2019 1 次提交
-
-
由 Jan Provaznik 提交于
If a field is a resolver, its complexity is automatically increased. By default we add extra points for sort and search arguments (which will be common for various resolvers). For specific resolvers we add field-specific complexity, e.g. for Issues complexity is increased if we filter issues by `labelName` (because then SQL query is more complex). We may want to tune these values in future depending on real-life results. Complexity is also dependent on the number of loaded nodes, but only if we don't search by specific ID(s). Also added complexity is limited (by default only twice more than child complexity) - the reason is that although it's more complex to process more items, the complexity increase is not linear (there is not so much difference between loading 10, 20 or 100 records from DB).
-
- 24 4月, 2019 2 次提交
-
-
由 Brett Walker 提交于
and removing unnecessary code
-
由 Brett Walker 提交于
Add new query for Groups, with new GroupType and NamespaceType
-
- 04 4月, 2019 1 次提交
-
-
由 Brett Walker 提交于
It makes all Types::BaseField default to a complexity of 1. Queries themselves now have limited complexity, scaled to the type of user: no user, authenticated user, or an admin user.
-
- 03 4月, 2019 1 次提交
-
-
由 Luke Duncalfe 提交于
Enables authorizations to be defined on GraphQL Types. module Types class ProjectType < BaseObject authorize :read_project end end If a field has authorizations defined on it, and the return type of the field also has authorizations defined on it. then all of the combined permissions in the authorizations will be checked and must pass. Connection fields are checked by "digging" to find the type class of the "node" field in the expected location of edges->node. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54417
-
- 21 3月, 2019 1 次提交
-
-
由 Sam Bigelow 提交于
- Show pipeline status, title, MR Status and project path - Popover attached to gitlab flavored markdown everywhere, including: + MR/Issue Title + MR/Issue description + MR/Issue comments + Rendered markdown files
-
- 05 3月, 2019 1 次提交
-
-
由 Nick Thomas 提交于
-
- 26 2月, 2019 1 次提交
-
-
由 Luke Duncalfe 提交于
Previously GraphQL field authorization happened like this: class ProjectType field :my_field, MyFieldType do authorize :permission end end This change allowed us to authorize like this instead: class ProjectType field :my_field, MyFieldType, authorize: :permission end A new initializer registers the `authorize` metadata keyword on GraphQL Schema Objects and Fields, and we can collect this data within the context of Instrumentation like this: field.metadata[:authorize] The previous functionality of authorize is still being used for mutations, as the #authorize method here is called at during the code that executes during the mutation, rather than when a field resolves. https://gitlab.com/gitlab-org/gitlab-ce/issues/57828
-
- 21 2月, 2019 1 次提交
-
-
由 Rémy Coutable 提交于
Signed-off-by: NRémy Coutable <remy@rymai.me>
-
- 18 2月, 2019 2 次提交
-
-
由 Luke Duncalfe 提交于
-
由 Luke Duncalfe 提交于
defaultBranch and ciConfigPath should only be available to users with the :download_code permission for the Project, as the respository might be private. When implementing the authorize check on these properties, it was found that our current Graphql::Authorize::Instrumentation class does not work with fields that resolve to subclasses of GraphQL::Schema::Scalar, like GraphQL::STRING_TYPE. After discussion with other Create Team members, it has been decided that because the GraphQL API is not GA, to remove these properties from ProjectType, and instead implement them as part of epic https://gitlab.com/groups/gitlab-org/-/epics/711 Issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/55316
-
- 14 2月, 2019 3 次提交
-
-
由 Lin Jen-Shin 提交于
-
由 Lin Jen-Shin 提交于
And add tests
-
由 Lin Jen-Shin 提交于
And fix the tests so that it won't run into circular paths.
-
- 06 2月, 2019 1 次提交
-
-
由 Luke Duncalfe 提交于
-
- 24 1月, 2019 1 次提交
-
-
由 Rémy Coutable 提交于
Signed-off-by: NRémy Coutable <remy@rymai.me>
-
- 27 11月, 2018 1 次提交
-
-
由 Phil Hughes 提交于
This suggests possibly related issues when the user types a title. This uses GraphQL to allow the frontend to request the exact data that is requires. We also get free caching through the Vue Apollo plugin. With this we can include the ability to import .graphql files in JS and Vue files. Also we now have the Vue test utils library to make testing Vue components easier. Closes #22071
-
- 05 10月, 2018 1 次提交
-
-
由 Tuomo Ala-Vannesluoma 提交于
-
- 12 9月, 2018 1 次提交
-
-
由 gfyoung 提交于
Partially addresses #47424.
-