- 08 9月, 2017 1 次提交
-
-
由 Yorick Peterse 提交于
Whenever you push to a branch GitLab will show a button to create a merge request (should one not exist already). The underlying code to display this data was quite inefficient. For example, it involved multiple slow queries just to figure out what the most recent push event was. This commit changes the way this data is retrieved so it's much faster. This is achieved by caching the ID of the last push event on every push, which is then retrieved when loading certain pages. Database queries are only executed if necessary and the cached data is removed automatically once a merge request has been created, or 2 hours after being stored. A trade-off of this approach is that we _only_ track the last event. Previously if you were to push to branch A and B then create a merge request for branch B we'd still show the widget for branch A. As of this commit this is no longer the case, instead we will only show the widget for the branch you pushed to most recently. Once a merge request exists the widget is no longer displayed. Alternative solutions are either too complex and/or too slow, hence the decision was made to settle for this trade-off. Performance Impact ------------------ In the best case scenario (= a user didn't push anything for more than 2 hours) we perform a single Redis GET per page. Should there be cached data we will run a single (and lightweight) SQL query to get the event data from the database. If a merge request already exists we will run an additional DEL to remove the cache key. The difference in response timings can vary a bit per project. On GitLab.com the 99th percentile of time spent in User#recent_push hovers between 100 milliseconds and 1 second, while the mean hovers around 50 milliseconds. With the changes in this MR the expected time spent in User#recent_push is expected to be reduced down to just a few milliseconds. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/35990
-
- 07 9月, 2017 5 次提交
-
-
由 Maxim Rydkin 提交于
-
由 Maxim Rydkin 提交于
-
由 Maxim Rydkin 提交于
-
由 Maxim Rydkin 提交于
-
由 Maxim Rydkin 提交于
-
- 15 8月, 2017 1 次提交
-
-
由 Yorick Peterse 提交于
In some cases we pass an Array to this method which would previously fail since Array does not respond to "limit_value". Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/3646
-
- 07 8月, 2017 1 次提交
-
-
由 Yorick Peterse 提交于
In various places we check if the same relation would return projects. This is done using "any?" which will run a COUNT query with any LIMIT/OFFSET values still applied. To work around all this we introduce 2 helper methods that take care of doing the right thing. This leads to the produced queries being simpler and fewer queries being executed.
-
- 03 8月, 2017 1 次提交
-
-
由 Robert Speicher 提交于
-
- 02 8月, 2017 1 次提交
-
-
由 Robert Speicher 提交于
-
- 01 8月, 2017 1 次提交
-
-
由 Gabriel Mazetto 提交于
-
- 13 7月, 2017 1 次提交
-
-
由 Robin Bobbitt 提交于
When sign-in is disabled: - skip password expiration checks - prevent password reset requests - don’t show Password tab in User Settings - don’t allow login with username/password for Git over HTTP requests - render 404 on requests to Profiles::PasswordsController
-
- 11 7月, 2017 1 次提交
-
-
由 Paul Charlton 提交于
-
- 27 6月, 2017 1 次提交
-
-
由 Robin Bobbitt 提交于
If internal auth is disabled and user is not an LDAP user, present the user with an alert to create a personal access token if he does not have one already.
-
- 15 6月, 2017 1 次提交
-
-
由 Robert Speicher 提交于
-
- 13 6月, 2017 1 次提交
-
-
由 Kamil Trzcinski 提交于
-
- 06 6月, 2017 1 次提交
-
-
由 Mike Greiling 提交于
-
- 12 5月, 2017 2 次提交
-
-
由 Dmitriy Zaporozhets 提交于
Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
由 Dmitriy Zaporozhets 提交于
Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 26 4月, 2017 1 次提交
-
-
由 Bob Van Landuyt 提交于
-
- 21 4月, 2017 1 次提交
-
-
由 Jeff Stubler 提交于
-
- 17 4月, 2017 1 次提交
-
-
由 James Lopez 提交于
-
- 07 4月, 2017 1 次提交
-
-
由 Bob Van Landuyt 提交于
-
- 06 4月, 2017 1 次提交
-
-
由 DJ Mountney 提交于
Fix for path disclosure in project import/export See merge request !2080
-
- 16 3月, 2017 1 次提交
-
-
由 Bob Van Landuyt 提交于
-
- 05 2月, 2017 1 次提交
-
- 26 1月, 2017 1 次提交
-
-
由 Robert Speicher 提交于
-
- 07 10月, 2016 1 次提交
-
-
由 Dmitriy Zaporozhets 提交于
Signed-off-by: NDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 27 9月, 2016 1 次提交
-
-
由 Nick Thomas 提交于
Projects::ForkService delegates to this service almost entirely, but needed one small change so it would propagate create errors correctly. CreateService#execute needs significant refactoring; it is now right at the complexity limit set by Rubocop. I avoided doing so in this commit to keep the diff as small as possible. Several tests depend on the insecure behaviour of ForkService, so fi them up at the same time.
-
- 07 9月, 2016 1 次提交
-
-
由 Felipe Artur 提交于
-
- 25 8月, 2016 1 次提交
-
-
由 Paco Guzman 提交于
-
- 30 6月, 2016 1 次提交
-
-
由 Alejandro Rodríguez 提交于
-
- 16 6月, 2016 2 次提交
-
-
由 James Lopez 提交于
This reverts commit 13e37a3e.
-
由 James Lopez 提交于
-
- 14 6月, 2016 2 次提交
-
-
由 Rémy Coutable 提交于
+ Move 'Edit Project/Group' out of membership-related partial + Show the access request buttons only to logged-in users + Put the request access buttons out of in a more visible button + Improve the copy in the #remove_member_message helper Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 Rémy Coutable 提交于
Signed-off-by: NRémy Coutable <remy@rymai.me>
-
- 03 6月, 2016 2 次提交
-
-
由 James Lopez 提交于
This reverts commit 3e991230.
-
由 James Lopez 提交于
# Conflicts: # app/models/project.rb
-
- 05 5月, 2016 2 次提交
-
-
由 Stan Hu 提交于
Closes #17243
-
由 Robert Speicher 提交于
Mostly replaces several Spinach tests with RSpec Feature tests.
-