1. 18 12月, 2017 1 次提交
  2. 16 12月, 2017 2 次提交
  3. 15 12月, 2017 7 次提交
    • G
      Fix UX issues in system info page · dd4b6db2
      Gilbert Roulot 提交于
      dd4b6db2
    • D
      Make sure user email is read only when synced with LDAP · 481b8a71
      Douwe Maan 提交于
      481b8a71
    • S
      Don't use Markdown cache for stubbed settings in specs · 10885edf
      Sean McGivern 提交于
      The ApplicationSetting model uses the CacheMarkdownField concern, which updates
      the cached HTML when the field is updated in the database. However, in specs,
      when we want to test conditions using ApplicationSetting, we stub it, because
      this is accessed in different ways throughout the application.
      
      This means that if a spec runs that caches one of the Markdown fields, and a
      later spec uses `stub_application_setting` to set the raw value of that field,
      the cached value was still the original one. We can work around this by ignoring
      the Markdown cache in contexts where we're using `stub_application_setting`.
      
      We could be smarter, and only do this on the Markdown fields of the model, but
      this is probably fine.
      10885edf
    • P
      Export JS classes as modules · 29e1a63d
      Phil Hughes 提交于
      #38869
      29e1a63d
    • A
      Simplify conflict resolver interface · 240945f8
      Alejandro Rodríguez 提交于
      This does two things:
      - Pass commit oids instead of `Gitlab::Git::Commit`s. We only need the
      former.
      - Depend on only the target repository for conflict listing. For
      conflict resolution, treat one repository as a remote one so that we can
      implement it as such in Gitaly.
      240945f8
    • D
      clearer-documentation-on-inline-diffs · 7c20829c
      Dimitrie Hoekstra 提交于
      7c20829c
    • N
      Import gitlab_projects.rb from gitlab-shell · 4b785df2
      Nick Thomas 提交于
      By importing this Ruby code into gitlab-rails (and gitaly-ruby), we avoid
      200ms of startup time for each gitlab_projects subprocess we are eliminating.
      
      By not having a gitlab_projects subprocess between gitlab-rails / sidekiq and
      any git subprocesses (e.g. for fork_project, fetch_remote, etc, calls), we can
      also manage these git processes more cleanly, and avoid sending SIGKILL to them
      4b785df2
  4. 14 12月, 2017 13 次提交
  5. 13 12月, 2017 16 次提交
  6. 12 12月, 2017 1 次提交
    • Z
      Use memoization for commits on diffs · 3ab026b7
      Zeger-Jan van de Weg 提交于
      The Gitaly CommitService is being hammered by n + 1 calls, mostly when
      finding commits. This leads to this gRPC being turned of on production:
      https://gitlab.com/gitlab-org/gitaly/issues/514#note_48991378
      
      Hunting down where it came from, most of them were due to
      MergeRequest#show. To prove this, I set a script to request the
      MergeRequest#show page 50 times. The GDK was being scraped by
      Prometheus, where we have metrics on controller#action and their Gitaly
      calls performed. On both occations I've restarted the full GDK so all
      caches had to be rebuild.
      
      Current master, 806a68a8, needed 435 requests
      After this commit, 154 requests
      3ab026b7