- 16 2月, 2019 1 次提交
-
-
由 Natalia Tepluhina 提交于
- replaced file.too_large - replaced file.text - replaced file.collapsed
-
- 27 12月, 2018 1 次提交
-
-
由 Francisco Javier López 提交于
This commit, introduced in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23812, fixes a problem creating a displaying image diff notes when the image is stored in LFS. The main problem was that `Gitlab::Diff::File` was returning an invalid valid in `text?` for this kind of files. It also fixes a rendering problem with other LFS files, like text ones. They LFS pointer shouldn't be shown when LFS is enabled for the project, but they were.
-
- 22 12月, 2018 1 次提交
-
-
由 Oswaldo Ferreira 提交于
This commit handles note diffs caching, which considerably improves the performance on merge requests with lots of comments. Important to note that the caching approach taken here is different from `Gitlab::Diff::HighlightCache`. We do not reset the whole cache when a new push is sent or anything else. That's because discussions diffs are persisted and do not change.
-
- 14 12月, 2018 1 次提交
-
-
由 Oswaldo Ferreira 提交于
-
- 12 12月, 2018 1 次提交
-
-
由 Sean Nichols 提交于
-
- 10 11月, 2018 1 次提交
-
-
由 Oswaldo Ferreira 提交于
-
- 08 11月, 2018 1 次提交
-
-
由 Oswaldo Ferreira 提交于
This reverts commit a82a5957, reversing changes made to e7df959b.
-
- 07 11月, 2018 2 次提交
-
-
由 gfyoung 提交于
Enables frozens string for the following: * lib/gitlab/conflict/**/*.rb * lib/gitlab/cross_project_access/**/*.rb * lib/gitlab/cycle_analytics/**/*.rb * lib/gitlab/data_builder/**/*.rb * lib/gitlab/database/**/*.rb * lib/gitlab/dependency_linker/**/*.rb * lib/gitlab/diff/**/*.rb * lib/gitlab/downtime_check/**/*.rb * lib/gitlab/email/**/*.rb * lib/gitlab/etag_caching/**/*.rb Partially addresses gitlab-org/gitlab-ce#47424.
-
由 Oswaldo Ferreira 提交于
-
- 19 9月, 2018 1 次提交
-
-
由 Oswaldo Ferreira 提交于
-
- 11 9月, 2018 1 次提交
-
-
由 Yorick Peterse 提交于
This whitelists all existing offenses for the various CodeReuse cops, of which most are triggered by the CodeReuse/ActiveRecord cop.
-
- 04 7月, 2018 1 次提交
-
-
由 Felipe Artur 提交于
-
- 29 6月, 2018 1 次提交
-
-
由 Jan Provaznik 提交于
If a file is deleted, its new_pos is 0 (less than total_blob_lines), but there is no reason to add the bottom 'match' line in this case because there is not extra content which could be expanded.
-
- 21 6月, 2018 1 次提交
-
-
由 Felipe Artur 提交于
-
- 05 6月, 2018 1 次提交
-
-
由 Oswaldo Ferreira 提交于
This currently causes 500's errors when loading the MR page (Discussion) in a few scenarios. We were not considering detailed diff headers such as "--- a/doc/update/mysql_to_postgresql.md\n+++ b/doc/update/mysql_to_postgresql.md" to crop the diff. In order to address it, we're now using Gitlab::Diff::Parser, clean the diffs and builds Gitlab::Diff::Line objects we can iterate and filter on.
-
- 25 5月, 2018 1 次提交
-
-
由 Oswaldo Ferreira 提交于
We request Gitaly in a N+1 manner to build discussion diffs. Once the diffs are from different revisions, it's hard to make a single request to the service in order to build the whole response. With this change we solve this problem and simplify a lot fetching this piece of info.
-
- 17 3月, 2018 1 次提交
-
-
由 Sean McGivern 提交于
These can be a `BatchLoader` which is proxying a nil, while not being concrete nils themselves.
-
- 04 1月, 2018 1 次提交
-
-
由 Sean McGivern 提交于
Old merge requests can have diffs without corresponding blobs. (This also may be possible for commit diffs in corrupt repositories.) We can't use the `&.` operator on the blobs, because the blob objects are never nil, but `BatchLoader` instances that delegate to `Blob`. We can't use `Object#try`, because `Blob` doesn't inherit from `Object`. `BatchLoader` provides a `__sync` method that returns the delegated object, but using `itself` also works because it's forwarded, and will work for non-`BatchLoader` instances too. So the simplest solution is to just use that with the `&.` operator.
-
- 23 12月, 2017 1 次提交
-
-
由 Douwe Maan 提交于
Improve performance of DiffDiscussion#truncated_diff_lines and DiffNote#diff_line by removing expensive diff position calculation and comparison
-
- 21 11月, 2017 1 次提交
-
-
由 Zeger-Jan van de Weg 提交于
After installing a new gem, batch-loader, a construct can be used to queue data to be fetched in bulk. The gem was also introduced in both gitlab-org/gitlab-ce!14680 and gitlab-org/gitlab-ce!14846, but those mrs are not merged yet. For the generation of diffs, both the old blob and the new blob need to be loaded. This for every file in the diff, too. Now we collect all these so we do 1 fetch. Three `.allow_n_plus_1_calls` have been removed, which I expect to be valid, but this needs to be confirmed by a full CI run. Possibly closes: - https://gitlab.com/gitlab-org/gitlab-ce/issues/37445 - https://gitlab.com/gitlab-org/gitlab-ce/issues/37599 - https://gitlab.com/gitlab-org/gitlab-ce/issues/37431
-
- 13 10月, 2017 3 次提交
-
-
由 Alejandro Rodríguez 提交于
Having a distinct class just for that was a bit overkill
-
由 Alejandro Rodríguez 提交于
Rename classes to (hopefully) clearer names while we're doing that.
-
由 Alejandro Rodríguez 提交于
-
- 07 10月, 2017 1 次提交
-
-
由 Felipe Artur 提交于
-
- 21 9月, 2017 1 次提交
-
-
由 Ahmad Sherif 提交于
Closes gitaly#524
-
- 24 8月, 2017 1 次提交
-
-
由 Sean McGivern 提交于
For some old merge requests, we don't have enough information to figure out the old blob and the new blob for the file. This means that we can't highlight the diff correctly, but we can still display it without highlighting.
-
- 22 8月, 2017 1 次提交
-
-
由 Sean McGivern 提交于
We didn't have a fallback case before, because we believed the conditions were exhaustive. They weren't, so we can always fallback to not previewing.
-
- 31 7月, 2017 1 次提交
-
-
由 Jacob Vosmaer 提交于
-
- 14 6月, 2017 1 次提交
-
-
由 Douwe Maan 提交于
-
- 08 6月, 2017 2 次提交
-
-
由 Douwe Maan 提交于
-
由 Douwe Maan 提交于
-
- 24 5月, 2017 3 次提交
-
-
由 Douwe Maan 提交于
-
由 Douwe Maan 提交于
-
由 Douwe Maan 提交于
-
- 29 11月, 2016 1 次提交
-
-
由 Sean McGivern 提交于
-
- 25 11月, 2016 2 次提交
-
-
由 hhoopes 提交于
* Added keyword arguments to truncated_diff_lines method to allow for using highlighting or not (html templates vs. text) * Tweaked templates for consistency and format appropriateness
-
由 hhoopes 提交于
Previously the `truncated_diff_lines` method for outputting a discussion diff took in already highlighted lines, which meant it wasn't reuseable for truncating ANY lines. In the way it was used, it also meant that for any email truncation, the whole diff was being highlighted before being truncated, meaning wasted time highlighting lines that wouldn't even be used (granted, they were being memoized, so perhaps this wasn't that great of an issue). I refactored truncation away from highlighting, in order to truncate formatted diffs for text templates in email, using `>`s to designate each line, but otherwise retaining the parsing already done to create `diff_lines`. Additionally, while notes on merge requests or commits had already been tested, there was no existing test for notes on a diff on an MR or commit. Added mailer tests for such, and a unit test for truncating diff lines.
-
- 14 11月, 2016 1 次提交
-
-
由 Stan Hu 提交于
Steps to reproduce: 1. Start with a repo with an image 2. Add a commit to delete the image 3. Add another commit to replace the image with another image In a diff comparison, we really just compare about what the image was before the diff, not the direct parent of the last commit. This MR fixes that. Closes #3893, gitlab-org/gitlab-ee#678 Signed-off-by: NRémy Coutable <remy@rymai.me>
-
- 11 11月, 2016 1 次提交
-
-
由 Adam Niedzielski 提交于
In this case comparing old_path and new_path is not enough because there are two entires that match.
-
- 18 10月, 2016 1 次提交
-
-
由 Adam Niedzielski 提交于
In this specific case using file_path as a cache key is not enough, because there are two entries with the same path. Closes #21610.
-